| Message ID | 20230812091708.34665-2-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Document internal MDIO bus of DSA switch and support it on MT7530 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
| netdev/cc_maintainers | success | CCed 18 of 18 maintainers |
| netdev/build_clang | success | Errors and warnings before: 9 this patch: 9 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 9 this patch: 9 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 23 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Sat, Aug 12, 2023 at 12:17:05PM +0300, Arınç ÜNAL wrote: > The port@5 node on the example is missing the ethernet property. Add it. > Remove the MAC bindings on the example as they cannot be validated. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > .../bindings/net/dsa/microchip,lan937x.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml > index 8d7e878b84dc..49af4b0d5916 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml > @@ -68,16 +68,6 @@ examples: > - | > #include <dt-bindings/gpio/gpio.h> > > - macb0 { > - #address-cells = <1>; > - #size-cells = <0>; > - > - fixed-link { > - speed = <1000>; > - full-duplex; > - }; > - }; > - > spi { > #address-cells = <1>; > #size-cells = <0>; > @@ -138,6 +128,7 @@ examples: > phy-mode = "rgmii"; > tx-internal-delay-ps = <2000>; > rx-internal-delay-ps = <2000>; > + ethernet = <&macb1>; macb1 instead of macb0: was it intentional? > > fixed-link { > speed = <1000>; > -- > 2.39.2 >
On 13.08.2023 14:07, Vladimir Oltean wrote: > On Sat, Aug 12, 2023 at 12:17:05PM +0300, Arınç ÜNAL wrote: >> The port@5 node on the example is missing the ethernet property. Add it. >> Remove the MAC bindings on the example as they cannot be validated. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> --- >> .../bindings/net/dsa/microchip,lan937x.yaml | 11 +---------- >> 1 file changed, 1 insertion(+), 10 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml >> index 8d7e878b84dc..49af4b0d5916 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml >> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml >> @@ -68,16 +68,6 @@ examples: >> - | >> #include <dt-bindings/gpio/gpio.h> >> >> - macb0 { >> - #address-cells = <1>; >> - #size-cells = <0>; >> - >> - fixed-link { >> - speed = <1000>; >> - full-duplex; >> - }; >> - }; >> - >> spi { >> #address-cells = <1>; >> #size-cells = <0>; >> @@ -138,6 +128,7 @@ examples: >> phy-mode = "rgmii"; >> tx-internal-delay-ps = <2000>; >> rx-internal-delay-ps = <2000>; >> + ethernet = <&macb1>; > > macb1 instead of macb0: was it intentional? Yes, port@4 defines macb0. I used macb1 for port@5 here. Arınç
On Sat, Aug 12, 2023 at 12:17:05PM +0300, Arınç ÜNAL wrote: > The port@5 node on the example is missing the ethernet property. Add it. > Remove the MAC bindings on the example as they cannot be validated. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com> > .../bindings/net/dsa/microchip,lan937x.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml > index 8d7e878b84dc..49af4b0d5916 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml > @@ -68,16 +68,6 @@ examples: > - | > #include <dt-bindings/gpio/gpio.h> > > - macb0 { > - #address-cells = <1>; > - #size-cells = <0>; > - > - fixed-link { > - speed = <1000>; > - full-duplex; > - }; > - }; > - > spi { > #address-cells = <1>; > #size-cells = <0>; > @@ -138,6 +128,7 @@ examples: > phy-mode = "rgmii"; > tx-internal-delay-ps = <2000>; > rx-internal-delay-ps = <2000>; > + ethernet = <&macb1>; > > fixed-link { > speed = <1000>; > -- > 2.39.2 >
On 8/12/23 02:17, Arınç ÜNAL wrote: > The port@5 node on the example is missing the ethernet property. Add it. > Remove the MAC bindings on the example as they cannot be validated. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Sat, 12 Aug 2023 12:17:05 +0300, Arınç ÜNAL wrote: > The port@5 node on the example is missing the ethernet property. Add it. > Remove the MAC bindings on the example as they cannot be validated. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > .../bindings/net/dsa/microchip,lan937x.yaml | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml index 8d7e878b84dc..49af4b0d5916 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml @@ -68,16 +68,6 @@ examples: - | #include <dt-bindings/gpio/gpio.h> - macb0 { - #address-cells = <1>; - #size-cells = <0>; - - fixed-link { - speed = <1000>; - full-duplex; - }; - }; - spi { #address-cells = <1>; #size-cells = <0>; @@ -138,6 +128,7 @@ examples: phy-mode = "rgmii"; tx-internal-delay-ps = <2000>; rx-internal-delay-ps = <2000>; + ethernet = <&macb1>; fixed-link { speed = <1000>;
The port@5 node on the example is missing the ethernet property. Add it. Remove the MAC bindings on the example as they cannot be validated. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- .../bindings/net/dsa/microchip,lan937x.yaml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)