| Message ID | 20230811190032.13391-2-rohan.g.thomas@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Tx coe sw fallback for unsupported queues | expand |
On 11/08/2023 21:00, Rohan G Thomas wrote: > Add dt-bindings for the number of tx queues with coe support. Some > dwmac IPs support tx queues only for a few initial tx queues, > starting from tx queue 0. > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> 1. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least DT list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. 2. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Best regards, Krzysztof
On 11/08/2023 21:00, Rohan G Thomas wrote: > > Add dt-bindings for the number of tx queues with coe support. Some > > dwmac IPs support tx queues only for a few initial tx queues, starting > > from tx queue 0. > > > > Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> > > 1. Please use scripts/get_maintainers.pl to get a list of necessary people and > lists to CC. It might happen, that command when run on an older kernel, > gives you outdated entries. Therefore please be sure you base your patches > on recent Linux kernel. > > You missed at least DT list (maybe more), so this won't be tested by > automated tooling. Performing review on untested code might be a waste of > time, thus I will skip this patch entirely till you follow the process allowing the > patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. Oops, missed running the script and to get the latest maintainers list before sending v2. Thanks for pointing this out. I'll resend the patchset. > 2. Do not attach (thread) your patchsets to some other threads (unrelated or > older versions). This buries them deep in the mailbox and might interfere > with applying entire sets. Sure. Noted. Thanks. BR, Rohan
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index ddf9522a5dc2..0c6431c10cf9 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -313,6 +313,9 @@ properties: snps,tx-queues-to-use: $ref: /schemas/types.yaml#/definitions/uint32 description: number of TX queues to be used in the driver + snps,tx-queues-with-coe: + $ref: /schemas/types.yaml#/definitions/uint32 + description: number of TX queues that support TX checksum offloading snps,tx-sched-wrr: type: boolean description: Weighted Round Robin
Add dt-bindings for the number of tx queues with coe support. Some dwmac IPs support tx queues only for a few initial tx queues, starting from tx queue 0. Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++ 1 file changed, 3 insertions(+)