| Message ID | 20230809084559.17322-1-a-bhatia1@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: ti: k3-am62: Add display support | expand |
On 14:15-20230809, Aradhya Bhatia wrote: > Hi all, > > The patch series adds DT nodes for Display SubSystem (DSS) and other > peripherals required to enable the HDMI audio and video on the AM625 SK, > AM62-LP SK, as well as the AM625 based Beagle-Play platforms. An HDMI > monitor can be connected to the boards for the audio/video outputs. > > The series adding the compatible and basic driver support[0] is in the > drm-misc-next and linux-next queues and is expected to be in the > mainline by v6.6-rc1. Patch 5/6 also requires Nishanth Menon's patch[1] > that introduces debounce select mux macros. This patch too is not in > v6.5-rc1 but has been picked up in ti-next[2] and hence, is present in > linux-next. > > Patches 4 and 5 have been picked up from TI's vendor tree[3] based off > linux-kernel v6.1. > > Regards > Aradhya > > Change Log: > V4 -> V5: > - Cosmetic changes as suggested by Jayesh. > - Fixed the mis-represented DSS VP1 clock, and added a > fixed-factor-clock. > > V3 -> V4: > - Added "Fixes" tag for patch 1/6. > - Rebased to linux-next. > - Enabled display at board level and disabled at SoC level. > - Dropped OLDI pinmux configuration as OLDI output comes directly from > the SoC and muxing is not required. > - Squashed DSS pinmux patches into their platform specific HDMI > support patches, because it did not make sense to have only one set > of pinmux config separated in a patch. > > V2 -> V3: > - Updated the compatible from "ti,am65x-dss" to "ti,am625-dss". > - Peripheral nodes like HDMI TX, HDMI connector are now added to > k3-am62x-sk-common.dtsi instead of k3-am625-sk.dts, in order to > support AM62-LP SK-EVM as well. > - Dropped the HDMI master clock node as it is not connected on the > EVM, and should not have been added in the first place. > - Re-worded and Re-ordered commits. > - Dropped Rahul Ravikumar's R-bs because of the changes. > - Added AM625 based Beagle-Play for HDMI support. > - Added HDMI audio support as well. > > V1 -> V2: > - Removed repetitive data in dss_ports > > V4: https://lore.kernel.org/all/20230807153307.22174-1-a-bhatia1@ti.com/ > V3: https://lore.kernel.org/all/20230728173438.12995-1-a-bhatia1@ti.com/ > V2: https://lore.kernel.org/all/20220505134303.23208-1-a-bhatia1@ti.com/ > V1: https://lore.kernel.org/all/20220427090850.32280-1-a-bhatia1@ti.com/ > > [0]: https://lore.kernel.org/all/20230616150900.6617-1-a-bhatia1@ti.com/ > [1]: https://lore.kernel.org/all/20230619131620.3286650-1-nm@ti.com/ > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/commit/?id=0bec3d7ecc7493b0e530f6f34539841ef6779006 > [3]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?h=ti-linux-6.1.y-cicd > > > Aradhya Bhatia (4): > arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency > arm64: dts: ti: k3-am62-main: Add node for DSS > arm64: dts: ti: k3-am62x-sk-common: Add HDMI support > arm64: defconfig: Enable ITE_IT66121 HDMI transmitter > > Jai Luthra (1): > arm64: dts: ti: am62x-sk: Add overlay for HDMI audio > > Nishanth Menon (1): > arm64: dts: ti: k3-am625-beagleplay: Add HDMI support > > arch/arm64/boot/dts/ti/Makefile | 3 + > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 25 +++ > arch/arm64/boot/dts/ti/k3-am62.dtsi | 8 + > .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 150 ++++++++++++++++++ > .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 93 ++++++++++- > .../boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso | 40 +++++ > arch/arm64/configs/defconfig | 1 + > 7 files changed, 319 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso > > > base-commit: 71cd4fc492ec41e4acd85e98bbf7a13753fc1e03 > -- > 2.40.1 > Can you help cleanup the following before we start introducing new oldi and dss support? I am not sure if these were introduced due to yaml updates or something pre-existing. linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: linux/build/arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: linux/build/arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: linux/build/arch/arm64/boot/dts/ti/k3-am654-base-board.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed:
On 8/9/23 9:40 AM, Nishanth Menon wrote: > On 14:15-20230809, Aradhya Bhatia wrote: >> Hi all, >> >> The patch series adds DT nodes for Display SubSystem (DSS) and other >> peripherals required to enable the HDMI audio and video on the AM625 SK, >> AM62-LP SK, as well as the AM625 based Beagle-Play platforms. An HDMI >> monitor can be connected to the boards for the audio/video outputs. >> >> The series adding the compatible and basic driver support[0] is in the >> drm-misc-next and linux-next queues and is expected to be in the >> mainline by v6.6-rc1. Patch 5/6 also requires Nishanth Menon's patch[1] >> that introduces debounce select mux macros. This patch too is not in >> v6.5-rc1 but has been picked up in ti-next[2] and hence, is present in >> linux-next. >> >> Patches 4 and 5 have been picked up from TI's vendor tree[3] based off >> linux-kernel v6.1. >> >> Regards >> Aradhya >> >> Change Log: >> V4 -> V5: >> - Cosmetic changes as suggested by Jayesh. >> - Fixed the mis-represented DSS VP1 clock, and added a >> fixed-factor-clock. >> >> V3 -> V4: >> - Added "Fixes" tag for patch 1/6. >> - Rebased to linux-next. >> - Enabled display at board level and disabled at SoC level. >> - Dropped OLDI pinmux configuration as OLDI output comes directly from >> the SoC and muxing is not required. >> - Squashed DSS pinmux patches into their platform specific HDMI >> support patches, because it did not make sense to have only one set >> of pinmux config separated in a patch. >> >> V2 -> V3: >> - Updated the compatible from "ti,am65x-dss" to "ti,am625-dss". >> - Peripheral nodes like HDMI TX, HDMI connector are now added to >> k3-am62x-sk-common.dtsi instead of k3-am625-sk.dts, in order to >> support AM62-LP SK-EVM as well. >> - Dropped the HDMI master clock node as it is not connected on the >> EVM, and should not have been added in the first place. >> - Re-worded and Re-ordered commits. >> - Dropped Rahul Ravikumar's R-bs because of the changes. >> - Added AM625 based Beagle-Play for HDMI support. >> - Added HDMI audio support as well. >> >> V1 -> V2: >> - Removed repetitive data in dss_ports >> >> V4: https://lore.kernel.org/all/20230807153307.22174-1-a-bhatia1@ti.com/ >> V3: https://lore.kernel.org/all/20230728173438.12995-1-a-bhatia1@ti.com/ >> V2: https://lore.kernel.org/all/20220505134303.23208-1-a-bhatia1@ti.com/ >> V1: https://lore.kernel.org/all/20220427090850.32280-1-a-bhatia1@ti.com/ >> >> [0]: https://lore.kernel.org/all/20230616150900.6617-1-a-bhatia1@ti.com/ >> [1]: https://lore.kernel.org/all/20230619131620.3286650-1-nm@ti.com/ >> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/commit/?id=0bec3d7ecc7493b0e530f6f34539841ef6779006 >> [3]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?h=ti-linux-6.1.y-cicd >> >> >> Aradhya Bhatia (4): >> arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency >> arm64: dts: ti: k3-am62-main: Add node for DSS >> arm64: dts: ti: k3-am62x-sk-common: Add HDMI support >> arm64: defconfig: Enable ITE_IT66121 HDMI transmitter >> >> Jai Luthra (1): >> arm64: dts: ti: am62x-sk: Add overlay for HDMI audio >> >> Nishanth Menon (1): >> arm64: dts: ti: k3-am625-beagleplay: Add HDMI support >> >> arch/arm64/boot/dts/ti/Makefile | 3 + >> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 25 +++ >> arch/arm64/boot/dts/ti/k3-am62.dtsi | 8 + >> .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 150 ++++++++++++++++++ >> .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 93 ++++++++++- >> .../boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso | 40 +++++ >> arch/arm64/configs/defconfig | 1 + >> 7 files changed, 319 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso >> >> >> base-commit: 71cd4fc492ec41e4acd85e98bbf7a13753fc1e03 >> -- >> 2.40.1 >> > > Can you help cleanup the following before we start introducing new oldi > and dss support? I am not sure if these were introduced due to yaml > updates or something pre-existing. This is a pre-existing issue. Lets not fault Aradhya nor hold back this series for an issue we caused way back when initially adding AM65 support. Just to help this along, I've gone and added the fix for these warnings here[0][1]. Andrew [0] https://lkml.org/lkml/2023/8/9/889 [1] https://lkml.org/lkml/2023/8/9/888 > > linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: > linux/build/arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: > linux/build/arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: > linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: > linux/build/arch/arm64/boot/dts/ti/k3-am654-base-board.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: > linux/build/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb: dss-oldi-io-ctrl@41e0: compatible: 'anyOf' conditional failed, one must be fixed: >
On 12:01-20230809, Andrew Davis wrote: [...] > > Can you help cleanup the following before we start introducing new oldi > > and dss support? I am not sure if these were introduced due to yaml > > updates or something pre-existing. > > This is a pre-existing issue. Lets not fault Aradhya nor hold back this > series for an issue we caused way back when initially adding AM65 support. > > Just to help this along, I've gone and added the fix for these warnings > here[0][1]. > > Andrew > > [0] https://lkml.org/lkml/2023/8/9/889 > [1] https://lkml.org/lkml/2023/8/9/888 > I am tempted to plagiarize Lt. Aldo Raine "I want my fixes", but quips aside, exactly why not picking up patches without fixes is the last knob I have to force long standing issue resolution :). unfortunate to need to use it, happy to see it still work. That said, the patches will have to wait a cycle anyways (cant take checkpatch warnings with rc1) for the binding to hit 6.6-rc1. In the meanwhile lets see about getting that fix series merged..
Hi Aradhya Bhatia, On Wed, 09 Aug 2023 14:15:53 +0530, Aradhya Bhatia wrote: > The patch series adds DT nodes for Display SubSystem (DSS) and other > peripherals required to enable the HDMI audio and video on the AM625 SK, > AM62-LP SK, as well as the AM625 based Beagle-Play platforms. An HDMI > monitor can be connected to the boards for the audio/video outputs. > > The series adding the compatible and basic driver support[0] is in the > drm-misc-next and linux-next queues and is expected to be in the > mainline by v6.6-rc1. Patch 5/6 also requires Nishanth Menon's patch[1] > that introduces debounce select mux macros. This patch too is not in > v6.5-rc1 but has been picked up in ti-next[2] and hence, is present in > linux-next. > > [...] NOTE: This series creates checkpatch warnings against v6.5-rc1 and complains that it cannot find ti,am625-dss which has been merged in drm tree for next. This is clean in linux-next for a few weeks now. Given the number of people who would really like to see it in v6.6-rc1 to keep the display support working in the tree without carried patches and work on next set of features on display and graphics, and given the real low risk of this NOT making to linus-master, we are making an specific exception here for this time around. So, please keep a watch on drm-next and if for any reason the support is dropped going to linus's tre in the merge window or before, let this chain know with appropriate maintainers so that we can take corrective actions. PS: Thanks Arnd for taking time to give me some private guidance. Fingers crossed that this will go through smooth. Thank you! I have applied the following to branch ti-k3-dts-next on [1]: [1/6] arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency commit: 73387da70f9c26b6fba4f62371d013cce14663d9 [2/6] arm64: dts: ti: k3-am62-main: Add node for DSS commit: 8ccc1073c7bb2ae9654529a75f85ef23b7215c9b [3/6] arm64: dts: ti: k3-am62x-sk-common: Add HDMI support commit: db6e8237cf5435e972ea47632e5d8ac3e356f210 [4/6] arm64: dts: ti: am62x-sk: Add overlay for HDMI audio commit: b50ccab9e07ca19d49a0d629dfbe184e6975be22 [5/6] arm64: dts: ti: k3-am625-beagleplay: Add HDMI support commit: 1f7226a5e52cb8b90771cefc29077f9ce13a3c90 I have applied the following to branch ti-k3-config-next on [1]: [6/6] arm64: defconfig: Enable ITE_IT66121 HDMI transmitter commit: d5c988b43746de250bed33c17116e879f032ff12 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
On 12-Aug-23 04:02, Nishanth Menon wrote: > Hi Aradhya Bhatia, > > On Wed, 09 Aug 2023 14:15:53 +0530, Aradhya Bhatia wrote: >> The patch series adds DT nodes for Display SubSystem (DSS) and other >> peripherals required to enable the HDMI audio and video on the AM625 SK, >> AM62-LP SK, as well as the AM625 based Beagle-Play platforms. An HDMI >> monitor can be connected to the boards for the audio/video outputs. >> >> The series adding the compatible and basic driver support[0] is in the >> drm-misc-next and linux-next queues and is expected to be in the >> mainline by v6.6-rc1. Patch 5/6 also requires Nishanth Menon's patch[1] >> that introduces debounce select mux macros. This patch too is not in >> v6.5-rc1 but has been picked up in ti-next[2] and hence, is present in >> linux-next. >> >> [...] > > NOTE: This series creates checkpatch warnings against v6.5-rc1 and > complains that it cannot find ti,am625-dss which has been merged in > drm tree for next. This is clean in linux-next for a few weeks now. > Given the number of people who would really like to see it in v6.6-rc1 > to keep the display support working in the tree without carried > patches and work on next set of features on display and graphics, and > given the real low risk of this NOT making to linus-master, we are > making an specific exception here for this time around. So, please > keep a watch on drm-next and if for any reason the support is dropped > going to linus's tre in the merge window or before, let this chain > know with appropriate maintainers so that we can take corrective > actions. PS: Thanks Arnd for taking time to give me some private > guidance. Fingers crossed that this will go through smooth. Nishanth, Vignesh, Arnd, Thank you for making an exception here, and allowing these patches in! =) I will keep an eye on drm-next and will make sure to let you all know if the AM62 base DSS support patches get dropped for any reason. Regards Aradhya > > Thank you! > > I have applied the following to branch ti-k3-dts-next on [1]: > > [1/6] arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency > commit: 73387da70f9c26b6fba4f62371d013cce14663d9 > [2/6] arm64: dts: ti: k3-am62-main: Add node for DSS > commit: 8ccc1073c7bb2ae9654529a75f85ef23b7215c9b > [3/6] arm64: dts: ti: k3-am62x-sk-common: Add HDMI support > commit: db6e8237cf5435e972ea47632e5d8ac3e356f210 > [4/6] arm64: dts: ti: am62x-sk: Add overlay for HDMI audio > commit: b50ccab9e07ca19d49a0d629dfbe184e6975be22 > [5/6] arm64: dts: ti: k3-am625-beagleplay: Add HDMI support > commit: 1f7226a5e52cb8b90771cefc29077f9ce13a3c90 > > I have applied the following to branch ti-k3-config-next on [1]: > > [6/6] arm64: defconfig: Enable ITE_IT66121 HDMI transmitter > commit: d5c988b43746de250bed33c17116e879f032ff12 > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent up the chain during > the next merge window (or sooner if it is a relevant bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Hi all, The patch series adds DT nodes for Display SubSystem (DSS) and other peripherals required to enable the HDMI audio and video on the AM625 SK, AM62-LP SK, as well as the AM625 based Beagle-Play platforms. An HDMI monitor can be connected to the boards for the audio/video outputs. The series adding the compatible and basic driver support[0] is in the drm-misc-next and linux-next queues and is expected to be in the mainline by v6.6-rc1. Patch 5/6 also requires Nishanth Menon's patch[1] that introduces debounce select mux macros. This patch too is not in v6.5-rc1 but has been picked up in ti-next[2] and hence, is present in linux-next. Patches 4 and 5 have been picked up from TI's vendor tree[3] based off linux-kernel v6.1. Regards Aradhya Change Log: V4 -> V5: - Cosmetic changes as suggested by Jayesh. - Fixed the mis-represented DSS VP1 clock, and added a fixed-factor-clock. V3 -> V4: - Added "Fixes" tag for patch 1/6. - Rebased to linux-next. - Enabled display at board level and disabled at SoC level. - Dropped OLDI pinmux configuration as OLDI output comes directly from the SoC and muxing is not required. - Squashed DSS pinmux patches into their platform specific HDMI support patches, because it did not make sense to have only one set of pinmux config separated in a patch. V2 -> V3: - Updated the compatible from "ti,am65x-dss" to "ti,am625-dss". - Peripheral nodes like HDMI TX, HDMI connector are now added to k3-am62x-sk-common.dtsi instead of k3-am625-sk.dts, in order to support AM62-LP SK-EVM as well. - Dropped the HDMI master clock node as it is not connected on the EVM, and should not have been added in the first place. - Re-worded and Re-ordered commits. - Dropped Rahul Ravikumar's R-bs because of the changes. - Added AM625 based Beagle-Play for HDMI support. - Added HDMI audio support as well. V1 -> V2: - Removed repetitive data in dss_ports V4: https://lore.kernel.org/all/20230807153307.22174-1-a-bhatia1@ti.com/ V3: https://lore.kernel.org/all/20230728173438.12995-1-a-bhatia1@ti.com/ V2: https://lore.kernel.org/all/20220505134303.23208-1-a-bhatia1@ti.com/ V1: https://lore.kernel.org/all/20220427090850.32280-1-a-bhatia1@ti.com/ [0]: https://lore.kernel.org/all/20230616150900.6617-1-a-bhatia1@ti.com/ [1]: https://lore.kernel.org/all/20230619131620.3286650-1-nm@ti.com/ [2]: https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git/commit/?id=0bec3d7ecc7493b0e530f6f34539841ef6779006 [3]: https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/log/?h=ti-linux-6.1.y-cicd Aradhya Bhatia (4): arm64: dts: ti: k3-am62x-sk-common: Update main-i2c1 frequency arm64: dts: ti: k3-am62-main: Add node for DSS arm64: dts: ti: k3-am62x-sk-common: Add HDMI support arm64: defconfig: Enable ITE_IT66121 HDMI transmitter Jai Luthra (1): arm64: dts: ti: am62x-sk: Add overlay for HDMI audio Nishanth Menon (1): arm64: dts: ti: k3-am625-beagleplay: Add HDMI support arch/arm64/boot/dts/ti/Makefile | 3 + arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 25 +++ arch/arm64/boot/dts/ti/k3-am62.dtsi | 8 + .../arm64/boot/dts/ti/k3-am625-beagleplay.dts | 150 ++++++++++++++++++ .../arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 93 ++++++++++- .../boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso | 40 +++++ arch/arm64/configs/defconfig | 1 + 7 files changed, 319 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/ti/k3-am62x-sk-hdmi-audio.dtso base-commit: 71cd4fc492ec41e4acd85e98bbf7a13753fc1e03