| Message ID | 20230803211331.140553-2-ilkka@os.amperecomputing.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf vendor events arm64: AmpereOne: Core PMU event update and metrics | expand |
On 03/08/2023 22:13, Ilkka Koskinen wrote: > amperene/cache.json file tried to include L1D_CACHE_LMISS while it > doesn't exist in common-and-microarch.json. While this bug doesn't seem to > cause issue in newer kernels with jevents.py script, it prevents building > older perf tools with the backported patch. jevents.py needs to be improved so it errors on these events which cannot be fixed up, like it used to. I'll look to do that when I get a chance. > > Fixes: a9650b7f6fc0 ("perf vendor events arm64: Add AmpereOne core PMU events") > Reported-by: Dave Kleikamp <dave.kleikamp@oracle.com> > Closes: https://urldefense.com/v3/__https://lore.kernel.org/all/76bb2e47-ce44-76ae-838e-53279047084d@oracle.com/__;!!ACWV5N9M2RV99hQ!IlO3yUW8jhm6wp8BJalODmD7WjzJleyREtTWS2pdn90Af5BD3P7g0fTGldbw15pSn49ycWiKpWDysjXw_ECS4XbbJQ$ > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> Reviewed-by: John Garry <john.g.garry@oracle.com> > --- > tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > index fc0633054211..7a2b7b200f14 100644 > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > @@ -92,9 +92,6 @@ > { > "ArchStdEvent": "L1D_CACHE_LMISS_RD" > }, > - { > - "ArchStdEvent": "L1D_CACHE_LMISS" > - }, > { > "ArchStdEvent": "L1I_CACHE_LMISS" > },
On Fri, Aug 4, 2023 at 4:02 AM John Garry <john.g.garry@oracle.com> wrote: > > On 03/08/2023 22:13, Ilkka Koskinen wrote: > > amperene/cache.json file tried to include L1D_CACHE_LMISS while it > > doesn't exist in common-and-microarch.json. While this bug doesn't seem to > > cause issue in newer kernels with jevents.py script, it prevents building > > older perf tools with the backported patch. Fwiw, newer perf tool on old kernel should always be fine. But I understand that if you are trying to build a tree with backports in it... > > jevents.py needs to be improved so it errors on these events which > cannot be fixed up, like it used to. I'll look to do that when I get a > chance. > > > > > Fixes: a9650b7f6fc0 ("perf vendor events arm64: Add AmpereOne core PMU events") > > Reported-by: Dave Kleikamp <dave.kleikamp@oracle.com> > > Closes: https://urldefense.com/v3/__https://lore.kernel.org/all/76bb2e47-ce44-76ae-838e-53279047084d@oracle.com/__;!!ACWV5N9M2RV99hQ!IlO3yUW8jhm6wp8BJalODmD7WjzJleyREtTWS2pdn90Af5BD3P7g0fTGldbw15pSn49ycWiKpWDysjXw_ECS4XbbJQ$ > > Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> > > Reviewed-by: John Garry <john.g.garry@oracle.com> Reviewed-by: Ian Rogers <irogers@google.com> Thanks, Ian > > --- > > tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > > index fc0633054211..7a2b7b200f14 100644 > > --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > > +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json > > @@ -92,9 +92,6 @@ > > { > > "ArchStdEvent": "L1D_CACHE_LMISS_RD" > > }, > > - { > > - "ArchStdEvent": "L1D_CACHE_LMISS" > > - }, > > { > > "ArchStdEvent": "L1I_CACHE_LMISS" > > }, >
diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json index fc0633054211..7a2b7b200f14 100644 --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json @@ -92,9 +92,6 @@ { "ArchStdEvent": "L1D_CACHE_LMISS_RD" }, - { - "ArchStdEvent": "L1D_CACHE_LMISS" - }, { "ArchStdEvent": "L1I_CACHE_LMISS" },
amperene/cache.json file tried to include L1D_CACHE_LMISS while it doesn't exist in common-and-microarch.json. While this bug doesn't seem to cause issue in newer kernels with jevents.py script, it prevents building older perf tools with the backported patch. Fixes: a9650b7f6fc0 ("perf vendor events arm64: Add AmpereOne core PMU events") Reported-by: Dave Kleikamp <dave.kleikamp@oracle.com> Closes: https://lore.kernel.org/all/76bb2e47-ce44-76ae-838e-53279047084d@oracle.com/ Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com> --- tools/perf/pmu-events/arch/arm64/ampere/ampereone/cache.json | 3 --- 1 file changed, 3 deletions(-)