| Message ID | 20230814203406.12399-1-vadimp@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add new features and amendments for Nvidia systems | expand |
Hi, It would be nice if there was a changelog somewhere in this cover letter explaining what has changed in v2 ? Regards, Hans On 8/14/23 22:33, Vadim Pasternak wrote: > The patch set: > - Provides New system attributes for monitoring. > - Adds system reboot callback to perform system specific operations. > - Adds support for ACPI based initialization flow. > - Adds support for FPGA device connected through PCIe bus. > - Adds additional logic for hotplug events handling. > - Contains some amendments and cosmetic changes. > > The patch set includes: > Patches #1 - #3, #5: add new attributes for monitoring. > Patch #4: sets hotplug event action for health and power signals. > Patch #6: adds CPLD versioning registers for systems equipped with five > CPLD devices. > Patch #7: modifies power off callback. > Patch #8: cosmetic changes - fixes misspelling. > Patch #9: provides system reboot callback through system reboot > notifier. > Patch #10: prepares driver to allow probing through ACPI hooks along > with probing through DMI hooks. > Patch #11: adds ACPI match hook for initialization flow. > Patch #12: adds support for getting system interrupt line from ACPI > table. > Patch #13: adds initial support for programming logic device connected > through PCIe. > Patch #14: Extends condition for notification callback processing. > Patch #15: defines the exact i2c bus of fans on the SN2201 system. > Patch #16: Documents new attributes. > > Michael Shych (1): > platform: mellanox: nvsw-sn2201: change fans i2c busses. > > Vadim Pasternak (15): > platform: mellanox: Add new attributes > platform: mellanox: Add field upgrade capability register > platform: mellanox: Modify reset causes description > platform: mellanox: mlx-platform: Modify health and power hotplug > action > platform: mellanox: mlx-platform: Add reset cause attribute > platform: mellanox: mlx-platform: add support for additional CPLD > platform: mellanox: mlx-platform: Modify power off callback > platform: mellanox: Cosmetic changes > platform: mellanox: mlx-platform: Add reset callback > platform: mellanox: mlx-platform: Prepare driver to allow probing > through ACPI infrastructure > platform: mellanox: mlx-platform: Introduce ACPI init flow > platform: mellanox: mlx-platform: Get interrupt line through ACPI > platform: mellanox: Add initial support for PCIe based programming > logic device > platform/mellanox: mlxreg-hotplug: Extend condition for notification > callback processing > Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces > > .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ > drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- > drivers/platform/mellanox/nvsw-sn2201.c | 12 +- > drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- > 4 files changed, 383 insertions(+), 49 deletions(-) >
Hi Hans, I put changelogs inside each patch, which was commented (v0 -> v2). Would you like me to put it in cover? Thanks, Vadim. > -----Original Message----- > From: Hans de Goede <hdegoede@redhat.com> > Sent: Tuesday, 15 August 2023 11:06 > To: Vadim Pasternak <vadimp@nvidia.com> > Cc: ilpo.jarvinen@linux.intel.com; platform-driver-x86@vger.kernel.org > Subject: Re: [PATCH platform-next v2 00/16] Add new features and > amendments for Nvidia systems > > Hi, > > It would be nice if there was a changelog somewhere in this cover letter > explaining what has changed in v2 ? > > Regards, > > Hans > > On 8/14/23 22:33, Vadim Pasternak wrote: > > The patch set: > > - Provides New system attributes for monitoring. > > - Adds system reboot callback to perform system specific operations. > > - Adds support for ACPI based initialization flow. > > - Adds support for FPGA device connected through PCIe bus. > > - Adds additional logic for hotplug events handling. > > - Contains some amendments and cosmetic changes. > > > > The patch set includes: > > Patches #1 - #3, #5: add new attributes for monitoring. > > Patch #4: sets hotplug event action for health and power signals. > > Patch #6: adds CPLD versioning registers for systems equipped with five > > CPLD devices. > > Patch #7: modifies power off callback. > > Patch #8: cosmetic changes - fixes misspelling. > > Patch #9: provides system reboot callback through system reboot > > notifier. > > Patch #10: prepares driver to allow probing through ACPI hooks along > > with probing through DMI hooks. > > Patch #11: adds ACPI match hook for initialization flow. > > Patch #12: adds support for getting system interrupt line from ACPI > > table. > > Patch #13: adds initial support for programming logic device connected > > through PCIe. > > Patch #14: Extends condition for notification callback processing. > > Patch #15: defines the exact i2c bus of fans on the SN2201 system. > > Patch #16: Documents new attributes. > > > > Michael Shych (1): > > platform: mellanox: nvsw-sn2201: change fans i2c busses. > > > > Vadim Pasternak (15): > > platform: mellanox: Add new attributes > > platform: mellanox: Add field upgrade capability register > > platform: mellanox: Modify reset causes description > > platform: mellanox: mlx-platform: Modify health and power hotplug > > action > > platform: mellanox: mlx-platform: Add reset cause attribute > > platform: mellanox: mlx-platform: add support for additional CPLD > > platform: mellanox: mlx-platform: Modify power off callback > > platform: mellanox: Cosmetic changes > > platform: mellanox: mlx-platform: Add reset callback > > platform: mellanox: mlx-platform: Prepare driver to allow probing > > through ACPI infrastructure > > platform: mellanox: mlx-platform: Introduce ACPI init flow > > platform: mellanox: mlx-platform: Get interrupt line through ACPI > > platform: mellanox: Add initial support for PCIe based programming > > logic device > > platform/mellanox: mlxreg-hotplug: Extend condition for notification > > callback processing > > Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces > > > > .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ > > drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- > > drivers/platform/mellanox/nvsw-sn2201.c | 12 +- > > drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- > > 4 files changed, 383 insertions(+), 49 deletions(-) > >
Hi, On 8/15/23 10:09, Vadim Pasternak wrote: > Hi Hans, > > I put changelogs inside each patch, which was commented (v0 -> v2). > Would you like me to put it in cover? Ah I see them now, I randomly checked 3 patches for that and got unlucky. Next time please put at least a summary of the Changes in the cover, e.g. for this v2: Changes in v2: - Address review comments from Ilpo, see individual patches for details. Regards, Hans - > > Thanks, > Vadim. > >> -----Original Message----- >> From: Hans de Goede <hdegoede@redhat.com> >> Sent: Tuesday, 15 August 2023 11:06 >> To: Vadim Pasternak <vadimp@nvidia.com> >> Cc: ilpo.jarvinen@linux.intel.com; platform-driver-x86@vger.kernel.org >> Subject: Re: [PATCH platform-next v2 00/16] Add new features and >> amendments for Nvidia systems >> >> Hi, >> >> It would be nice if there was a changelog somewhere in this cover letter >> explaining what has changed in v2 ? >> >> Regards, >> >> Hans >> >> On 8/14/23 22:33, Vadim Pasternak wrote: >>> The patch set: >>> - Provides New system attributes for monitoring. >>> - Adds system reboot callback to perform system specific operations. >>> - Adds support for ACPI based initialization flow. >>> - Adds support for FPGA device connected through PCIe bus. >>> - Adds additional logic for hotplug events handling. >>> - Contains some amendments and cosmetic changes. >>> >>> The patch set includes: >>> Patches #1 - #3, #5: add new attributes for monitoring. >>> Patch #4: sets hotplug event action for health and power signals. >>> Patch #6: adds CPLD versioning registers for systems equipped with five >>> CPLD devices. >>> Patch #7: modifies power off callback. >>> Patch #8: cosmetic changes - fixes misspelling. >>> Patch #9: provides system reboot callback through system reboot >>> notifier. >>> Patch #10: prepares driver to allow probing through ACPI hooks along >>> with probing through DMI hooks. >>> Patch #11: adds ACPI match hook for initialization flow. >>> Patch #12: adds support for getting system interrupt line from ACPI >>> table. >>> Patch #13: adds initial support for programming logic device connected >>> through PCIe. >>> Patch #14: Extends condition for notification callback processing. >>> Patch #15: defines the exact i2c bus of fans on the SN2201 system. >>> Patch #16: Documents new attributes. >>> >>> Michael Shych (1): >>> platform: mellanox: nvsw-sn2201: change fans i2c busses. >>> >>> Vadim Pasternak (15): >>> platform: mellanox: Add new attributes >>> platform: mellanox: Add field upgrade capability register >>> platform: mellanox: Modify reset causes description >>> platform: mellanox: mlx-platform: Modify health and power hotplug >>> action >>> platform: mellanox: mlx-platform: Add reset cause attribute >>> platform: mellanox: mlx-platform: add support for additional CPLD >>> platform: mellanox: mlx-platform: Modify power off callback >>> platform: mellanox: Cosmetic changes >>> platform: mellanox: mlx-platform: Add reset callback >>> platform: mellanox: mlx-platform: Prepare driver to allow probing >>> through ACPI infrastructure >>> platform: mellanox: mlx-platform: Introduce ACPI init flow >>> platform: mellanox: mlx-platform: Get interrupt line through ACPI >>> platform: mellanox: Add initial support for PCIe based programming >>> logic device >>> platform/mellanox: mlxreg-hotplug: Extend condition for notification >>> callback processing >>> Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces >>> >>> .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ >>> drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- >>> drivers/platform/mellanox/nvsw-sn2201.c | 12 +- >>> drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- >>> 4 files changed, 383 insertions(+), 49 deletions(-) >>> >
Hi, On 8/15/23 10:09, Vadim Pasternak wrote: > Hi Hans, > > I put changelogs inside each patch, which was commented (v0 -> v2). > Would you like me to put it in cover? Ah I see them now, I randomly checked 3 patches for that and got unlucky. Next time please put at least a summary of the Changes in the cover, e.g. for this v2: Changes in v2: - Address review comments from Ilpo, see individual patches for details. Regards, Hans - > > Thanks, > Vadim. > >> -----Original Message----- >> From: Hans de Goede <hdegoede@redhat.com> >> Sent: Tuesday, 15 August 2023 11:06 >> To: Vadim Pasternak <vadimp@nvidia.com> >> Cc: ilpo.jarvinen@linux.intel.com; platform-driver-x86@vger.kernel.org >> Subject: Re: [PATCH platform-next v2 00/16] Add new features and >> amendments for Nvidia systems >> >> Hi, >> >> It would be nice if there was a changelog somewhere in this cover letter >> explaining what has changed in v2 ? >> >> Regards, >> >> Hans >> >> On 8/14/23 22:33, Vadim Pasternak wrote: >>> The patch set: >>> - Provides New system attributes for monitoring. >>> - Adds system reboot callback to perform system specific operations. >>> - Adds support for ACPI based initialization flow. >>> - Adds support for FPGA device connected through PCIe bus. >>> - Adds additional logic for hotplug events handling. >>> - Contains some amendments and cosmetic changes. >>> >>> The patch set includes: >>> Patches #1 - #3, #5: add new attributes for monitoring. >>> Patch #4: sets hotplug event action for health and power signals. >>> Patch #6: adds CPLD versioning registers for systems equipped with five >>> CPLD devices. >>> Patch #7: modifies power off callback. >>> Patch #8: cosmetic changes - fixes misspelling. >>> Patch #9: provides system reboot callback through system reboot >>> notifier. >>> Patch #10: prepares driver to allow probing through ACPI hooks along >>> with probing through DMI hooks. >>> Patch #11: adds ACPI match hook for initialization flow. >>> Patch #12: adds support for getting system interrupt line from ACPI >>> table. >>> Patch #13: adds initial support for programming logic device connected >>> through PCIe. >>> Patch #14: Extends condition for notification callback processing. >>> Patch #15: defines the exact i2c bus of fans on the SN2201 system. >>> Patch #16: Documents new attributes. >>> >>> Michael Shych (1): >>> platform: mellanox: nvsw-sn2201: change fans i2c busses. >>> >>> Vadim Pasternak (15): >>> platform: mellanox: Add new attributes >>> platform: mellanox: Add field upgrade capability register >>> platform: mellanox: Modify reset causes description >>> platform: mellanox: mlx-platform: Modify health and power hotplug >>> action >>> platform: mellanox: mlx-platform: Add reset cause attribute >>> platform: mellanox: mlx-platform: add support for additional CPLD >>> platform: mellanox: mlx-platform: Modify power off callback >>> platform: mellanox: Cosmetic changes >>> platform: mellanox: mlx-platform: Add reset callback >>> platform: mellanox: mlx-platform: Prepare driver to allow probing >>> through ACPI infrastructure >>> platform: mellanox: mlx-platform: Introduce ACPI init flow >>> platform: mellanox: mlx-platform: Get interrupt line through ACPI >>> platform: mellanox: Add initial support for PCIe based programming >>> logic device >>> platform/mellanox: mlxreg-hotplug: Extend condition for notification >>> callback processing >>> Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces >>> >>> .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ >>> drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- >>> drivers/platform/mellanox/nvsw-sn2201.c | 12 +- >>> drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- >>> 4 files changed, 383 insertions(+), 49 deletions(-) >>> >
> -----Original Message----- > From: Hans de Goede <hdegoede@redhat.com> > Sent: Tuesday, 15 August 2023 11:16 > To: Vadim Pasternak <vadimp@nvidia.com> > Cc: ilpo.jarvinen@linux.intel.com; platform-driver-x86@vger.kernel.org > Subject: Re: [PATCH platform-next v2 00/16] Add new features and > amendments for Nvidia systems > > Hi, > > On 8/15/23 10:09, Vadim Pasternak wrote: > > Hi Hans, > > > > I put changelogs inside each patch, which was commented (v0 -> v2). > > Would you like me to put it in cover? > > Ah I see them now, I randomly checked 3 patches for that and got unlucky. > > Next time please put at least a summary of the Changes in the cover, e.g. for > this v2: > > Changes in v2: > - Address review comments from Ilpo, see individual patches > for details. Sure. > > Regards, > > Hans > > > > > > > - > > > > Thanks, > > Vadim. > > > >> -----Original Message----- > >> From: Hans de Goede <hdegoede@redhat.com> > >> Sent: Tuesday, 15 August 2023 11:06 > >> To: Vadim Pasternak <vadimp@nvidia.com> > >> Cc: ilpo.jarvinen@linux.intel.com; > >> platform-driver-x86@vger.kernel.org > >> Subject: Re: [PATCH platform-next v2 00/16] Add new features and > >> amendments for Nvidia systems > >> > >> Hi, > >> > >> It would be nice if there was a changelog somewhere in this cover > >> letter explaining what has changed in v2 ? > >> > >> Regards, > >> > >> Hans > >> > >> On 8/14/23 22:33, Vadim Pasternak wrote: > >>> The patch set: > >>> - Provides New system attributes for monitoring. > >>> - Adds system reboot callback to perform system specific operations. > >>> - Adds support for ACPI based initialization flow. > >>> - Adds support for FPGA device connected through PCIe bus. > >>> - Adds additional logic for hotplug events handling. > >>> - Contains some amendments and cosmetic changes. > >>> > >>> The patch set includes: > >>> Patches #1 - #3, #5: add new attributes for monitoring. > >>> Patch #4: sets hotplug event action for health and power signals. > >>> Patch #6: adds CPLD versioning registers for systems equipped with five > >>> CPLD devices. > >>> Patch #7: modifies power off callback. > >>> Patch #8: cosmetic changes - fixes misspelling. > >>> Patch #9: provides system reboot callback through system reboot > >>> notifier. > >>> Patch #10: prepares driver to allow probing through ACPI hooks along > >>> with probing through DMI hooks. > >>> Patch #11: adds ACPI match hook for initialization flow. > >>> Patch #12: adds support for getting system interrupt line from ACPI > >>> table. > >>> Patch #13: adds initial support for programming logic device connected > >>> through PCIe. > >>> Patch #14: Extends condition for notification callback processing. > >>> Patch #15: defines the exact i2c bus of fans on the SN2201 system. > >>> Patch #16: Documents new attributes. > >>> > >>> Michael Shych (1): > >>> platform: mellanox: nvsw-sn2201: change fans i2c busses. > >>> > >>> Vadim Pasternak (15): > >>> platform: mellanox: Add new attributes > >>> platform: mellanox: Add field upgrade capability register > >>> platform: mellanox: Modify reset causes description > >>> platform: mellanox: mlx-platform: Modify health and power hotplug > >>> action > >>> platform: mellanox: mlx-platform: Add reset cause attribute > >>> platform: mellanox: mlx-platform: add support for additional CPLD > >>> platform: mellanox: mlx-platform: Modify power off callback > >>> platform: mellanox: Cosmetic changes > >>> platform: mellanox: mlx-platform: Add reset callback > >>> platform: mellanox: mlx-platform: Prepare driver to allow probing > >>> through ACPI infrastructure > >>> platform: mellanox: mlx-platform: Introduce ACPI init flow > >>> platform: mellanox: mlx-platform: Get interrupt line through ACPI > >>> platform: mellanox: Add initial support for PCIe based programming > >>> logic device > >>> platform/mellanox: mlxreg-hotplug: Extend condition for notification > >>> callback processing > >>> Documentation/ABI: Add new attribute for mlxreg-io sysfs > >>> interfaces > >>> > >>> .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ > >>> drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- > >>> drivers/platform/mellanox/nvsw-sn2201.c | 12 +- > >>> drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- > >>> 4 files changed, 383 insertions(+), 49 deletions(-) > >>> > >
Hi, On 8/14/23 22:33, Vadim Pasternak wrote: > The patch set: > - Provides New system attributes for monitoring. > - Adds system reboot callback to perform system specific operations. > - Adds support for ACPI based initialization flow. > - Adds support for FPGA device connected through PCIe bus. > - Adds additional logic for hotplug events handling. > - Contains some amendments and cosmetic changes. > > The patch set includes: > Patches #1 - #3, #5: add new attributes for monitoring. > Patch #4: sets hotplug event action for health and power signals. > Patch #6: adds CPLD versioning registers for systems equipped with five > CPLD devices. > Patch #7: modifies power off callback. > Patch #8: cosmetic changes - fixes misspelling. > Patch #9: provides system reboot callback through system reboot > notifier. > Patch #10: prepares driver to allow probing through ACPI hooks along > with probing through DMI hooks. > Patch #11: adds ACPI match hook for initialization flow. > Patch #12: adds support for getting system interrupt line from ACPI > table. > Patch #13: adds initial support for programming logic device connected > through PCIe. > Patch #14: Extends condition for notification callback processing. > Patch #15: defines the exact i2c bus of fans on the SN2201 system. > Patch #16: Documents new attributes. Thanks. 1 remark about Patch #16: Documents new attributes, this does not document the new reset_swb_dc_dc_pwr_fail attribute, please add this. With that fixed the entire looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. I tried applying this, but it is based on a tree which does not have the recent: dd635e33b5c9a ("platform: mellanox: Introduce support ofnew Nvidia L1 switch") commit causing patch 2/16 to not apply. Please rebase on top of the latest pdx86/for-next: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next and submit a version 3. Regards, Hans > > Michael Shych (1): > platform: mellanox: nvsw-sn2201: change fans i2c busses. > > Vadim Pasternak (15): > platform: mellanox: Add new attributes > platform: mellanox: Add field upgrade capability register > platform: mellanox: Modify reset causes description > platform: mellanox: mlx-platform: Modify health and power hotplug > action > platform: mellanox: mlx-platform: Add reset cause attribute > platform: mellanox: mlx-platform: add support for additional CPLD > platform: mellanox: mlx-platform: Modify power off callback > platform: mellanox: Cosmetic changes > platform: mellanox: mlx-platform: Add reset callback > platform: mellanox: mlx-platform: Prepare driver to allow probing > through ACPI infrastructure > platform: mellanox: mlx-platform: Introduce ACPI init flow > platform: mellanox: mlx-platform: Get interrupt line through ACPI > platform: mellanox: Add initial support for PCIe based programming > logic device > platform/mellanox: mlxreg-hotplug: Extend condition for notification > callback processing > Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces > > .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ > drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- > drivers/platform/mellanox/nvsw-sn2201.c | 12 +- > drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- > 4 files changed, 383 insertions(+), 49 deletions(-) >
Hi Hans, Thank you very much for review. > -----Original Message----- > From: Hans de Goede <hdegoede@redhat.com> > Sent: Monday, 21 August 2023 16:20 > To: Vadim Pasternak <vadimp@nvidia.com> > Cc: ilpo.jarvinen@linux.intel.com; platform-driver-x86@vger.kernel.org > Subject: Re: [PATCH platform-next v2 00/16] Add new features and > amendments for Nvidia systems > > Hi, > > On 8/14/23 22:33, Vadim Pasternak wrote: > > The patch set: > > - Provides New system attributes for monitoring. > > - Adds system reboot callback to perform system specific operations. > > - Adds support for ACPI based initialization flow. > > - Adds support for FPGA device connected through PCIe bus. > > - Adds additional logic for hotplug events handling. > > - Contains some amendments and cosmetic changes. > > > > The patch set includes: > > Patches #1 - #3, #5: add new attributes for monitoring. > > Patch #4: sets hotplug event action for health and power signals. > > Patch #6: adds CPLD versioning registers for systems equipped with five > > CPLD devices. > > Patch #7: modifies power off callback. > > Patch #8: cosmetic changes - fixes misspelling. > > Patch #9: provides system reboot callback through system reboot > > notifier. > > Patch #10: prepares driver to allow probing through ACPI hooks along > > with probing through DMI hooks. > > Patch #11: adds ACPI match hook for initialization flow. > > Patch #12: adds support for getting system interrupt line from ACPI > > table. > > Patch #13: adds initial support for programming logic device connected > > through PCIe. > > Patch #14: Extends condition for notification callback processing. > > Patch #15: defines the exact i2c bus of fans on the SN2201 system. > > Patch #16: Documents new attributes. > > Thanks. > > 1 remark about Patch #16: Documents new attributes, this does not document > the new reset_swb_dc_dc_pwr_fail attribute, please add this. > > With that fixed the entire looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > for the series. > > I tried applying this, but it is based on a tree which does not have the recent: > dd635e33b5c9a ("platform: mellanox: Introduce support ofnew Nvidia L1 > switch") commit causing patch 2/16 to not apply. > > Please rebase on top of the latest pdx86/for-next: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers- > x86.git/log/?h=for-next I think the problem that branches: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next and https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans don't include series: [PATCH platform 0/4] platform/x86: mlx-platform: Provide fixes for several issues This patch set has been applied only to: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes Can you, please cherry-pick this set to for-next or review-hans branch and I'll produce v3 on top of any of these two? Otherwise, we'll have conflict. This patch relocates some registers: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=fixes&id=d66a8aab7dc36c975bbaa6aa74cf7445878e7c69 And patch 2/16 cannot be applied, because it utilizes one of relocated offsets. It seems not relayed to dd635e33b5c9a, which exists in all branches. > > and submit a version 3. > > Regards, > > Hans > > > > > > > > Michael Shych (1): > > platform: mellanox: nvsw-sn2201: change fans i2c busses. > > > > Vadim Pasternak (15): > > platform: mellanox: Add new attributes > > platform: mellanox: Add field upgrade capability register > > platform: mellanox: Modify reset causes description > > platform: mellanox: mlx-platform: Modify health and power hotplug > > action > > platform: mellanox: mlx-platform: Add reset cause attribute > > platform: mellanox: mlx-platform: add support for additional CPLD > > platform: mellanox: mlx-platform: Modify power off callback > > platform: mellanox: Cosmetic changes > > platform: mellanox: mlx-platform: Add reset callback > > platform: mellanox: mlx-platform: Prepare driver to allow probing > > through ACPI infrastructure > > platform: mellanox: mlx-platform: Introduce ACPI init flow > > platform: mellanox: mlx-platform: Get interrupt line through ACPI > > platform: mellanox: Add initial support for PCIe based programming > > logic device > > platform/mellanox: mlxreg-hotplug: Extend condition for notification > > callback processing > > Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces > > > > .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ > > drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- > > drivers/platform/mellanox/nvsw-sn2201.c | 12 +- > > drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- > > 4 files changed, 383 insertions(+), 49 deletions(-) > >
Hi Vadim, On 8/21/23 18:29, Vadim Pasternak wrote: > Hi Hans, > > Thank you very much for review. > >> -----Original Message----- >> From: Hans de Goede <hdegoede@redhat.com> >> Sent: Monday, 21 August 2023 16:20 >> To: Vadim Pasternak <vadimp@nvidia.com> >> Cc: ilpo.jarvinen@linux.intel.com; platform-driver-x86@vger.kernel.org >> Subject: Re: [PATCH platform-next v2 00/16] Add new features and >> amendments for Nvidia systems >> >> Hi, >> >> On 8/14/23 22:33, Vadim Pasternak wrote: >>> The patch set: >>> - Provides New system attributes for monitoring. >>> - Adds system reboot callback to perform system specific operations. >>> - Adds support for ACPI based initialization flow. >>> - Adds support for FPGA device connected through PCIe bus. >>> - Adds additional logic for hotplug events handling. >>> - Contains some amendments and cosmetic changes. >>> >>> The patch set includes: >>> Patches #1 - #3, #5: add new attributes for monitoring. >>> Patch #4: sets hotplug event action for health and power signals. >>> Patch #6: adds CPLD versioning registers for systems equipped with five >>> CPLD devices. >>> Patch #7: modifies power off callback. >>> Patch #8: cosmetic changes - fixes misspelling. >>> Patch #9: provides system reboot callback through system reboot >>> notifier. >>> Patch #10: prepares driver to allow probing through ACPI hooks along >>> with probing through DMI hooks. >>> Patch #11: adds ACPI match hook for initialization flow. >>> Patch #12: adds support for getting system interrupt line from ACPI >>> table. >>> Patch #13: adds initial support for programming logic device connected >>> through PCIe. >>> Patch #14: Extends condition for notification callback processing. >>> Patch #15: defines the exact i2c bus of fans on the SN2201 system. >>> Patch #16: Documents new attributes. >> >> Thanks. >> >> 1 remark about Patch #16: Documents new attributes, this does not document >> the new reset_swb_dc_dc_pwr_fail attribute, please add this. >> >> With that fixed the entire looks good to me: >> >> Reviewed-by: Hans de Goede <hdegoede@redhat.com> >> >> for the series. >> >> I tried applying this, but it is based on a tree which does not have the recent: >> dd635e33b5c9a ("platform: mellanox: Introduce support ofnew Nvidia L1 >> switch") commit causing patch 2/16 to not apply. >> >> Please rebase on top of the latest pdx86/for-next: >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers- >> x86.git/log/?h=for-next > > I think the problem that branches: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next > and > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > don't include series: > [PATCH platform 0/4] platform/x86: mlx-platform: Provide fixes for several issues > > This patch set has been applied only to: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes > > Can you, please cherry-pick this set to for-next or review-hans branch and I'll produce v3 > on top of any of these two? Ok. I've merged (1) pdx86/fixes into my review-hans branch now and pushed out the result. Please base v3 on top of the latest review-hans state. 1) It is prefered to avoid a single patch getting 2 commit ids which cherry-picking does, that is why I chose to do a back-merge here. Regards, Hans
The patch set: - Provides New system attributes for monitoring. - Adds system reboot callback to perform system specific operations. - Adds support for ACPI based initialization flow. - Adds support for FPGA device connected through PCIe bus. - Adds additional logic for hotplug events handling. - Contains some amendments and cosmetic changes. The patch set includes: Patches #1 - #3, #5: add new attributes for monitoring. Patch #4: sets hotplug event action for health and power signals. Patch #6: adds CPLD versioning registers for systems equipped with five CPLD devices. Patch #7: modifies power off callback. Patch #8: cosmetic changes - fixes misspelling. Patch #9: provides system reboot callback through system reboot notifier. Patch #10: prepares driver to allow probing through ACPI hooks along with probing through DMI hooks. Patch #11: adds ACPI match hook for initialization flow. Patch #12: adds support for getting system interrupt line from ACPI table. Patch #13: adds initial support for programming logic device connected through PCIe. Patch #14: Extends condition for notification callback processing. Patch #15: defines the exact i2c bus of fans on the SN2201 system. Patch #16: Documents new attributes. Michael Shych (1): platform: mellanox: nvsw-sn2201: change fans i2c busses. Vadim Pasternak (15): platform: mellanox: Add new attributes platform: mellanox: Add field upgrade capability register platform: mellanox: Modify reset causes description platform: mellanox: mlx-platform: Modify health and power hotplug action platform: mellanox: mlx-platform: Add reset cause attribute platform: mellanox: mlx-platform: add support for additional CPLD platform: mellanox: mlx-platform: Modify power off callback platform: mellanox: Cosmetic changes platform: mellanox: mlx-platform: Add reset callback platform: mellanox: mlx-platform: Prepare driver to allow probing through ACPI infrastructure platform: mellanox: mlx-platform: Introduce ACPI init flow platform: mellanox: mlx-platform: Get interrupt line through ACPI platform: mellanox: Add initial support for PCIe based programming logic device platform/mellanox: mlxreg-hotplug: Extend condition for notification callback processing Documentation/ABI: Add new attribute for mlxreg-io sysfs interfaces .../ABI/stable/sysfs-driver-mlxreg-io | 42 ++ drivers/platform/mellanox/mlxreg-hotplug.c | 2 +- drivers/platform/mellanox/nvsw-sn2201.c | 12 +- drivers/platform/x86/mlx-platform.c | 376 ++++++++++++++++-- 4 files changed, 383 insertions(+), 49 deletions(-)