Message ID | 20230720135834.1977616-1-Frank.Li@nxp.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v4,1/2] PCI: layerscape: Add support for Link down notification | expand |
On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > Add support to pass Link down notification to Endpoint function driver > so that the LINK_DOWN event can be processed by the function. > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- @Lorenzo Could you please consider pick both patches? Manivannan already reviewed and only impact layerscape. Frank > Change from v2 to v4 > - none > Change from v1 to v2 > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index de4c1758a6c3..e0969ff2ddf7 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -89,6 +89,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > dev_dbg(pci->dev, "Link up\n"); > } else if (val & PEX_PF0_PME_MES_DR_LDD) { > dev_dbg(pci->dev, "Link down\n"); > + pci_epc_linkdown(pci->ep.epc); > } else if (val & PEX_PF0_PME_MES_DR_HRD) { > dev_dbg(pci->dev, "Hot reset\n"); > } > -- > 2.34.1 >
On Mon, Jul 31, 2023 at 11:06:31AM -0400, Frank Li wrote: > On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > > Add support to pass Link down notification to Endpoint function driver > > so that the LINK_DOWN event can be processed by the function. > > > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > @Lorenzo > > Could you please consider pick both patches? > Manivannan already reviewed and only impact layerscape. @lorenzo: ping > > Frank > > > Change from v2 to v4 > > - none > > Change from v1 to v2 > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > index de4c1758a6c3..e0969ff2ddf7 100644 > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > @@ -89,6 +89,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > > dev_dbg(pci->dev, "Link up\n"); > > } else if (val & PEX_PF0_PME_MES_DR_LDD) { > > dev_dbg(pci->dev, "Link down\n"); > > + pci_epc_linkdown(pci->ep.epc); > > } else if (val & PEX_PF0_PME_MES_DR_HRD) { > > dev_dbg(pci->dev, "Hot reset\n"); > > } > > -- > > 2.34.1 > >
On Wed, Aug 16, 2023 at 11:53:16AM -0400, Frank Li wrote: > On Mon, Jul 31, 2023 at 11:06:31AM -0400, Frank Li wrote: > > On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > > > Add support to pass Link down notification to Endpoint function driver > > > so that the LINK_DOWN event can be processed by the function. > > > > > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > > @Lorenzo > > > > Could you please consider pick both patches? > > Manivannan already reviewed and only impact layerscape. > > @lorenzo: > ping > > > > > Frank @lorenzo ping Frank > > > > > Change from v2 to v4 > > > - none > > > Change from v1 to v2 > > > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > index de4c1758a6c3..e0969ff2ddf7 100644 > > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > @@ -89,6 +89,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > > > dev_dbg(pci->dev, "Link up\n"); > > > } else if (val & PEX_PF0_PME_MES_DR_LDD) { > > > dev_dbg(pci->dev, "Link down\n"); > > > + pci_epc_linkdown(pci->ep.epc); > > > } else if (val & PEX_PF0_PME_MES_DR_HRD) { > > > dev_dbg(pci->dev, "Hot reset\n"); > > > } > > > -- > > > 2.34.1 > > >
On Wed, Aug 16, 2023 at 11:53:16AM -0400, Frank Li wrote: > On Mon, Jul 31, 2023 at 11:06:31AM -0400, Frank Li wrote: > > On Thu, Jul 20, 2023 at 09:58:33AM -0400, Frank Li wrote: > > > Add support to pass Link down notification to Endpoint function driver > > > so that the LINK_DOWN event can be processed by the function. > > > > > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > > @Lorenzo > > > > Could you please consider pick both patches? > > Manivannan already reviewed and only impact layerscape. > > @lorenzo: > ping I will have a look tomorrow. Lorenzo > > > > Frank > > > > > Change from v2 to v4 > > > - none > > > Change from v1 to v2 > > > > > > drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > index de4c1758a6c3..e0969ff2ddf7 100644 > > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > > > @@ -89,6 +89,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > > > dev_dbg(pci->dev, "Link up\n"); > > > } else if (val & PEX_PF0_PME_MES_DR_LDD) { > > > dev_dbg(pci->dev, "Link down\n"); > > > + pci_epc_linkdown(pci->ep.epc); > > > } else if (val & PEX_PF0_PME_MES_DR_HRD) { > > > dev_dbg(pci->dev, "Hot reset\n"); > > > } > > > -- > > > 2.34.1 > > >
On Thu, 20 Jul 2023 09:58:33 -0400, Frank Li wrote: > Add support to pass Link down notification to Endpoint function driver > so that the LINK_DOWN event can be processed by the function. > > Applied to controller/layerscape, thanks! [1/2] PCI: layerscape: Add support for Link down notification https://git.kernel.org/pci/pci/c/d28c0d84ca40 [2/2] PCI: layerscape: Add the workaround for lost link capabilities during reset. https://git.kernel.org/pci/pci/c/17cf8661ee0f Thanks, Lorenzo
diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c index de4c1758a6c3..e0969ff2ddf7 100644 --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c @@ -89,6 +89,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) dev_dbg(pci->dev, "Link up\n"); } else if (val & PEX_PF0_PME_MES_DR_LDD) { dev_dbg(pci->dev, "Link down\n"); + pci_epc_linkdown(pci->ep.epc); } else if (val & PEX_PF0_PME_MES_DR_HRD) { dev_dbg(pci->dev, "Hot reset\n"); }