| Message ID | b1b3f1d10b64e63c62db0105957a4ad5e0295d34.1692194193.git.martin.agren@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c81f1a167659ce0634fdd1dcdb43c2697b546151 |
| Headers | show |
| Series | some doc fixes on v2.42.0-rc2 | expand |
Martin Ågren <martin.agren@gmail.com> writes: > With `--stdin`, we read *from* standard input, not *for*. True, and the name of the stream is "the standard input". > Signed-off-by: Martin Ågren <martin.agren@gmail.com> > --- > Documentation/rev-list-options.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt > index e6468bf0eb..a4a0cb93b2 100644 > --- a/Documentation/rev-list-options.txt > +++ b/Documentation/rev-list-options.txt > @@ -237,7 +237,7 @@ endif::git-rev-list[] > > --stdin:: > In addition to getting arguments from the command line, read > - them for standard input as well. This accepts commits and > + them from standard input as well. This accepts commits and > pseudo-options like `--all` and `--glob=`. When a `--` separator > is seen, the following input is treated as paths and used to > limit the result.
Junio C Hamano <gitster@pobox.com> writes: > Martin Ågren <martin.agren@gmail.com> writes: > >> With `--stdin`, we read *from* standard input, not *for*. > > True, and the name of the stream is "the standard input". ... but there are too numerous instances of unadorned "standard input" in the documentation, let's leave it for now. Thanks for these fixes. Queued all four and will fast track. > >> Signed-off-by: Martin Ågren <martin.agren@gmail.com> >> --- >> Documentation/rev-list-options.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt >> index e6468bf0eb..a4a0cb93b2 100644 >> --- a/Documentation/rev-list-options.txt >> +++ b/Documentation/rev-list-options.txt >> @@ -237,7 +237,7 @@ endif::git-rev-list[] >> >> --stdin:: >> In addition to getting arguments from the command line, read >> - them for standard input as well. This accepts commits and >> + them from standard input as well. This accepts commits and >> pseudo-options like `--all` and `--glob=`. When a `--` separator >> is seen, the following input is treated as paths and used to >> limit the result.
On Wed, 16 Aug 2023 at 20:52, Junio C Hamano <gitster@pobox.com> wrote: > > Junio C Hamano <gitster@pobox.com> writes: > > > Martin Ågren <martin.agren@gmail.com> writes: > > > >> With `--stdin`, we read *from* standard input, not *for*. > > > > True, and the name of the stream is "the standard input". That's a good point, I hadn't really thought of that. > ... but there are too numerous instances of unadorned "standard > input" in the documentation, let's leave it for now. Ok. Martin
diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt index e6468bf0eb..a4a0cb93b2 100644 --- a/Documentation/rev-list-options.txt +++ b/Documentation/rev-list-options.txt @@ -237,7 +237,7 @@ endif::git-rev-list[] --stdin:: In addition to getting arguments from the command line, read - them for standard input as well. This accepts commits and + them from standard input as well. This accepts commits and pseudo-options like `--all` and `--glob=`. When a `--` separator is seen, the following input is treated as paths and used to limit the result.
With `--stdin`, we read *from* standard input, not *for*. Signed-off-by: Martin Ågren <martin.agren@gmail.com> --- Documentation/rev-list-options.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)