| Message ID | 20230816173116.1176-3-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | gnss: ubx: updates to support the Renesas KingFisher board | expand |
On Wed, Aug 16, 2023 at 07:31:14PM +0200, Wolfram Sang wrote: > Needed to enable this chip on a Renesas KingFisher board. Description > copied over from the Mediatek driver which already supports it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > > Changes since v1: > * dropped obvious description (Thanks, Geert!) > * added missing include (Thanks, Krzysztof and Rob!) > > I build tested the change this time. > > Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > index 4835a280b3bf..8e97e475613f 100644 > --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > @@ -41,6 +41,9 @@ properties: > description: > > Backup voltage regulator > > + reset-gpios: > + maxItems: 1 > + > required: > - compatible > - vcc-supply > @@ -49,10 +52,12 @@ unevaluatedProperties: false > > examples: > - | > + #include <dt-bindings/gpio/gpio.h> > serial { > gnss { > compatible = "u-blox,neo-8"; > v-bckp-supply = <&gnss_v_bckp_reg>; > vcc-supply = <&gnss_vcc_reg>; > + reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; > }; > }; > -- > 2.35.1 >
On Wed, 16 Aug 2023, Wolfram Sang wrote: > Needed to enable this chip on a Renesas KingFisher board. Description > copied over from the Mediatek driver which already supports it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Changes since v1: > * dropped obvious description (Thanks, Geert!) > * added missing include (Thanks, Krzysztof and Rob!) Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml index 4835a280b3bf..8e97e475613f 100644 --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml @@ -41,6 +41,9 @@ properties: description: > Backup voltage regulator + reset-gpios: + maxItems: 1 + required: - compatible - vcc-supply @@ -49,10 +52,12 @@ unevaluatedProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> serial { gnss { compatible = "u-blox,neo-8"; v-bckp-supply = <&gnss_v_bckp_reg>; vcc-supply = <&gnss_vcc_reg>; + reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; }; };
Needed to enable this chip on a Renesas KingFisher board. Description copied over from the Mediatek driver which already supports it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Changes since v1: * dropped obvious description (Thanks, Geert!) * added missing include (Thanks, Krzysztof and Rob!) I build tested the change this time. Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml | 5 +++++ 1 file changed, 5 insertions(+)