mbox series

[GIT,PULL,FOR,v6.6] vb2: frame_vector.c: replace WARN_ONCE with a comment

Message ID 5b8be6e8-e6e9-c3a2-b972-190ddc11ec0d@xs4all.nl (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,v6.6] vb2: frame_vector.c: replace WARN_ONCE with a comment | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.6o

Message

Hans Verkuil Aug. 18, 2023, 10:32 a.m. UTC
See https://patchwork.linuxtv.org/project/linux-media/patch/d5e1ee76-75b3-26cb-23ae-cf6ab40597b7@xs4all.nl/
with Linus' comment.

This should go to 6.6.

Getting rid of this WARN will also help improve our regression tests: the
test-media script can now check for kernel oopses etc. and report that.

Currently the dmesg output is saved, but it isn't checked.

Regards,

	Hans

The following changes since commit 111073c8b6146b745bd52316ddfa0651bf8fcedb:

  media: pci: ivsc: Select build dependencies (2023-08-18 12:28:07 +0200)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.6o

for you to fetch changes up to 5f63d1de4622a83567a190e93a841f6c1e424f40:

  media: vb2: frame_vector.c: replace WARN_ONCE with a comment (2023-08-18 12:29:21 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (1):
      media: vb2: frame_vector.c: replace WARN_ONCE with a comment

 drivers/media/common/videobuf2/frame_vector.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jenkins Aug. 18, 2023, 11:01 a.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/5b8be6e8-e6e9-c3a2-b972-190ddc11ec0d@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/331842/
Build time: 00:19:23
Link: https://lore.kernel.org/linux-media/5b8be6e8-e6e9-c3a2-b972-190ddc11ec0d@xs4all.nl

gpg: Signature made Fri 18 Aug 2023 10:29:43 AM UTC
gpg:                using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: got 1/1 patches with issues, being 1 at build time

Error/warnings:

patches/0001-media-vb2-frame_vector.c-replace-WARN_ONCE-with-a-co.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:447 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_fops.c: ../drivers/staging/media/atomisp/pci/atomisp_fops.c:517 atomisp_open() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2801 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2900 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	../drivers/media/usb/dvb-usb-v2/af9035.c: ../drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
	  Locked on  : 326,387
	  Unlocked on: 465,467
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2771 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: OOM: 3000012Kb sm_state_count = 1971182
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() warn: Function too hairy.  No more merges.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2558 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 53 seconds
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression

   checkpatch.pl:
	$ cat patches/0001-media-vb2-frame_vector.c-replace-WARN_ONCE-with-a-co.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:15: WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report