| Message ID | 20230818144556.1208082-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] fs/pipe: remove redundant initialization of pointer buf | expand |
On Fri, 18 Aug 2023 15:45:56 +0100, Colin Ian King wrote: > The pointer buf is being initializated with a value that is never read, > it is being re-assigned later on at the pointer where it is being used. > The initialization is redundant and can be removed. Cleans up clang scan > build warning: > > fs/pipe.c:492:24: warning: Value stored to 'buf' during its > initialization is never read [deadcode.DeadStores] > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs/pipe: remove redundant initialization of pointer buf https://git.kernel.org/vfs/vfs/c/241a71ef5d91
diff --git a/fs/pipe.c b/fs/pipe.c index 8190a231329b..6c1a9b1db907 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -489,7 +489,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from) head = pipe->head; if (!pipe_full(head, pipe->tail, pipe->max_usage)) { unsigned int mask = pipe->ring_size - 1; - struct pipe_buffer *buf = &pipe->bufs[head & mask]; + struct pipe_buffer *buf; struct page *page = pipe->tmp_page; int copied;
The pointer buf is being initializated with a value that is never read, it is being re-assigned later on at the pointer where it is being used. The initialization is redundant and can be removed. Cleans up clang scan build warning: fs/pipe.c:492:24: warning: Value stored to 'buf' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- fs/pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)