| Message ID | 20230814081148.4027053-2-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mm-evk: Fix hdmi@3d node | expand |
Hi Liu, On Mon, Aug 14, 2023 at 5:07 AM Liu Ying <victor.liu@nxp.com> wrote: > + reg_vddext_3v3: regulator-vddext-3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDEXT_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <300000>; > + }; Booting the dtb with this change will cause this regulator to be disabled as there is no consumer for it. I suggest squashing both patches: Tested-by: Fabio Estevam <festevam@gmail.com>
On Friday, August 18, 2023 10:06 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Liu, Hi Fabio, > > On Mon, Aug 14, 2023 at 5:07 AM Liu Ying <victor.liu@nxp.com> wrote: > > > + reg_vddext_3v3: regulator-vddext-3v3 { > > + compatible = "regulator-fixed"; > > + regulator-name = "VDDEXT_3V3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <300000>; > > + }; > > Booting the dtb with this change will cause this regulator to be > disabled as there is no consumer for it. Software cannot control this regulator by any means. It's on once the board is powered on. Do you mean it will be disabled in software level if no consumer? If that's the case, is the disablement harmful? > > I suggest squashing both patches: The patch looks self-contained to me. Can we keep it as-is? > > Tested-by: Fabio Estevam <festevam@gmail.com> Thanks for your test! Regards, Liu Ying
On Mon, Aug 21, 2023 at 02:33:17AM +0000, Ying Liu wrote: > On Friday, August 18, 2023 10:06 PM Fabio Estevam <festevam@gmail.com> wrote: > > On Mon, Aug 14, 2023 at 5:07 AM Liu Ying <victor.liu@nxp.com> wrote: > > > > > + reg_vddext_3v3: regulator-vddext-3v3 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "VDDEXT_3V3"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <300000>; > > > + }; > > > > Booting the dtb with this change will cause this regulator to be > > disabled as there is no consumer for it. > > Software cannot control this regulator by any means. It's on once > the board is powered on. Do you mean it will be disabled in software > level if no consumer? If that's the case, is the disablement harmful? > > > > > I suggest squashing both patches: > > The patch looks self-contained to me. Can we keep it as-is? While I agree the patch is self-contained, squashing them will make it easier to apply the change as a fix and cherry-pick the fix to stable kernel. Applied with squashing, thanks! Shawn
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi index df8e808ac473..7cd1cedfa9e9 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi @@ -72,6 +72,13 @@ reg_usdhc2_vmmc: regulator-usdhc2 { enable-active-high; }; + reg_vddext_3v3: regulator-vddext-3v3 { + compatible = "regulator-fixed"; + regulator-name = "VDDEXT_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + backlight: backlight { compatible = "pwm-backlight"; pwms = <&pwm1 0 5000000 0>;
The VDDEXT_3V3 fixed regulator supplies 3.3v power for MIPI CSI/DSI through mini-SAS connector and M.2 PCIe according to board schematic, so add the fixed regulator support. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)