diff mbox series

[11/17] scsi: gvp11: remove unused gvp11_setup() function

Message ID 20230810141947.1236730-12-arnd@kernel.org (mailing list archive)
State Accepted
Headers show
Series -Wmissing-prototype warning fixes | expand

Commit Message

Arnd Bergmann Aug. 10, 2023, 2:19 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

This function has no declaration, which causes a warning:

drivers/scsi/gvp11.c:53:6: error: no previous prototype for 'gvp11_setup' [-Werror=missing-prototypes]

Since there is also no caller, just remove the function.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/scsi/gvp11.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Geert Uytterhoeven Aug. 16, 2023, 3:52 p.m. UTC | #1 
On Thu, Aug 10, 2023 at 4:35 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function has no declaration, which causes a warning:
>
> drivers/scsi/gvp11.c:53:6: error: no previous prototype for 'gvp11_setup' [-Werror=missing-prototypes]
>
> Since there is also no caller, just remove the function.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert
Martin K. Petersen Aug. 21, 2023, 8:38 p.m. UTC | #2 
Arnd,

> This function has no declaration, which causes a warning:
>
> drivers/scsi/gvp11.c:53:6: error: no previous prototype for
> 'gvp11_setup' [-Werror=missing-prototypes]
>
> Since there is also no caller, just remove the function.

Applied to 6.6/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/gvp11.c b/drivers/scsi/gvp11.c
index d2eddad099a2b..0420bfe9bd42d 100644
--- a/drivers/scsi/gvp11.c
+++ b/drivers/scsi/gvp11.c
@@ -50,11 +50,6 @@  static irqreturn_t gvp11_intr(int irq, void *data)
 
 static int gvp11_xfer_mask = 0;
 
-void gvp11_setup(char *str, int *ints)
-{
-	gvp11_xfer_mask = ints[1];
-}
-
 static int dma_setup(struct scsi_cmnd *cmd, int dir_in)
 {
 	struct scsi_pointer *scsi_pointer = WD33C93_scsi_pointer(cmd);