| Message ID | 20230803063703.5659-1-zhuyinbo@loongson.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: loongson2_pm: add power management support | expand |
On Thu, Aug 3, 2023, at 02:37, Yinbo Zhu wrote: > Loongson-2 platform support Power Management Controller (ACPI) and this > series patch was to add PM driver that base on dts and PM binding support. > > Change in v6: > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > pm interfaces" had been merged into mainline tree in v6.5-rc1 > thus this v6 series patch need drop it and need depend on it > and it's patch link was: > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > 2. Adding Ulf Hansson to Cc. > 3. Adding soc@kernel.org to Cc. > 4. Keep indented with one tab +2 spaces in Kconfig help text. I talked to WANG Xuerui on IRC, and he was able to clarify some of the missing bits of information for me, after which I merged both patches, even though my concerns are not fully addressed: - I still think that branching into ROM code from the kernel is a mistake and we should have never allowed that as an ad-hoc interface in the ACPI variant to start with. It's hard to change that now though, and having a DT interface to access the same entry point does not really make it worse. This might need a redesign for future firmware though, to have a proper runtime interface - The bigger problem I still see is the DT-enabled boot with PMon without the UEFI firmware. This does not impact the DT binding, but I would consider all non-UEFI booting firmware images broken and not supported by the kernel, as we originally discussed when merging the kernel. These should still be fixable by upgrading PMon to a UEFI-enabled version. Arnd
Hello: This series was applied to soc/soc.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Thu, 3 Aug 2023 14:37:01 +0800 you wrote: > Loongson-2 platform support Power Management Controller (ACPI) and this > series patch was to add PM driver that base on dts and PM binding support. > > Change in v6: > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > pm interfaces" had been merged into mainline tree in v6.5-rc1 > thus this v6 series patch need drop it and need depend on it > and it's patch link was: > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > 2. Adding Ulf Hansson to Cc. > 3. Adding soc@kernel.org to Cc. > 4. Keep indented with one tab +2 spaces in Kconfig help text. > Change in v5: > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > pm interfaces" had been merged into linux-next tree thus this > v4 series patch need drop it and need depend on it and it's > patch link was: > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > 2. Swap the positions of compatible for 2k1000 and 2k0500. > Change in v4: > 1. The patch "[PATCH v3 1/3] loongarch: export some arch-specific > pm interfaces" had been merged into linux-next tree thus this > v4 series patch need drop it and need depend on it and it's > patch link was: > https://lore.kernel.org/all/20230615091757.24686-2-zhuyinbo@loongson.cn/ > 2. Remove the pmc label in dt-binding patch. > 3. Add the Co-developed-by for driver patch. > 4. Simplify the loongson2_suspend_valid_state that "return > (state == PM_SUSPEND_MEM)". > 5. Use Using loongson2_pm_irq_enable() to replace. > loongson2_power_button_irq_enable(). > 6. Remove the "oneOf" in dt-bindings patch. > 7. Replace "suspend-address" that use "loongson,suspend-address". > 8. Use u64 type that for "loongson,suspend-address". > 9. Rename "pm" to "power-mangement" in dt-bindings patch. > 10. Add the reivewed-by for dt-bindings patch. > Change in v3: > 1. Reword the [1/3] patch commit log and title. > 2. Use the old naming for suspend interface for the [1/3] and > [3/3] patch. > 3. Combine some small function in the driver patch. > 4. Rename 'pwrbt' to 'button' in the driver patch. > 5. Use the specific compatible in yaml file. > Change in v2: > 1. Fixup the "suspend-address" description. > 2. Remove the "return -EINVAL" in PM driver probe when firmware > no configure "suspend-address" property in dts in oder to > other PM state to work. > > [...] Here is the summary with links: - [v6,1/2] soc: dt-bindings: add loongson-2 pm https://git.kernel.org/soc/soc/c/6054a676e969 - [v6,2/2] soc: loongson2_pm: add power management support https://git.kernel.org/soc/soc/c/67694c076bd7 You are awesome, thank you!