| Message ID | 20230821134029.40084-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a491add19faf335faa75d6baa69adb0a9a588df2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: ti: Remove unused declarations | expand |
On Mon, Aug 21, 2023 at 09:40:29PM +0800, Yue Haibing wrote: > Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK") > removed am65_cpsw_nuss_adjust_link() but not its declaration. > Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") > declared but never implemented netcp_device_find_module(). > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
On 21/08/2023 16:40, Yue Haibing wrote: > Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK") > removed am65_cpsw_nuss_adjust_link() but not its declaration. > Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") > declared but never implemented netcp_device_find_module(). > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Acked-by: Roger Quadros <rogerq@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 21 Aug 2023 21:40:29 +0800 you wrote: > Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK") > removed am65_cpsw_nuss_adjust_link() but not its declaration. > Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") > declared but never implemented netcp_device_find_module(). > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > > [...] Here is the summary with links: - [net-next] net: ethernet: ti: Remove unused declarations https://git.kernel.org/netdev/net-next/c/a491add19faf You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.h b/drivers/net/ethernet/ti/am65-cpsw-nuss.h index bf40c88fbd9b..f3dad2ab9828 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.h +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.h @@ -192,7 +192,6 @@ struct am65_cpsw_ndev_priv { extern const struct ethtool_ops am65_cpsw_ethtool_ops_slave; -void am65_cpsw_nuss_adjust_link(struct net_device *ndev); void am65_cpsw_nuss_set_p0_ptype(struct am65_cpsw_common *common); void am65_cpsw_nuss_remove_tx_chns(struct am65_cpsw_common *common); int am65_cpsw_nuss_update_tx_chns(struct am65_cpsw_common *common, int num_tx); diff --git a/drivers/net/ethernet/ti/netcp.h b/drivers/net/ethernet/ti/netcp.h index 43d5cd59b56b..7007eb8bed36 100644 --- a/drivers/net/ethernet/ti/netcp.h +++ b/drivers/net/ethernet/ti/netcp.h @@ -233,8 +233,6 @@ int netcp_register_rxhook(struct netcp_intf *netcp_priv, int order, netcp_hook_rtn *hook_rtn, void *hook_data); int netcp_unregister_rxhook(struct netcp_intf *netcp_priv, int order, netcp_hook_rtn *hook_rtn, void *hook_data); -void *netcp_device_find_module(struct netcp_device *netcp_device, - const char *name); /* SGMII functions */ int netcp_sgmii_reset(void __iomem *sgmii_ofs, int port);
Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK") removed am65_cpsw_nuss_adjust_link() but not its declaration. Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") declared but never implemented netcp_device_find_module(). Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 - drivers/net/ethernet/ti/netcp.h | 2 -- 2 files changed, 3 deletions(-)