diff mbox series

[net-next] net: dsa: rzn1-a5psw: remove redundant logs

Message ID 20230822084112.54803-1-alexis.lothore@bootlin.com (mailing list archive)
State Accepted
Commit 2e0c8ee2b56ffaf4ceac934d75f131a9c9becf72
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: dsa: rzn1-a5psw: remove redundant logs | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 9 this patch: 9
netdev/cc_maintainers warning 1 maintainers not CCed: clement.leger@bootlin.com
netdev/build_clang success Errors and warnings before: 9 this patch: 9
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 9 this patch: 9
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 18 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Alexis Lothoré (eBPF Foundation) Aug. 22, 2023, 8:41 a.m. UTC 
From: Alexis Lothoré <alexis.lothore@bootlin.com>

Remove debug logs in port vlan management, since there are already multiple
tracepoints defined for those operations in DSA

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
This update is a follow-up to Vladimir Oltean's comment (see [1]) which has
not been addressed before the RZN1 A5PSW vlan series merge

[1] https://lore.kernel.org/netdev/20230811100613.o77ei6updvbndkjm@skbuf/
---
 drivers/net/dsa/rzn1_a5psw.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Florian Fainelli Aug. 22, 2023, 3:49 p.m. UTC | #1 
On 8/22/2023 1:41 AM, Alexis Lothoré wrote:
> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> Remove debug logs in port vlan management, since there are already multiple
> tracepoints defined for those operations in DSA
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
patchwork-bot+netdevbpf@kernel.org Aug. 23, 2023, 8:50 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Tue, 22 Aug 2023 10:41:12 +0200 you wrote:
> From: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> Remove debug logs in port vlan management, since there are already multiple
> tracepoints defined for those operations in DSA
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: rzn1-a5psw: remove redundant logs
    https://git.kernel.org/netdev/net-next/c/2e0c8ee2b56f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
index 9167e83fbceb..2eda10b33f2e 100644
--- a/drivers/net/dsa/rzn1_a5psw.c
+++ b/drivers/net/dsa/rzn1_a5psw.c
@@ -735,10 +735,6 @@  static int a5psw_port_vlan_add(struct dsa_switch *ds, int port,
 	u16 vid = vlan->vid;
 	int vlan_res_id;
 
-	dev_dbg(a5psw->dev, "Add VLAN %d on port %d, %s, %s\n",
-		vid, port, tagged ? "tagged" : "untagged",
-		pvid ? "PVID" : "no PVID");
-
 	vlan_res_id = a5psw_find_vlan_entry(a5psw, vid);
 	if (vlan_res_id < 0) {
 		vlan_res_id = a5psw_new_vlan_res_entry(a5psw, vid);
@@ -767,8 +763,6 @@  static int a5psw_port_vlan_del(struct dsa_switch *ds, int port,
 	u16 vid = vlan->vid;
 	int vlan_res_id;
 
-	dev_dbg(a5psw->dev, "Removing VLAN %d on port %d\n", vid, port);
-
 	vlan_res_id = a5psw_find_vlan_entry(a5psw, vid);
 	if (vlan_res_id < 0)
 		return -EINVAL;