| Message ID | 20230823081500.84005-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/3] dt-bindings: display: panel: add common dual-display schema | expand |
Hi Krzysztof, Thank you for the patch. On Wed, Aug 23, 2023 at 10:14:58AM +0200, Krzysztof Kozlowski wrote: > Add schema with common properties shared among dual display panel ICs. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > v2: https://lore.kernel.org/all/20230502120036.47165-1-krzysztof.kozlowski@linaro.org/ > v1: https://lore.kernel.org/all/20230416153929.356330-1-krzysztof.kozlowski@linaro.org/ > > Changes since v2: > 1. New Patch > --- > .../display/panel/panel-common-dual.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml > new file mode 100644 > index 000000000000..83fcd643b5f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common Properties for Dual-Display Panels > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > + > +description: > + Properties common for Panel IC supporting dual display panels. Could you elaborate on what you mean by dual display panels ? From what I understand of the patch series, this seems to be what I have called dual port panels, that is panels that have two input ports to double the bandwidth, but still operate as one display. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + additionalProperties: false > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: First display panel > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Second display panel > + > + "#address-cells": true > + "#size-cells": true > + > + required: > + - port@0 > + > +# Single-panel setups are still allowed. > +oneOf: > + - required: > + - ports > + - required: > + - port > + > +additionalProperties: true
On 23/08/2023 10:34, Laurent Pinchart wrote: > Hi Krzysztof, > > Thank you for the patch. > > On Wed, Aug 23, 2023 at 10:14:58AM +0200, Krzysztof Kozlowski wrote: >> Add schema with common properties shared among dual display panel ICs. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> v2: https://lore.kernel.org/all/20230502120036.47165-1-krzysztof.kozlowski@linaro.org/ >> v1: https://lore.kernel.org/all/20230416153929.356330-1-krzysztof.kozlowski@linaro.org/ >> >> Changes since v2: >> 1. New Patch >> --- >> .../display/panel/panel-common-dual.yaml | 46 +++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml >> new file mode 100644 >> index 000000000000..83fcd643b5f5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml >> @@ -0,0 +1,46 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Common Properties for Dual-Display Panels >> + >> +maintainers: >> + - Thierry Reding <thierry.reding@gmail.com> >> + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> >> + >> +description: >> + Properties common for Panel IC supporting dual display panels. > > Could you elaborate on what you mean by dual display panels ? From what > I understand of the patch series, this seems to be what I have called > dual port panels, that is panels that have two input ports to double the > bandwidth, but still operate as one display. Indeed, looks like that. I don't have the datasheets so I am trying to get some pieces of information. Judging by the usage of these panels - Qualcomm DSI with qcom,dual-dsi-mode - it indeed is one panel with two links. I would need to rephrase it. Best regards, Krzysztof
On Wed, Aug 23, 2023 at 11:35:24AM +0200, Krzysztof Kozlowski wrote: > On 23/08/2023 10:34, Laurent Pinchart wrote: > > Hi Krzysztof, > > > > Thank you for the patch. > > > > On Wed, Aug 23, 2023 at 10:14:58AM +0200, Krzysztof Kozlowski wrote: > >> Add schema with common properties shared among dual display panel ICs. > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> > >> --- > >> > >> v2: https://lore.kernel.org/all/20230502120036.47165-1-krzysztof.kozlowski@linaro.org/ > >> v1: https://lore.kernel.org/all/20230416153929.356330-1-krzysztof.kozlowski@linaro.org/ > >> > >> Changes since v2: > >> 1. New Patch > >> --- > >> .../display/panel/panel-common-dual.yaml | 46 +++++++++++++++++++ > >> 1 file changed, 46 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml > >> new file mode 100644 > >> index 000000000000..83fcd643b5f5 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml > >> @@ -0,0 +1,46 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Common Properties for Dual-Display Panels > >> + > >> +maintainers: > >> + - Thierry Reding <thierry.reding@gmail.com> > >> + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > >> + > >> +description: > >> + Properties common for Panel IC supporting dual display panels. > > > > Could you elaborate on what you mean by dual display panels ? From what > > I understand of the patch series, this seems to be what I have called > > dual port panels, that is panels that have two input ports to double the > > bandwidth, but still operate as one display. > > Indeed, looks like that. I don't have the datasheets so I am trying to > get some pieces of information. Judging by the usage of these panels - > Qualcomm DSI with qcom,dual-dsi-mode - it indeed is one panel with two > links. > > I would need to rephrase it. Thanks :-) Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.yaml may be of interest to you, it's a bridge with two LVDS inputs. On the other side, I've used Documentation/devicetree/bindings/display/bridge/renesas,lvds.yaml which is an LVDS encoder with a single output, but with the ability to operate in dual link mode by coupling two encoder instances.
diff --git a/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml new file mode 100644 index 000000000000..83fcd643b5f5 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-common-dual.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Common Properties for Dual-Display Panels + +maintainers: + - Thierry Reding <thierry.reding@gmail.com> + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> + +description: + Properties common for Panel IC supporting dual display panels. + +allOf: + - $ref: panel-common.yaml# + +properties: + ports: + $ref: /schemas/graph.yaml#/properties/ports + additionalProperties: false + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: First display panel + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: Second display panel + + "#address-cells": true + "#size-cells": true + + required: + - port@0 + +# Single-panel setups are still allowed. +oneOf: + - required: + - ports + - required: + - port + +additionalProperties: true
Add schema with common properties shared among dual display panel ICs. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- v2: https://lore.kernel.org/all/20230502120036.47165-1-krzysztof.kozlowski@linaro.org/ v1: https://lore.kernel.org/all/20230416153929.356330-1-krzysztof.kozlowski@linaro.org/ Changes since v2: 1. New Patch --- .../display/panel/panel-common-dual.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-common-dual.yaml