diff mbox series

[v6,2/5] dt-bindings: net: Add IEP property in ICSSG

Message ID 20230823113254.292603-3-danishanwar@ti.com (mailing list archive)
State New, archived
Headers show
Series Introduce IEP driver and packet timestamping support | expand

Commit Message

MD Danish Anwar Aug. 23, 2023, 11:32 a.m. UTC 
Add IEP property in ICSSG hardware DT binding document.
ICSSG uses IEP (Industrial Ethernet Peripheral) to support timestamping
of ethernet packets, PTP and PPS.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 .../devicetree/bindings/net/ti,icssg-prueth.yaml         | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Krzysztof Kozlowski Aug. 24, 2023, 6:45 a.m. UTC | #1 
On 23/08/2023 13:32, MD Danish Anwar wrote:
> Add IEP property in ICSSG hardware DT binding document.
> ICSSG uses IEP (Industrial Ethernet Peripheral) to support timestamping
> of ethernet packets, PTP and PPS.
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Where? Please provide link.

> Reviewed-by: Roger Quadros <rogerq@kernel.org>

Where? Please provide link.

> Reviewed-by: Simon Horman <horms@kernel.org>

Where? Please provide link.

Otherwise all of them look like fake ways to sneak patches into the
kernel. Our work here depends a lot on the trust. Trust once lost, is
tricky to get back.

> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---


Best regards,
Krzysztof
Anwar, Md Danish Aug. 24, 2023, 6:51 a.m. UTC | #2 
On 24/08/23 12:15 pm, Krzysztof Kozlowski wrote:
> On 23/08/2023 13:32, MD Danish Anwar wrote:
>> Add IEP property in ICSSG hardware DT binding document.
>> ICSSG uses IEP (Industrial Ethernet Peripheral) to support timestamping
>> of ethernet packets, PTP and PPS.
>>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Where? Please provide link.
> 

https://lore.kernel.org/all/20230814-quarters-cahoots-1fbd583baad9@spud/

>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> 
> Where? Please provide link.

https://lore.kernel.org/all/5d077342-435f-2829-ba2a-cdf763b6b8e1@kernel.org/

> 
>> Reviewed-by: Simon Horman <horms@kernel.org>
> 
> Where? Please provide link.

https://lore.kernel.org/all/ZN9aSTUOT+SKESQS@vergenet.net/

> 
> Otherwise all of them look like fake ways to sneak patches into the
> kernel. Our work here depends a lot on the trust. Trust once lost, is
> tricky to get back.
> 

It's not fake. They provided they RB tags, after that while preparing next
revision I use b4 to get all the tags and apply to applicable patches. I know
trust is important and I won't do such things like faking tags. They gave their
tags in v4 and v5, you must have missed those probably.

>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
> 
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Aug. 24, 2023, 6:52 a.m. UTC | #3 
On 24/08/2023 08:51, Md Danish Anwar wrote:
> On 24/08/23 12:15 pm, Krzysztof Kozlowski wrote:
>> On 23/08/2023 13:32, MD Danish Anwar wrote:
>>> Add IEP property in ICSSG hardware DT binding document.
>>> ICSSG uses IEP (Industrial Ethernet Peripheral) to support timestamping
>>> of ethernet packets, PTP and PPS.
>>>
>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> Where? Please provide link.
>>
> 
> https://lore.kernel.org/all/20230814-quarters-cahoots-1fbd583baad9@spud/
> 
>>> Reviewed-by: Roger Quadros <rogerq@kernel.org>
>>
>> Where? Please provide link.
> 
> https://lore.kernel.org/all/5d077342-435f-2829-ba2a-cdf763b6b8e1@kernel.org/
> 
>>
>>> Reviewed-by: Simon Horman <horms@kernel.org>
>>
>> Where? Please provide link.
> 
> https://lore.kernel.org/all/ZN9aSTUOT+SKESQS@vergenet.net/
> 
>>
>> Otherwise all of them look like fake ways to sneak patches into the
>> kernel. Our work here depends a lot on the trust. Trust once lost, is
>> tricky to get back.
>>
> 
> It's not fake. They provided they RB tags, after that while preparing next
> revision I use b4 to get all the tags and apply to applicable patches. I know
> trust is important and I won't do such things like faking tags. They gave their
> tags in v4 and v5, you must have missed those probably.
> 

Yes, I missed that while searching. Sorry for the noise and questions.
Thank you for providing the links.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
index 8ec30b3eb760..311c570165f9 100644
--- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
+++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
@@ -52,6 +52,14 @@  properties:
     description:
       phandle to MII_RT module's syscon regmap
 
+  ti,iep:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    maxItems: 2
+    items:
+      maxItems: 1
+    description:
+      phandle to IEP (Industrial Ethernet Peripheral) for ICSSG
+
   interrupts:
     maxItems: 2
     description:
@@ -155,6 +163,7 @@  examples:
                     "tx1-0", "tx1-1", "tx1-2", "tx1-3",
                     "rx0", "rx1";
         ti,mii-g-rt = <&icssg2_mii_g_rt>;
+        ti,iep = <&icssg2_iep0>, <&icssg2_iep1>;
         interrupt-parent = <&icssg2_intc>;
         interrupts = <24 0 2>, <25 1 3>;
         interrupt-names = "tx_ts0", "tx_ts1";