| Message ID | 20230824075448.76548-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ceph: Remove duplicate include | expand |
On 8/24/23 15:54, Jiapeng Chong wrote: > ./fs/ceph/mds_client.c: crypto.h is included more than once. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > fs/ceph/mds_client.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index 7cfa0e3aedb4..9a3b617270c3 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -16,7 +16,6 @@ > #include "super.h" > #include "crypto.h" > #include "mds_client.h" > -#include "crypto.h" > > #include <linux/ceph/ceph_features.h> > #include <linux/ceph/messenger.h> Reviewed-by: Xiubo Li <xiubli@redhat.com>
On Thu, Aug 24, 2023 at 10:18 AM Xiubo Li <xiubli@redhat.com> wrote: > > > On 8/24/23 15:54, Jiapeng Chong wrote: > > ./fs/ceph/mds_client.c: crypto.h is included more than once. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211 > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > --- > > fs/ceph/mds_client.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > > index 7cfa0e3aedb4..9a3b617270c3 100644 > > --- a/fs/ceph/mds_client.c > > +++ b/fs/ceph/mds_client.c > > @@ -16,7 +16,6 @@ > > #include "super.h" > > #include "crypto.h" > > #include "mds_client.h" > > -#include "crypto.h" > > > > #include <linux/ceph/ceph_features.h> > > #include <linux/ceph/messenger.h> > > Reviewed-by: Xiubo Li <xiubli@redhat.com> I folded the fix into "ceph: encode encrypted name in ceph_mdsc_build_path and dentry release" commit. Thanks for the report! Ilya
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 7cfa0e3aedb4..9a3b617270c3 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c @@ -16,7 +16,6 @@ #include "super.h" #include "crypto.h" #include "mds_client.h" -#include "crypto.h" #include <linux/ceph/ceph_features.h> #include <linux/ceph/messenger.h>
./fs/ceph/mds_client.c: crypto.h is included more than once. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- fs/ceph/mds_client.c | 1 - 1 file changed, 1 deletion(-)