| Message ID | 20230824064336.1889106-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 786c96e92fb9e854cb8b0cb7399bb2fb28e15c4b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: arcnet: Do not call kfree_skb() under local_irq_disable() | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 24 Aug 2023 14:43:36 +0800 you wrote: > It is not allowed to call kfree_skb() from hardware interrupt > context or with hardware interrupts being disabled. > So replace kfree_skb() with dev_kfree_skb_irq() under > local_irq_disable(). Compile tested only. > > Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback") > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> > > [...] Here is the summary with links: - net: arcnet: Do not call kfree_skb() under local_irq_disable() https://git.kernel.org/netdev/net/c/786c96e92fb9 You are awesome, thank you!
diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c index 99265667538c..d9e052c49ba1 100644 --- a/drivers/net/arcnet/arcnet.c +++ b/drivers/net/arcnet/arcnet.c @@ -464,7 +464,7 @@ static void arcnet_reply_tasklet(struct tasklet_struct *t) ret = sock_queue_err_skb(sk, ackskb); if (ret) - kfree_skb(ackskb); + dev_kfree_skb_irq(ackskb); local_irq_enable(); };
It is not allowed to call kfree_skb() from hardware interrupt context or with hardware interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under local_irq_disable(). Compile tested only. Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)