mbox series

[net-next,v2,0/4] selftests/tc-testing: add tests covering classid

Message ID 20230825155148.659895-1-pctammela@mojatatu.com (mailing list archive)
Headers show
Series selftests/tc-testing: add tests covering classid | expand

Message

Pedro Tammela Aug. 25, 2023, 3:51 p.m. UTC 
Patches 1-3 add missing tests covering classid behaviour on tdc for cls_fw,
cls_route and cls_fw. This behaviour was recently fixed by valis[0].

Patch 4 comes from the development done in the previous patches as it turns out
cls_route never returns meaningful errors.

[0] https://lore.kernel.org/all/20230729123202.72406-1-jhs@mojatatu.com/

v1->v2: https://lore.kernel.org/all/20230818163544.351104-1-pctammela@mojatatu.com/
   - Drop u32 updates

Pedro Tammela (4):
  selftests/tc-testing: cls_fw: add tests for classid
  selftest/tc-testing: cls_route: add tests for classid
  selftest/tc-testing: cls_u32: add tests for classid
  net/sched: cls_route: make netlink errors meaningful

 net/sched/cls_route.c                         | 27 +++++-----
 .../tc-testing/tc-tests/filters/fw.json       | 49 +++++++++++++++++++
 .../tc-testing/tc-tests/filters/route.json    | 25 ++++++++++
 .../tc-testing/tc-tests/filters/u32.json      | 25 ++++++++++
 4 files changed, 114 insertions(+), 12 deletions(-)

Comments

Victor Nogueira Aug. 25, 2023, 9:03 p.m. UTC | #1 
On 25/08/2023 12:51, Pedro Tammela wrote:
> Patches 1-3 add missing tests covering classid behaviour on tdc for cls_fw,
> cls_route and cls_fw. This behaviour was recently fixed by valis[0].
> 
> Patch 4 comes from the development done in the previous patches as it turns out
> cls_route never returns meaningful errors.
> 
> [0] https://lore.kernel.org/all/20230729123202.72406-1-jhs@mojatatu.com/
> 
> v1->v2: https://lore.kernel.org/all/20230818163544.351104-1-pctammela@mojatatu.com/
>     - Drop u32 updates
> 
> Pedro Tammela (4):
>    selftests/tc-testing: cls_fw: add tests for classid
>    selftest/tc-testing: cls_route: add tests for classid
>    selftest/tc-testing: cls_u32: add tests for classid
>    net/sched: cls_route: make netlink errors meaningful
> 
>   net/sched/cls_route.c                         | 27 +++++-----
>   .../tc-testing/tc-tests/filters/fw.json       | 49 +++++++++++++++++++
>   .../tc-testing/tc-tests/filters/route.json    | 25 ++++++++++
>   .../tc-testing/tc-tests/filters/u32.json      | 25 ++++++++++
>   4 files changed, 114 insertions(+), 12 deletions(-)
> 


For the series,

Reviewed-by: Victor Nogueira <victor@mojatatu.com>