| Message ID | 20230824210135.19303-2-posteuca@mutex.one (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: amd: acp: Add sound support for a line of HUAWEI laptops | expand |
On Fri, Aug 25, 2023 at 12:01:32AM +0300, Marian Postevca wrote: > To properly support a line of Huawei laptops with AMD CPU and a > ES8336 codec connected to the ACP3X module we need to enable > the S32 LE format. What's the issue? The AMD code looks like it supports plenty of other formats in most places.
Mark Brown <broonie@kernel.org> writes: >> To properly support a line of Huawei laptops with AMD CPU and a >> ES8336 codec connected to the ACP3X module we need to enable >> the S32 LE format. > > What's the issue? The AMD code looks like it supports plenty of other > formats in most places. In previous version of the machine driver I used a different CPU component than acp-i2s-sp. For that one, I couldn't get it to have sound unless I specifically requested S32 LE format. I removed S32_LE from the CODEC to test if it works and it seems it does work with acp-is2-sp. Format S16_LE is chosen by both components and sound can be heard. I guess this patch is not really needed.
On Sat, Aug 26, 2023 at 12:55:21AM +0300, Marian Postevca wrote: > I removed S32_LE from the CODEC to test if it works and it > seems it does work with acp-is2-sp. Format S16_LE is chosen by > both components and sound can be heard. I guess this patch is > not really needed. If the device supports it it's a good change, it was just the bit about it being a fix that I was querying.
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index a8f347f1affb..09fc0b25f600 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -526,7 +526,7 @@ static int es8316_mute(struct snd_soc_dai *dai, int mute, int direction) } #define ES8316_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \ - SNDRV_PCM_FMTBIT_S24_LE) + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) static const struct snd_soc_dai_ops es8316_ops = { .startup = es8316_pcm_startup,
To properly support a line of Huawei laptops with AMD CPU and a ES8336 codec connected to the ACP3X module we need to enable the S32 LE format. Signed-off-by: Marian Postevca <posteuca@mutex.one> --- sound/soc/codecs/es8316.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)