mbox series

[net-next,00/15] devlink: finish file split and get retire leftover.c

Message ID 20230825085321.178134-1-jiri@resnulli.us (mailing list archive)
Headers show
Series devlink: finish file split and get retire leftover.c | expand

Message

Jiri Pirko Aug. 25, 2023, 8:53 a.m. UTC
From: Jiri Pirko <jiri@nvidia.com>

This patchset finishes a move Jakub started and Moshe continued in the
past. I was planning to do this for a long time, so here it is, finally.

This patchset does not change any behaviour. It just splits leftover.c
into per-object files and do necessary changes, like declaring functions
used from other code, on the way.

The last 3 patches are pushing the rest of the code into appropriate
existing files.

Jiri Pirko (15):
  devlink: push object register/unregister notifications into separate
    helpers
  devlink: push port related code into separate file
  devlink: push shared buffer related code into separate file
  devlink: move and rename devlink_dpipe_send_and_alloc_skb() helper
  devlink: push dpipe related code into separate file
  devlink: push resource related code into separate file
  devlink: push param related code into separate file
  devlink: push region related code into separate file
  devlink: use tracepoint_enabled() helper
  devlink: push trap related code into separate file
  devlink: push rate related code into separate file
  devlink: push linecard related code into separate file
  devlink: move tracepoint definitions into core.c
  devlink: move small_ops definition into netlink.c
  devlink: move devlink_notify_register/unregister() to dev.c

 net/devlink/Makefile        |    3 +-
 net/devlink/core.c          |    6 +
 net/devlink/dev.c           |   28 +-
 net/devlink/devl_internal.h |   95 +-
 net/devlink/dpipe.c         |  917 ++++
 net/devlink/leftover.c      | 9427 -----------------------------------
 net/devlink/linecard.c      |  606 +++
 net/devlink/netlink.c       |  266 +
 net/devlink/param.c         |  865 ++++
 net/devlink/port.c          | 1411 ++++++
 net/devlink/rate.c          |  722 +++
 net/devlink/region.c        | 1260 +++++
 net/devlink/resource.c      |  579 +++
 net/devlink/sb.c            |  996 ++++
 net/devlink/trap.c          | 1861 +++++++
 15 files changed, 9606 insertions(+), 9436 deletions(-)
 create mode 100644 net/devlink/dpipe.c
 delete mode 100644 net/devlink/leftover.c
 create mode 100644 net/devlink/linecard.c
 create mode 100644 net/devlink/param.c
 create mode 100644 net/devlink/port.c
 create mode 100644 net/devlink/rate.c
 create mode 100644 net/devlink/region.c
 create mode 100644 net/devlink/resource.c
 create mode 100644 net/devlink/sb.c
 create mode 100644 net/devlink/trap.c

Comments

Jakub Kicinski Aug. 26, 2023, 2:03 a.m. UTC | #1
On Fri, 25 Aug 2023 10:53:06 +0200 Jiri Pirko wrote:
> This patchset finishes a move Jakub started and Moshe continued in the
> past. I was planning to do this for a long time, so here it is, finally.
> 
> This patchset does not change any behaviour. It just splits leftover.c
> into per-object files and do necessary changes, like declaring functions
> used from other code, on the way.
> 
> The last 3 patches are pushing the rest of the code into appropriate
> existing files.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Nice!
Jakub Kicinski Aug. 28, 2023, 12:16 a.m. UTC | #2
On Fri, 25 Aug 2023 10:53:06 +0200 Jiri Pirko wrote:
> This patchset finishes a move Jakub started and Moshe continued in the
> past. I was planning to do this for a long time, so here it is, finally.
> 
> This patchset does not change any behaviour. It just splits leftover.c
> into per-object files and do necessary changes, like declaring functions
> used from other code, on the way.
> 
> The last 3 patches are pushing the rest of the code into appropriate
> existing files.

Conflicts with Saeed's series, could you respin?
Jiri Pirko Aug. 28, 2023, 5:59 a.m. UTC | #3
Mon, Aug 28, 2023 at 02:16:43AM CEST, kuba@kernel.org wrote:
>On Fri, 25 Aug 2023 10:53:06 +0200 Jiri Pirko wrote:
>> This patchset finishes a move Jakub started and Moshe continued in the
>> past. I was planning to do this for a long time, so here it is, finally.
>> 
>> This patchset does not change any behaviour. It just splits leftover.c
>> into per-object files and do necessary changes, like declaring functions
>> used from other code, on the way.
>> 
>> The last 3 patches are pushing the rest of the code into appropriate
>> existing files.
>
>Conflicts with Saeed's series, could you respin?

Sure. I'm on it.