| Message ID | 20230825122756.7603-1-donald.hunter@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | tools/net/ynl: Add support for netlink-raw families | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 25 Aug 2023 13:27:43 +0100 you wrote: > This patchset adds support for netlink-raw families such as rtnetlink. > > Patch 1 fixes a typo in existing schemas > Patch 2 contains the schema definition > Patches 3 & 4 update the schema documentation > Patches 5 - 9 extends ynl > Patches 10 - 12 add several netlink-raw specs > > [...] Here is the summary with links: - [net-next,v6,01/12] doc/netlink: Fix typo in genetlink-* schemas https://git.kernel.org/netdev/net-next/c/c4e1ab07b557 - [net-next,v6,02/12] doc/netlink: Add a schema for netlink-raw families https://git.kernel.org/netdev/net-next/c/ed68c58c0eb4 - [net-next,v6,03/12] doc/netlink: Update genetlink-legacy documentation https://git.kernel.org/netdev/net-next/c/294f37fc8772 - [net-next,v6,04/12] doc/netlink: Document the netlink-raw schema extensions https://git.kernel.org/netdev/net-next/c/2db8abf0b455 - [net-next,v6,05/12] tools/ynl: Add mcast-group schema parsing to ynl https://git.kernel.org/netdev/net-next/c/88901b967958 - [net-next,v6,06/12] tools/net/ynl: Fix extack parsing with fixed header genlmsg https://git.kernel.org/netdev/net-next/c/fb0a06d455d6 - [net-next,v6,07/12] tools/net/ynl: Add support for netlink-raw families https://git.kernel.org/netdev/net-next/c/e46dd903efe3 - [net-next,v6,08/12] tools/net/ynl: Implement nlattr array-nest decoding in ynl https://git.kernel.org/netdev/net-next/c/0493e56d021d - [net-next,v6,09/12] tools/net/ynl: Add support for create flags https://git.kernel.org/netdev/net-next/c/1768d8a767f8 - [net-next,v6,10/12] doc/netlink: Add spec for rt addr messages https://git.kernel.org/netdev/net-next/c/dfb0f7d9d979 - [net-next,v6,11/12] doc/netlink: Add spec for rt link messages https://git.kernel.org/netdev/net-next/c/b2f63d904e72 - [net-next,v6,12/12] doc/netlink: Add spec for rt route messages https://git.kernel.org/netdev/net-next/c/023289b4f582 You are awesome, thank you!
This patchset adds support for netlink-raw families such as rtnetlink. Patch 1 fixes a typo in existing schemas Patch 2 contains the schema definition Patches 3 & 4 update the schema documentation Patches 5 - 9 extends ynl Patches 10 - 12 add several netlink-raw specs The netlink-raw schema is very similar to genetlink-legacy and I thought about making the changes there and symlinking to it. On balance I thought that might be problematic for accurate schema validation. rtnetlink doesn't seem to fit into unified or directional message enumeration models. It seems like an 'explicit' model would be useful, to force the schema author to specify the message ids directly. There is not yet support for notifications because ynl currently doesn't support defining 'event' properties on a 'do' operation. The message ids are shared so ops need to be both sync and async. I plan to look at this in a future patch. The link and route messages contain different nested attributes dependent on the type of link or route. Decoding these will need some kind of attr-space selection that uses the value of another attribute as the selector key. These nested attributes have been left with type 'binary' for now. v5 -> v6: - Remove explicit value definitions from link-attrs in rt_link.yaml v4 -> v5: - Fix schema id in netlink-raw schema - Remove doc references to genetlink from netlink-raw schema - Add missing whitespace between classes in ynl.py v3 -> v4: - Fix incorrect var name in handle_ntf - Update rt_link spec to include operation attributes - Update rt_route spec to refine operation attributes v2 -> v3: - Fix typo in existing schemas - Rework fixed_header code to fix extack parsing - Add support for CREATE, EXCL, REPLACE and APPEND, needed by rt_route v1 -> v2: - Put mcast-group changes in separate patch - Put decode_fixed_header refactoring in separate patch - Avoid refactoring decode_enum - Rename NetlinkProtocolFamily -> NetlinkProtocol and GenlProtocolFamily -> GenlProtocol and store in self.nlproto - Add spec for rt link. Donald Hunter (12): doc/netlink: Fix typo in genetlink-* schemas doc/netlink: Add a schema for netlink-raw families doc/netlink: Update genetlink-legacy documentation doc/netlink: Document the netlink-raw schema extensions tools/ynl: Add mcast-group schema parsing to ynl tools/net/ynl: Fix extack parsing with fixed header genlmsg tools/net/ynl: Add support for netlink-raw families tools/net/ynl: Implement nlattr array-nest decoding in ynl tools/net/ynl: Add support for create flags doc/netlink: Add spec for rt addr messages doc/netlink: Add spec for rt link messages doc/netlink: Add spec for rt route messages Documentation/core-api/netlink.rst | 9 +- Documentation/netlink/genetlink-c.yaml | 2 +- Documentation/netlink/genetlink-legacy.yaml | 2 +- Documentation/netlink/netlink-raw.yaml | 410 +++++ Documentation/netlink/specs/rt_addr.yaml | 179 +++ Documentation/netlink/specs/rt_link.yaml | 1432 +++++++++++++++++ Documentation/netlink/specs/rt_route.yaml | 327 ++++ .../netlink/genetlink-legacy.rst | 26 +- Documentation/userspace-api/netlink/index.rst | 1 + .../userspace-api/netlink/netlink-raw.rst | 58 + Documentation/userspace-api/netlink/specs.rst | 13 + tools/net/ynl/cli.py | 12 +- tools/net/ynl/lib/__init__.py | 4 +- tools/net/ynl/lib/nlspec.py | 31 + tools/net/ynl/lib/ynl.py | 198 ++- 15 files changed, 2632 insertions(+), 72 deletions(-) create mode 100644 Documentation/netlink/netlink-raw.yaml create mode 100644 Documentation/netlink/specs/rt_addr.yaml create mode 100644 Documentation/netlink/specs/rt_link.yaml create mode 100644 Documentation/netlink/specs/rt_route.yaml create mode 100644 Documentation/userspace-api/netlink/netlink-raw.rst