| Message ID | 20230815133831.3537-1-e.orlova@ispras.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | smb: propagate error code of extract_sharename() | expand |
Merged into cifs-2.6.git for-next On 8/15/23 08:38, Katya Orlova wrote: > In addition to the EINVAL, there may be an ENOMEM. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 70431bfd825d ("cifs: Support fscache indexing rewrite") > Signed-off-by: Katya Orlova <e.orlova@ispras.ru> > --- > fs/smb/client/fscache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/smb/client/fscache.c b/fs/smb/client/fscache.c > index 8f6909d633da..34e20c4cd507 100644 > --- a/fs/smb/client/fscache.c > +++ b/fs/smb/client/fscache.c > @@ -48,7 +48,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon) > sharename = extract_sharename(tcon->tree_name); > if (IS_ERR(sharename)) { > cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__); > - return -EINVAL; > + return PTR_ERR(sharename); > } > > slen = strlen(sharename);
diff --git a/fs/smb/client/fscache.c b/fs/smb/client/fscache.c index 8f6909d633da..34e20c4cd507 100644 --- a/fs/smb/client/fscache.c +++ b/fs/smb/client/fscache.c @@ -48,7 +48,7 @@ int cifs_fscache_get_super_cookie(struct cifs_tcon *tcon) sharename = extract_sharename(tcon->tree_name); if (IS_ERR(sharename)) { cifs_dbg(FYI, "%s: couldn't extract sharename\n", __func__); - return -EINVAL; + return PTR_ERR(sharename); } slen = strlen(sharename);
In addition to the EINVAL, there may be an ENOMEM. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 70431bfd825d ("cifs: Support fscache indexing rewrite") Signed-off-by: Katya Orlova <e.orlova@ispras.ru> --- fs/smb/client/fscache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)