| Message ID | 20230828150148.120031-1-clg@kaod.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kconfig: Add NVME to s390x machines | expand |
On 28/08/2023 17.01, Cédric Le Goater wrote: > From: Cédric Le Goater <clg@redhat.com> > > We recently had issues with nvme devices on big endian platforms. > Include their compilation on s390x to ease tests. > > Signed-off-by: Cédric Le Goater <clg@redhat.com> > --- > hw/nvme/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig > index 8ac90942e55e..cfa2ab0f9d5a 100644 > --- a/hw/nvme/Kconfig > +++ b/hw/nvme/Kconfig > @@ -1,4 +1,4 @@ > config NVME_PCI > bool > - default y if PCI_DEVICES > + default y if PCI_DEVICES || PCIE_DEVICES > depends on PCI hw/nvme/ctrl.c uses INTERFACE_PCIE_DEVICE, so I think looks right to me. Reviewed-by: Thomas Huth <thuth@redhat.com>
On Aug 28 17:01, Cédric Le Goater wrote: > From: Cédric Le Goater <clg@redhat.com> > > We recently had issues with nvme devices on big endian platforms. > Include their compilation on s390x to ease tests. > > Signed-off-by: Cédric Le Goater <clg@redhat.com> > --- > hw/nvme/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig > index 8ac90942e55e..cfa2ab0f9d5a 100644 > --- a/hw/nvme/Kconfig > +++ b/hw/nvme/Kconfig > @@ -1,4 +1,4 @@ > config NVME_PCI > bool > - default y if PCI_DEVICES > + default y if PCI_DEVICES || PCIE_DEVICES > depends on PCI > -- > 2.41.0 > Acked-by: Klaus Jensen <k.jensen@samsung.com>
diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig index 8ac90942e55e..cfa2ab0f9d5a 100644 --- a/hw/nvme/Kconfig +++ b/hw/nvme/Kconfig @@ -1,4 +1,4 @@ config NVME_PCI bool - default y if PCI_DEVICES + default y if PCI_DEVICES || PCIE_DEVICES depends on PCI