diff mbox series

[1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

Message ID 20230829110115.3442-2-christian.koenig@amd.com (mailing list archive)
State New, archived
Headers show
Series [1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2 | expand

Commit Message

Christian König Aug. 29, 2023, 11:01 a.m. UTC 
We want to remove per minor debugfs directories. Start by stopping
drivers from adding anything inside of those in the mid layer callback.

v2: drop it for the accel node as well

Signed-off-by: Christian König <christian.koenig@amd.com>
Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
 drivers/accel/drm_accel.c     | 3 ---
 drivers/gpu/drm/drm_debugfs.c | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

Comments

Andi Shyti Aug. 30, 2023, 8:19 a.m. UTC | #1 
Hi Christian,

On Tue, Aug 29, 2023 at 01:01:11PM +0200, Christian König wrote:
> We want to remove per minor debugfs directories. Start by stopping
> drivers from adding anything inside of those in the mid layer callback.
> 
> v2: drop it for the accel node as well
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> 

Thanks,
Andi
Christian König Aug. 30, 2023, 2:22 p.m. UTC | #2 
Am 30.08.23 um 10:19 schrieb Andi Shyti:
> Hi Christian,
>
> On Tue, Aug 29, 2023 at 01:01:11PM +0200, Christian König wrote:
>> We want to remove per minor debugfs directories. Start by stopping
>> drivers from adding anything inside of those in the mid layer callback.
>>
>> v2: drop it for the accel node as well
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Is that for just this patch or the whole series?

Thanks,
Christian.

>
> Thanks,
> Andi
Tomer Tayar Sept. 1, 2023, 8 a.m. UTC | #3 
Hi Christian,

On 29/08/2023 14:01, Christian König wrote:
> We want to remove per minor debugfs directories. Start by stopping
> drivers from adding anything inside of those in the mid layer callback.
>
> v2: drop it for the accel node as well
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> ---

For the whole series:
Reviewed-by: Tomer Tayar <ttayar@habana.ai>

And at least "accel-wise":
Tested-by: Tomer Tayar <ttayar@habana.ai>

Thanks,
Tomer
diff mbox series

Patch

diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
index 4a9baf02439e..01edf2c00b5a 100644
--- a/drivers/accel/drm_accel.c
+++ b/drivers/accel/drm_accel.c
@@ -99,9 +99,6 @@  void accel_debugfs_init(struct drm_minor *minor, int minor_id)
 
 	drm_debugfs_create_files(accel_debugfs_list, ACCEL_DEBUGFS_ENTRIES,
 				 minor->debugfs_root, minor);
-
-	if (dev->driver->debugfs_init)
-		dev->driver->debugfs_init(minor);
 }
 
 /**
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index 2de43ff3ce0a..d90d0827bfad 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -284,7 +284,7 @@  int drm_debugfs_init(struct drm_minor *minor, int minor_id,
 		drm_client_debugfs_init(minor);
 	}
 
-	if (dev->driver->debugfs_init)
+	if (dev->driver->debugfs_init && dev->render != minor)
 		dev->driver->debugfs_init(minor);
 
 	list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) {