| Message ID | 20230830151615.3012325-1-bryan.odonoghue@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: qcom: camss: Bugfix series | expand |
On 30/08/2023 16:16, Bryan O'Donoghue wrote: > V3: > - Adds Reviewed-by where indicated - Laurent > - Adds a new patch for genpd cleanup. TBH I completely missed this so thanks ! - Laurent > - "media: qcom: camss: Fix V4L2 async notifier error path" stays the same fixes spalt in -next > Fixes: 51397a4ec75d ("media: qcom: Initialise V4L2 async notifier later") > - I like the suggesting of using a common fix for vfe-17x and vfe-480 however, I believe > we need to support multiple write-master/RDI => VCs in 17x which currently we only do > in vfe-480 so sharing the code between the two here right now, is n't possible. > - Included other suggestions on vfe-17x and vfe-480 - Laurent > - I didn't change the val |= 1 << CSI2_RX_CFG1_VC_MODE to BIT(2) > The reason for that is all of the code uses this odd bit-shifting and I'd rather do > the conversion from shifting to BIT(x) as a distinct series instead of piecemeal - bod Pardon me I forgot to add a link to a tree for this series Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commits/c13bb323d4f081d634dca3a9f3f56fbee370e8f4 --- bod
Hi Bryan, I wanted to let you know that I will likely not be able to review this v3 in a timely manner. v2 was quite fine overall, I trust that you've taken my review comments into account in this new version. Maybe someone else could give it another look, in order to get it merged in v6.7 ? On Wed, Aug 30, 2023 at 04:16:05PM +0100, Bryan O'Donoghue wrote: > V3: > - Adds Reviewed-by where indicated - Laurent > - Adds a new patch for genpd cleanup. TBH I completely missed this so thanks ! - Laurent > - "media: qcom: camss: Fix V4L2 async notifier error path" stays the same fixes spalt in -next > Fixes: 51397a4ec75d ("media: qcom: Initialise V4L2 async notifier later") > - I like the suggesting of using a common fix for vfe-17x and vfe-480 however, I believe > we need to support multiple write-master/RDI => VCs in 17x which currently we only do > in vfe-480 so sharing the code between the two here right now, is n't possible. > - Included other suggestions on vfe-17x and vfe-480 - Laurent > - I didn't change the val |= 1 << CSI2_RX_CFG1_VC_MODE to BIT(2) > The reason for that is all of the code uses this odd bit-shifting and I'd rather do > the conversion from shifting to BIT(x) as a distinct series instead of piecemeal - bod > > V2: > - Amends commit log for TPG fix to cover dropping of fixed > VC when setting up a TPG - Konrad > > - Leaves GENMASK etc out. I'm happy to do a "make it pretty" > series later on. - bod > > Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commits/Bugfix-series-v2?ref_type=tags > > V1: > - Drops dt_id = vc * 4 in favour of a patch in a later series - Hans > Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/d4c382c5d6ee153b410a01e172b3e811011d0b14 > - Adds Konrad's Acked-by as indicated > > V0: > This series covers a number of Fixes: all of which are for application to > stable as well as -next with the exception of the second patch which is a > fix for a SHA that is still in -next. > > Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-23-08-07-db410c-rb3-camss-dts-v3 > > This series is part of a larger set of fixes, improvements developed/found > when adding a new SoC. > > Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/lenovo-x13s-v6.5-rc4-x13s-camss-patches > > First pass on that larger series is to get all of the current Fixes: in the > branch out. > > Andrey Konovalov (1): > media: qcom: camss: Fix csid-gen2 for test pattern generator > > Bryan O'Donoghue (9): > media: qcom: camss: Fix pm_domain_on sequence in probe > media: qcom: camss: Fix V4L2 async notifier error path > media: qcom: camss: Fix genpd cleanup > media: qcom: camss: Fix vfe_get() error jump > media: qcom: camss: Fix VFE-17x vfe_disable_output() > media: qcom: camss: Fix VFE-480 vfe_disable_output() > media: qcom: camss: Fix missing vfe_lite clocks check > media: qcom: camss: Fix invalid clock enable bit disjunction > media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater > than 3 > > .../platform/qcom/camss/camss-csid-gen2.c | 11 ++-- > .../qcom/camss/camss-csiphy-3ph-1-0.c | 2 +- > .../media/platform/qcom/camss/camss-vfe-170.c | 22 +------- > .../media/platform/qcom/camss/camss-vfe-480.c | 22 +------- > drivers/media/platform/qcom/camss/camss-vfe.c | 5 +- > drivers/media/platform/qcom/camss/camss.c | 55 +++++++++++-------- > 6 files changed, 46 insertions(+), 71 deletions(-)
V3: - Adds Reviewed-by where indicated - Laurent - Adds a new patch for genpd cleanup. TBH I completely missed this so thanks ! - Laurent - "media: qcom: camss: Fix V4L2 async notifier error path" stays the same fixes spalt in -next Fixes: 51397a4ec75d ("media: qcom: Initialise V4L2 async notifier later") - I like the suggesting of using a common fix for vfe-17x and vfe-480 however, I believe we need to support multiple write-master/RDI => VCs in 17x which currently we only do in vfe-480 so sharing the code between the two here right now, is n't possible. - Included other suggestions on vfe-17x and vfe-480 - Laurent - I didn't change the val |= 1 << CSI2_RX_CFG1_VC_MODE to BIT(2) The reason for that is all of the code uses this odd bit-shifting and I'd rather do the conversion from shifting to BIT(x) as a distinct series instead of piecemeal - bod V2: - Amends commit log for TPG fix to cover dropping of fixed VC when setting up a TPG - Konrad - Leaves GENMASK etc out. I'm happy to do a "make it pretty" series later on. - bod Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commits/Bugfix-series-v2?ref_type=tags V1: - Drops dt_id = vc * 4 in favour of a patch in a later series - Hans Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/d4c382c5d6ee153b410a01e172b3e811011d0b14 - Adds Konrad's Acked-by as indicated V0: This series covers a number of Fixes: all of which are for application to stable as well as -next with the exception of the second patch which is a fix for a SHA that is still in -next. Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-23-08-07-db410c-rb3-camss-dts-v3 This series is part of a larger set of fixes, improvements developed/found when adding a new SoC. Link: https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/lenovo-x13s-v6.5-rc4-x13s-camss-patches First pass on that larger series is to get all of the current Fixes: in the branch out. Andrey Konovalov (1): media: qcom: camss: Fix csid-gen2 for test pattern generator Bryan O'Donoghue (9): media: qcom: camss: Fix pm_domain_on sequence in probe media: qcom: camss: Fix V4L2 async notifier error path media: qcom: camss: Fix genpd cleanup media: qcom: camss: Fix vfe_get() error jump media: qcom: camss: Fix VFE-17x vfe_disable_output() media: qcom: camss: Fix VFE-480 vfe_disable_output() media: qcom: camss: Fix missing vfe_lite clocks check media: qcom: camss: Fix invalid clock enable bit disjunction media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3 .../platform/qcom/camss/camss-csid-gen2.c | 11 ++-- .../qcom/camss/camss-csiphy-3ph-1-0.c | 2 +- .../media/platform/qcom/camss/camss-vfe-170.c | 22 +------- .../media/platform/qcom/camss/camss-vfe-480.c | 22 +------- drivers/media/platform/qcom/camss/camss-vfe.c | 5 +- drivers/media/platform/qcom/camss/camss.c | 55 +++++++++++-------- 6 files changed, 46 insertions(+), 71 deletions(-)