| Message ID | 20230829054623.104293-4-alexhenrie24@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are in the valid range | expand |
On Mon, 28 Aug 2023 23:44:45 -0600 Alex Henrie wrote: > If the preferred lifetime was less than the minimum required lifetime, > ipv6_create_tempaddr would error out without creating any new address. > On my machine and network, this error happened immediately with the > preferred lifetime set to 1 second, after a few minutes with the > preferred lifetime set to 4 seconds, and not at all with the preferred > lifetime set to 5 seconds. During my investigation, I found a Stack > Exchange post from another person who seems to have had the same > problem: They stopped getting new addresses if they lowered the > preferred lifetime below 3 seconds, and they didn't really know why. > > The preferred lifetime is a preference, not a hard requirement. The > kernel does not strictly forbid new connections on a deprecated address, > nor does it guarantee that the address will be disposed of the instant > its total valid lifetime expires. So rather than disable IPv6 privacy > extensions altogether if the minimum required lifetime swells above the > preferred lifetime, it is more in keeping with the user's intent to > increase the temporary address's lifetime to the minimum necessary for > the current network conditions. > > With these fixes, setting the preferred lifetime to 3 or 4 seconds "just > works" because the extra fraction of a second is practically > unnoticeable. It's even possible to reduce the time before deprecation > to 1 or 2 seconds by also disabling duplicate address detection (setting > /proc/sys/net/ipv6/conf/*/dad_transmits to 0). I realize that that is a > pretty niche use case, but I know at least one person who would gladly > sacrifice performance and convenience to be sure that they are getting > the maximum possible level of privacy. Not entirely sure what the best way to handle this is. And whether the patch should be treated as a Fix or "general improvement" - meaning - whether we should try to backport this :( > Link: https://serverfault.com/a/1031168/310447 > Fixes: eac55bf97094 (IPv6: do not create temporary adresses with too short preferred lifetime, 2008-04-02) Thanks for adding the Fixes tag - you're missing the quotes inside the parenthesis: Fixes: eac55bf97094 ("IPv6: do not create temporary adresses with too short preferred lifetime, 2008-04-02") The exact format is important since people may script around it. Since we haven't heard back from Paolo or David on v2 could you repost with that fixed?
On Wed, Aug 30, 2023 at 7:28 PM Jakub Kicinski <kuba@kernel.org> wrote: > > On Mon, 28 Aug 2023 23:44:45 -0600 Alex Henrie wrote: > > If the preferred lifetime was less than the minimum required lifetime, > > ipv6_create_tempaddr would error out without creating any new address. > > On my machine and network, this error happened immediately with the > > preferred lifetime set to 1 second, after a few minutes with the > > preferred lifetime set to 4 seconds, and not at all with the preferred > > lifetime set to 5 seconds. During my investigation, I found a Stack > > Exchange post from another person who seems to have had the same > > problem: They stopped getting new addresses if they lowered the > > preferred lifetime below 3 seconds, and they didn't really know why. > > > > The preferred lifetime is a preference, not a hard requirement. The > > kernel does not strictly forbid new connections on a deprecated address, > > nor does it guarantee that the address will be disposed of the instant > > its total valid lifetime expires. So rather than disable IPv6 privacy > > extensions altogether if the minimum required lifetime swells above the > > preferred lifetime, it is more in keeping with the user's intent to > > increase the temporary address's lifetime to the minimum necessary for > > the current network conditions. > > > > With these fixes, setting the preferred lifetime to 3 or 4 seconds "just > > works" because the extra fraction of a second is practically > > unnoticeable. It's even possible to reduce the time before deprecation > > to 1 or 2 seconds by also disabling duplicate address detection (setting > > /proc/sys/net/ipv6/conf/*/dad_transmits to 0). I realize that that is a > > pretty niche use case, but I know at least one person who would gladly > > sacrifice performance and convenience to be sure that they are getting > > the maximum possible level of privacy. > > Not entirely sure what the best way to handle this is. > And whether the patch should be treated as a Fix or "general > improvement" - meaning - whether we should try to backport this :( I'm not exactly a subject matter expert here, but for what it's worth, I think it's important but not important enough to backport. (I would definitely like to backport the integer underflow fix though.) I'd love to get more people to test these patches and to hear more from the original authors. > > Link: https://serverfault.com/a/1031168/310447 > > Fixes: eac55bf97094 (IPv6: do not create temporary adresses with too short preferred lifetime, 2008-04-02) > > Thanks for adding the Fixes tag - you're missing the quotes inside > the parenthesis: > > Fixes: eac55bf97094 ("IPv6: do not create temporary adresses with too short preferred lifetime, 2008-04-02") > > The exact format is important since people may script around it. > Since we haven't heard back from Paolo or David on v2 could you repost > with that fixed? Sorry, I should have looked at the examples more closely instead of assuming that they were the same as `git log --format=ref`. I will send a v3 with the Fixes tags in the conventional Linux kernel format. Thanks for the feedback, -Alex
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 561c6266040a..05c22dac32e6 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1395,15 +1395,23 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) write_unlock_bh(&idev->lock); - /* A temporary address is created only if this calculated Preferred - * Lifetime is greater than REGEN_ADVANCE time units. In particular, - * an implementation must not create a temporary address with a zero - * Preferred Lifetime. + /* From RFC 4941: + * + * A temporary address is created only if this calculated Preferred + * Lifetime is greater than REGEN_ADVANCE time units. In + * particular, an implementation must not create a temporary address + * with a zero Preferred Lifetime. + * + * Clamp the preferred lifetime to a minimum of regen_advance, unless + * that would exceed valid_lft. + * * Use age calculation as in addrconf_verify to avoid unnecessary * temporary addresses being generated. */ age = (now - tmp_tstamp + ADDRCONF_TIMER_FUZZ_MINUS) / HZ; - if (cfg.preferred_lft <= regen_advance + age) { + if (cfg.preferred_lft <= regen_advance + age) + cfg.preferred_lft = regen_advance + age + 1; + if (cfg.preferred_lft > cfg.valid_lft) { in6_ifa_put(ifp); in6_dev_put(idev); ret = -1;
If the preferred lifetime was less than the minimum required lifetime, ipv6_create_tempaddr would error out without creating any new address. On my machine and network, this error happened immediately with the preferred lifetime set to 1 second, after a few minutes with the preferred lifetime set to 4 seconds, and not at all with the preferred lifetime set to 5 seconds. During my investigation, I found a Stack Exchange post from another person who seems to have had the same problem: They stopped getting new addresses if they lowered the preferred lifetime below 3 seconds, and they didn't really know why. The preferred lifetime is a preference, not a hard requirement. The kernel does not strictly forbid new connections on a deprecated address, nor does it guarantee that the address will be disposed of the instant its total valid lifetime expires. So rather than disable IPv6 privacy extensions altogether if the minimum required lifetime swells above the preferred lifetime, it is more in keeping with the user's intent to increase the temporary address's lifetime to the minimum necessary for the current network conditions. With these fixes, setting the preferred lifetime to 3 or 4 seconds "just works" because the extra fraction of a second is practically unnoticeable. It's even possible to reduce the time before deprecation to 1 or 2 seconds by also disabling duplicate address detection (setting /proc/sys/net/ipv6/conf/*/dad_transmits to 0). I realize that that is a pretty niche use case, but I know at least one person who would gladly sacrifice performance and convenience to be sure that they are getting the maximum possible level of privacy. Link: https://serverfault.com/a/1031168/310447 Fixes: eac55bf97094 (IPv6: do not create temporary adresses with too short preferred lifetime, 2008-04-02) Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> --- net/ipv6/addrconf.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-)