diff mbox series

qla2xxx: fix nvme_fc_rcv_ls_req undefined error

Message ID 20230824151521.35261-1-njavali@marvell.com (mailing list archive)
State Accepted
Headers show
Series qla2xxx: fix nvme_fc_rcv_ls_req undefined error | expand

Commit Message

Nilesh Javali Aug. 24, 2023, 3:15 p.m. UTC 
The kernel robot reported below build error,

>> ERROR: modpost: "nvme_fc_rcv_ls_req" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!

Use CONFIG_NVME_FC enabled check to fix the build error.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308021445.txlNq7UC-lkp@intel.com/
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_nvme.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen Aug. 25, 2023, 1:22 a.m. UTC | #1 
Nilesh,

> The kernel robot reported below build error,
>
>>> ERROR: modpost: "nvme_fc_rcv_ls_req" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
>
> Use CONFIG_NVME_FC enabled check to fix the build error.

Applied to 6.6/scsi-staging, thanks!
Martin K. Petersen Aug. 31, 2023, 1:48 a.m. UTC | #2 
On Thu, 24 Aug 2023 20:45:21 +0530, Nilesh Javali wrote:

> The kernel robot reported below build error,
> 
> >> ERROR: modpost: "nvme_fc_rcv_ls_req" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined!
> 
> Use CONFIG_NVME_FC enabled check to fix the build error.
> 
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/1] qla2xxx: fix nvme_fc_rcv_ls_req undefined error
      https://git.kernel.org/mkp/scsi/c/27177862de96
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 1a31e877e6cb..62a67662cbf3 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -1182,10 +1182,12 @@  qla2xxx_process_purls_pkt(struct scsi_qla_host *vha, struct purex_item *item)
 	struct qla_nvme_unsol_ctx *uctx = item->purls_context;
 	fc_port_t *fcport = uctx->fcport;
 	struct qla_nvme_lsrjt_pt_arg a;
-	int ret;
+	int ret = 1;
 
+#if (IS_ENABLED(CONFIG_NVME_FC))
 	ret = nvme_fc_rcv_ls_req(fcport->nvme_remote_port, &uctx->lsrsp,
 				 &item->iocb, item->size);
+#endif
 	if (ret) {
 		ql_dbg(ql_dbg_unsol, vha, 0x2125, "NVMe tranport ls_req failed\n");
 		memset((void *)&a, 0, sizeof(a));