[v2,0/8] smartpqi updates

Message

Don Brace Aug. 24, 2023, 3:58 p.m. UTC

cat smartpqi_6.6_cover_letter
These patches are based on Martin Petersen's 6.6/scsi-queue tree
  https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
  6.6/scsi-queue

The biggest functional change to smartpqi is the addition of an abort
handler. Some customers were complaining about I/O stalls to all devices
when only one device is reset. Adding an abort handler helps to prevent
I/O stalls to all devices.

All of the reset of the patches are small changes to logging messages,
MACRO and variable name changes, and one minor change for LUN assignments.

This set of changes consists of:
* smartpqi-add-abort-handler
  When a device reset occurs, the SML pauses I/O to all devices presented
  by a controller instance causing some performance issues.
  To only affect device with a problematic request, we added an abort handler.
  The abort handler is implemented by using a device reset, but I/O to the
  other devices is no longer affected.
* smartpqi-refactor-rename-MACRO-to-clarify-purpose
  The MACRO SOP_RC_INCORRECT_LOGICAL_UNIT was used to check for a condition 
  where a TMF was sent an incorrect LUN. We renamed this MACRO to
  SOP_TMF_INCORRECT_LOGICAL_UNIT for clarity.
* smartpqi-refactor-rename-pciinfo-to-pci_info
  Change the pciinfo variable to pci_info to make more readable code.
  No functional changes.
* smartpqi-simplify-lun_number-assignment
  We simplified the conditional expression used to populate LUN numbers
  for requests.
* smartpqi-enhance-shutdown-notification
  Clarify controller cache flush errors. We added in more precise information
  to the cache flush informational message.
  No functional changes.
* smartpqi-enhance-controller-offline-notification
  The driver can offline a controller for multiple reasons. We added
  a description of why these rare offline actions are taken. And a function
  to provide the specific details of the shutdown.
* smartpqi-enhance-error-messages
  We added host:bus:target:lun to messages emitted in our reset/abort handlers.
  No functional changes.
* smartpqi-change-driver-version-to-2.1.24-046

Changes since v1:
Removed patch smartpqi-reformat-to-align-with-oob-driver based on a review by:
"Martin K. Petersen" <[e-mail]>
Link: https://lore.kernel.org/all/[e-mail]/

David Strahan (3):
  smartpqi: simplify lun_number assignment
  smartpqi: enhance shutdown notification
  smartpqi: enhance controller offline notification

Don Brace (1):
  smartpqi: change driver version to 2.1.24-046

Kevin Barnett (3):
  smartpqi: add abort handler
  smartpqi: refactor rename MACRO to clarify purpose
  smartpqi: refactor rename pciinfo to pci_info

Mahesh Rajashekhara (1):
  smartpqi: enhance error messages

 drivers/scsi/smartpqi/smartpqi.h      |  16 +-
 drivers/scsi/smartpqi/smartpqi_init.c | 254 ++++++++++++++++++++------
 2 files changed, 215 insertions(+), 55 deletions(-)

Comments

Martin K. Petersen Aug. 25, 2023, 2:59 a.m. UTC | #1

Don,

> The biggest functional change to smartpqi is the addition of an abort
> handler. Some customers were complaining about I/O stalls to all
> devices when only one device is reset. Adding an abort handler helps
> to prevent I/O stalls to all devices.

Applied to 6.6/scsi-staging, thanks!

Martin K. Petersen Aug. 31, 2023, 1:48 a.m. UTC | #2

On Thu, 24 Aug 2023 10:58:04 -0500, Don Brace wrote:

> cat smartpqi_6.6_cover_letter
> These patches are based on Martin Petersen's 6.6/scsi-queue tree
>   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>   6.6/scsi-queue
> 
> The biggest functional change to smartpqi is the addition of an abort
> handler. Some customers were complaining about I/O stalls to all devices
> when only one device is reset. Adding an abort handler helps to prevent
> I/O stalls to all devices.
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/8] smartpqi: add abort handler
      https://git.kernel.org/mkp/scsi/c/153c45dd63ef
[2/8] smartpqi: refactor rename MACRO to clarify purpose
      https://git.kernel.org/mkp/scsi/c/43cf3a6eab58
[3/8] smartpqi: refactor rename pciinfo to pci_info
      https://git.kernel.org/mkp/scsi/c/e9c39117b448
[4/8] smartpqi: simplify lun_number assignment
      https://git.kernel.org/mkp/scsi/c/dad662c9fe50
[5/8] smartpqi: enhance shutdown notification
      https://git.kernel.org/mkp/scsi/c/276395d024cc
[6/8] smartpqi: enhance controller offline notification
      https://git.kernel.org/mkp/scsi/c/72b737fa73bf
[7/8] smartpqi: enhance error messages
      https://git.kernel.org/mkp/scsi/c/e1b919494aa9
[8/8] smartpqi: change driver version to 2.1.24-046
      https://git.kernel.org/mkp/scsi/c/08b7ad50c8bc