| Message ID | 20230831093252.2461282-7-ray.huang@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support blob memory and venus on qemu | expand |
On 31/8/23 11:32, Huang Rui wrote: > Configure context init feature flag for virglrenderer. > > Originally-by: Antonio Caggiano <antonio.caggiano@collabora.com> > Signed-off-by: Huang Rui <ray.huang@amd.com> > --- > > New patch, result of splitting > [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature > > meson.build | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meson.build b/meson.build > index 98e68ef0b1..ff20d3c249 100644 > --- a/meson.build > +++ b/meson.build > @@ -1068,6 +1068,10 @@ if not get_option('virglrenderer').auto() or have_system or have_vhost_user_gpu > prefix: '#include <virglrenderer.h>', > dependencies: virgl)) > endif > + config_host_data.set('HAVE_VIRGL_CONTEXT_INIT', > + cc.has_function('virgl_renderer_context_create_with_flags', > + prefix: '#include <virglrenderer.h>', > + dependencies: virgl)) Shouldn't this be inverted with previous patch?
On Thu, Aug 31, 2023 at 05:39:38PM +0800, Philippe Mathieu-Daudé wrote: > On 31/8/23 11:32, Huang Rui wrote: > > Configure context init feature flag for virglrenderer. > > > > Originally-by: Antonio Caggiano <antonio.caggiano@collabora.com> > > Signed-off-by: Huang Rui <ray.huang@amd.com> > > --- > > > > New patch, result of splitting > > [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature > > > > meson.build | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/meson.build b/meson.build > > index 98e68ef0b1..ff20d3c249 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -1068,6 +1068,10 @@ if not get_option('virglrenderer').auto() or have_system or have_vhost_user_gpu > > prefix: '#include <virglrenderer.h>', > > dependencies: virgl)) > > endif > > + config_host_data.set('HAVE_VIRGL_CONTEXT_INIT', > > + cc.has_function('virgl_renderer_context_create_with_flags', > > + prefix: '#include <virglrenderer.h>', > > + dependencies: virgl)) > > Shouldn't this be inverted with previous patch? > Yes, this should be patch 3 because we should configure HAVE_VIRGL_CONTEXT_INIT firstly. I will update it in next version. Thanks Ray
diff --git a/meson.build b/meson.build index 98e68ef0b1..ff20d3c249 100644 --- a/meson.build +++ b/meson.build @@ -1068,6 +1068,10 @@ if not get_option('virglrenderer').auto() or have_system or have_vhost_user_gpu prefix: '#include <virglrenderer.h>', dependencies: virgl)) endif + config_host_data.set('HAVE_VIRGL_CONTEXT_INIT', + cc.has_function('virgl_renderer_context_create_with_flags', + prefix: '#include <virglrenderer.h>', + dependencies: virgl)) endif blkio = not_found if not get_option('blkio').auto() or have_block
Configure context init feature flag for virglrenderer. Originally-by: Antonio Caggiano <antonio.caggiano@collabora.com> Signed-off-by: Huang Rui <ray.huang@amd.com> --- New patch, result of splitting [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature meson.build | 4 ++++ 1 file changed, 4 insertions(+)