| Message ID | 20230901070240.31027-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/amdgpu: clean up some inconsistent indenting | expand |
Am 01.09.23 um 09:02 schrieb Jiapeng Chong: > No functional modification involved. > > drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. We should probably not have a printk here in the first place. Christian. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c > index 7c08e5f95e97..76e21357dd4d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c > +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c > @@ -31,10 +31,9 @@ > static u32 nbio_v7_11_get_rev_id(struct amdgpu_device *adev) > { > u32 tmp; > - printk("%s, getid\n",__func__); > - > - tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0); > > + printk("%s, getid\n", __func__); > + tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0); > tmp &= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0_MASK; > tmp >>= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0__SHIFT; >
Applied and dropped the printk. Alex On Fri, Sep 1, 2023 at 3:40 AM Christian König <christian.koenig@amd.com> wrote: > > Am 01.09.23 um 09:02 schrieb Jiapeng Chong: > > No functional modification involved. > > > > drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. > > > We should probably not have a printk here in the first place. > > Christian. > > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316 > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > --- > > drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c > > index 7c08e5f95e97..76e21357dd4d 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c > > +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c > > @@ -31,10 +31,9 @@ > > static u32 nbio_v7_11_get_rev_id(struct amdgpu_device *adev) > > { > > u32 tmp; > > - printk("%s, getid\n",__func__); > > - > > - tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0); > > > > + printk("%s, getid\n", __func__); > > + tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0); > > tmp &= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0_MASK; > > tmp >>= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0__SHIFT; > > >
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c index 7c08e5f95e97..76e21357dd4d 100644 --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c @@ -31,10 +31,9 @@ static u32 nbio_v7_11_get_rev_id(struct amdgpu_device *adev) { u32 tmp; - printk("%s, getid\n",__func__); - - tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0); + printk("%s, getid\n", __func__); + tmp = RREG32_SOC15(NBIO, 0, regRCC_STRAP1_RCC_DEV0_EPF0_STRAP0); tmp &= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0_MASK; tmp >>= RCC_STRAP0_RCC_DEV0_EPF0_STRAP0__STRAP_ATI_REV_ID_DEV0_F0__SHIFT;
No functional modification involved. drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)