| Message ID | 20230904055010.4118982-3-quic_viswanat@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix tcsr_mutex register for IPQ6018 | expand |
On 04/09/2023 07:50, Vignesh Viswanathan wrote: > qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is > dropped from the devictree. No, it is not dropped. > IPQ6018 will use qcom,tcsr-mutex compatible > string. No, it will not. > > Drop qcom,ipq6018-tcsr-mutex compatible string from > qcom_hwspinlock_of_match table. Why? Do not write what you are doing here, but why you are doing it. Best regards, Krzysztof
On 4.09.2023 08:42, Krzysztof Kozlowski wrote: > On 04/09/2023 07:50, Vignesh Viswanathan wrote: >> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is >> dropped from the devictree. > > No, it is not dropped. > > >> IPQ6018 will use qcom,tcsr-mutex compatible >> string. > > No, it will not. > >> >> Drop qcom,ipq6018-tcsr-mutex compatible string from >> qcom_hwspinlock_of_match table. > > Why? Do not write what you are doing here, but why you are doing it. More importantly, looks like the ipq6018 compatible was added after support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a), so if it's going to use of_tcsr_mutex data with the fallback compat, the SoC-specific compatible can be removed from the driver. Konrad
On 9/4/2023 9:31 PM, Konrad Dybcio wrote: > On 4.09.2023 08:42, Krzysztof Kozlowski wrote: >> On 04/09/2023 07:50, Vignesh Viswanathan wrote: >>> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is >>> dropped from the devictree. >> >> No, it is not dropped. >> >> >>> IPQ6018 will use qcom,tcsr-mutex compatible >>> string. >> >> No, it will not. >> >>> >>> Drop qcom,ipq6018-tcsr-mutex compatible string from >>> qcom_hwspinlock_of_match table. >> >> Why? Do not write what you are doing here, but why you are doing it. > More importantly, looks like the ipq6018 compatible was added after > support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a), > so if it's going to use of_tcsr_mutex data with the fallback compat, the > SoC-specific compatible can be removed from the driver. > Hi Konrad, Krzysztof, I was planning to update the SOC-specific compatible for IPQ6018 qcom,ipq6018-tcsr-mutex to point to of_tcsr_mutex data in the of_match table in the hwspinlock driver in V2. Do you think this would be okay? or should I go ahead with removal of IPQ6018 specific compatible so that it falls back to of_tcsr_mutex? Thanks, Vignesh > Konrad
On 04/09/2023 18:09, Vignesh Viswanathan wrote: > > > On 9/4/2023 9:31 PM, Konrad Dybcio wrote: >> On 4.09.2023 08:42, Krzysztof Kozlowski wrote: >>> On 04/09/2023 07:50, Vignesh Viswanathan wrote: >>>> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is >>>> dropped from the devictree. >>> >>> No, it is not dropped. >>> >>> >>>> IPQ6018 will use qcom,tcsr-mutex compatible >>>> string. >>> >>> No, it will not. >>> >>>> >>>> Drop qcom,ipq6018-tcsr-mutex compatible string from >>>> qcom_hwspinlock_of_match table. >>> >>> Why? Do not write what you are doing here, but why you are doing it. >> More importantly, looks like the ipq6018 compatible was added after >> support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a), >> so if it's going to use of_tcsr_mutex data with the fallback compat, the >> SoC-specific compatible can be removed from the driver. >> > Hi Konrad, Krzysztof, > > I was planning to update the SOC-specific compatible for IPQ6018 > qcom,ipq6018-tcsr-mutex to point to of_tcsr_mutex data in the of_match > table in the hwspinlock driver in V2. > > Do you think this would be okay? or should I go ahead with removal of > IPQ6018 specific compatible so that it falls back to of_tcsr_mutex? Remove, it's not needed in the driver. Best regards, Krzysztof
On 9/4/2023 11:46 PM, Krzysztof Kozlowski wrote: > On 04/09/2023 18:09, Vignesh Viswanathan wrote: >> >> >> On 9/4/2023 9:31 PM, Konrad Dybcio wrote: >>> On 4.09.2023 08:42, Krzysztof Kozlowski wrote: >>>> On 04/09/2023 07:50, Vignesh Viswanathan wrote: >>>>> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is >>>>> dropped from the devictree. >>>> >>>> No, it is not dropped. >>>> >>>> >>>>> IPQ6018 will use qcom,tcsr-mutex compatible >>>>> string. >>>> >>>> No, it will not. >>>> >>>>> >>>>> Drop qcom,ipq6018-tcsr-mutex compatible string from >>>>> qcom_hwspinlock_of_match table. >>>> >>>> Why? Do not write what you are doing here, but why you are doing it. >>> More importantly, looks like the ipq6018 compatible was added after >>> support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a), >>> so if it's going to use of_tcsr_mutex data with the fallback compat, the >>> SoC-specific compatible can be removed from the driver. >>> >> Hi Konrad, Krzysztof, >> >> I was planning to update the SOC-specific compatible for IPQ6018 >> qcom,ipq6018-tcsr-mutex to point to of_tcsr_mutex data in the of_match >> table in the hwspinlock driver in V2. >> >> Do you think this would be okay? or should I go ahead with removal of >> IPQ6018 specific compatible so that it falls back to of_tcsr_mutex? > > Remove, it's not needed in the driver. Ack, will remove in V2. > > Best regards, > Krzysztof >
diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index a0fd67fd2934..814dfe8697bf 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -115,7 +115,6 @@ static const struct of_device_id qcom_hwspinlock_of_match[] = { { .compatible = "qcom,sfpb-mutex", .data = &of_sfpb_mutex }, { .compatible = "qcom,tcsr-mutex", .data = &of_tcsr_mutex }, { .compatible = "qcom,apq8084-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, - { .compatible = "qcom,ipq6018-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, { .compatible = "qcom,msm8226-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, { .compatible = "qcom,msm8974-tcsr-mutex", .data = &of_msm8226_tcsr_mutex }, { .compatible = "qcom,msm8994-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is dropped from the devictree. IPQ6018 will use qcom,tcsr-mutex compatible string. Drop qcom,ipq6018-tcsr-mutex compatible string from qcom_hwspinlock_of_match table. Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com> --- drivers/hwspinlock/qcom_hwspinlock.c | 1 - 1 file changed, 1 deletion(-)