| Message ID | 20230830194617.26400-1-quic_sidhanta@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: Set default beacon mode to burst mode | expand |
On 8/30/2023 12:46 PM, Sidhanta Sahu wrote: > Currently, firmware does not like when beacon mode is set as staggered > mode for more than one beaconing vifs. Beacon mode for multiple > beaconing (transmitted) vifs are expected to be in burst mode. So set > beacon mode to burst mode by default. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Sidhanta Sahu <quic_sidhanta@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index 1bb9802ef569..b16cbc3c906d 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -2314,7 +2314,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > > if (changed & BSS_CHANGED_BEACON) { > param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; > - param_value = WMI_BEACON_STAGGERED_MODE; > + param_value = WMI_BEACON_BURST_MODE; > ret = ath12k_wmi_pdev_set_param(ar, param_id, > param_value, ar->pdev->pdev_id); > if (ret)
On 8/30/2023 12:46 PM, Sidhanta Sahu wrote: > Currently, firmware does not like when beacon mode is set as staggered > mode for more than one beaconing vifs. Beacon mode for multiple > beaconing (transmitted) vifs are expected to be in burst mode. So set > beacon mode to burst mode by default. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Sidhanta Sahu <quic_sidhanta@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index 1bb9802ef569..b16cbc3c906d 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -2314,7 +2314,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > > if (changed & BSS_CHANGED_BEACON) { > param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; > - param_value = WMI_BEACON_STAGGERED_MODE; > + param_value = WMI_BEACON_BURST_MODE; > ret = ath12k_wmi_pdev_set_param(ar, param_id, > param_value, ar->pdev->pdev_id); > if (ret)
On 8/31/23 01:16, Sidhanta Sahu wrote: > Currently, firmware does not like when beacon mode is set as staggered > mode for more than one beaconing vifs. Beacon mode for multiple > beaconing (transmitted) vifs are expected to be in burst mode. So set > beacon mode to burst mode by default. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Sidhanta Sahu <quic_sidhanta@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index 1bb9802ef569..b16cbc3c906d 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -2314,7 +2314,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > > if (changed & BSS_CHANGED_BEACON) { > param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; > - param_value = WMI_BEACON_STAGGERED_MODE; > + param_value = WMI_BEACON_BURST_MODE; > ret = ath12k_wmi_pdev_set_param(ar, param_id, > param_value, ar->pdev->pdev_id); > if (ret) In else part, we have a debug print. IMHO that should be changed too. Please check once. else ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "Set staggered beacon mode for VDEV: %d\n", arvif->vdev_id); Could you check once? Aditya
On 8/30/2023 8:49 PM, Aditya Kumar Singh wrote: > On 8/31/23 01:16, Sidhanta Sahu wrote: >> Currently, firmware does not like when beacon mode is set as staggered >> mode for more than one beaconing vifs. Beacon mode for multiple >> beaconing (transmitted) vifs are expected to be in burst mode. So set >> beacon mode to burst mode by default. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Sidhanta Sahu <quic_sidhanta@quicinc.com> >> --- >> drivers/net/wireless/ath/ath12k/mac.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ath/ath12k/mac.c >> b/drivers/net/wireless/ath/ath12k/mac.c >> index 1bb9802ef569..b16cbc3c906d 100644 >> --- a/drivers/net/wireless/ath/ath12k/mac.c >> +++ b/drivers/net/wireless/ath/ath12k/mac.c >> @@ -2314,7 +2314,7 @@ static void >> ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, >> if (changed & BSS_CHANGED_BEACON) { >> param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; >> - param_value = WMI_BEACON_STAGGERED_MODE; >> + param_value = WMI_BEACON_BURST_MODE; >> ret = ath12k_wmi_pdev_set_param(ar, param_id, >> param_value, ar->pdev->pdev_id); >> if (ret) > In else part, we have a debug print. IMHO that should be changed too. > Please check once. > > else > ath12k_dbg(ar->ab, ATH12K_DBG_MAC, > "Set staggered beacon mode for VDEV: %d\n", > arvif->vdev_id); > > Could you check once? Yes, Will change it in next version. > > Aditya
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 1bb9802ef569..b16cbc3c906d 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -2314,7 +2314,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, if (changed & BSS_CHANGED_BEACON) { param_id = WMI_PDEV_PARAM_BEACON_TX_MODE; - param_value = WMI_BEACON_STAGGERED_MODE; + param_value = WMI_BEACON_BURST_MODE; ret = ath12k_wmi_pdev_set_param(ar, param_id, param_value, ar->pdev->pdev_id); if (ret)
Currently, firmware does not like when beacon mode is set as staggered mode for more than one beaconing vifs. Beacon mode for multiple beaconing (transmitted) vifs are expected to be in burst mode. So set beacon mode to burst mode by default. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Sidhanta Sahu <quic_sidhanta@quicinc.com> --- drivers/net/wireless/ath/ath12k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)