| Message ID | 20230906094923.1447570-1-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4l-utils,1/1] utils: libv4l2subdev: Set stream for g_routing | expand |
On 06/09/2023 12:49, Sakari Ailus wrote: > Set the stream field for g_routing. This was missed in the original patch > adding support for streams. I think you mean g_selection, in both the subject and desc. Other than that: Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > Fixes: e300287381c6 ("media-ctl: Add support for routes and streams") > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > utils/media-ctl/libv4l2subdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c > index 16e1284cc0a3..c614f4a2e0fd 100644 > --- a/utils/media-ctl/libv4l2subdev.c > +++ b/utils/media-ctl/libv4l2subdev.c > @@ -166,6 +166,7 @@ int v4l2_subdev_get_selection(struct media_entity *entity, > > memset(&u.sel, 0, sizeof(u.sel)); > u.sel.pad = pad; > + u.sel.stream = stream; > u.sel.target = target; > u.sel.which = which; >
On Wed, Sep 06, 2023 at 01:28:00PM +0300, Tomi Valkeinen wrote: > On 06/09/2023 12:49, Sakari Ailus wrote: > > Set the stream field for g_routing. This was missed in the original patch > > adding support for streams. > > I think you mean g_selection, in both the subject and desc. Good point. I was thinking of routing but it's indeed about selection, as in the patch. I'll send v2. > > Other than that: > > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Thanks!
diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c index 16e1284cc0a3..c614f4a2e0fd 100644 --- a/utils/media-ctl/libv4l2subdev.c +++ b/utils/media-ctl/libv4l2subdev.c @@ -166,6 +166,7 @@ int v4l2_subdev_get_selection(struct media_entity *entity, memset(&u.sel, 0, sizeof(u.sel)); u.sel.pad = pad; + u.sel.stream = stream; u.sel.target = target; u.sel.which = which;
Set the stream field for g_routing. This was missed in the original patch adding support for streams. Fixes: e300287381c6 ("media-ctl: Add support for routes and streams") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- utils/media-ctl/libv4l2subdev.c | 1 + 1 file changed, 1 insertion(+)