| Message ID | 20230908070152.26484-422-nic_swsd@realtek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a7b8d60b37237680009dd0b025fe8c067aba0ee3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] r8152: check budget for r8152_poll() | expand |
On Fri, Sep 08, 2023 at 03:01:52PM +0800, Hayes Wang wrote: > According to the document of napi, there is no rx process when the > budget is 0. Therefore, r8152_poll() has to return 0 directly when the > budget is equal to 0. > > Fixes: d2187f8e4454 ("r8152: divide the tx and rx bottom functions") > Signed-off-by: Hayes Wang <hayeswang@realtek.com> > --- > drivers/net/usb/r8152.c | 3 +++ > 1 file changed, 3 insertions(+) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documetnation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 8 Sep 2023 15:01:52 +0800 you wrote: > According to the document of napi, there is no rx process when the > budget is 0. Therefore, r8152_poll() has to return 0 directly when the > budget is equal to 0. > > Fixes: d2187f8e4454 ("r8152: divide the tx and rx bottom functions") > Signed-off-by: Hayes Wang <hayeswang@realtek.com> > > [...] Here is the summary with links: - [net] r8152: check budget for r8152_poll() https://git.kernel.org/netdev/net/c/a7b8d60b3723 You are awesome, thank you!
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 332c853ca99b..0c13d9950cd8 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -2636,6 +2636,9 @@ static int r8152_poll(struct napi_struct *napi, int budget) struct r8152 *tp = container_of(napi, struct r8152, napi); int work_done; + if (!budget) + return 0; + work_done = rx_bottom(tp, budget); if (work_done < budget) {
According to the document of napi, there is no rx process when the budget is 0. Therefore, r8152_poll() has to return 0 directly when the budget is equal to 0. Fixes: d2187f8e4454 ("r8152: divide the tx and rx bottom functions") Signed-off-by: Hayes Wang <hayeswang@realtek.com> --- drivers/net/usb/r8152.c | 3 +++ 1 file changed, 3 insertions(+)