mbox series

[0/2] btrfs: updates for directory reading

Message ID cover.1694260751.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: updates for directory reading | expand

Message

Filipe Manana Sept. 9, 2023, 12:08 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Tweak and fix a bug when reading directory entries after a rewinddir(3)
call. Reported by Ian Johnson.

Link: https://lore.kernel.org/linux-btrfs/YR1P0S.NGASEG570GJ8@ianjohnson.dev/T/#u

Filipe Manana (2):
  btrfs: set last dir index to the current last index when opening dir
  btrfs: refresh dir last index during a rewinddir(3) call

 fs/btrfs/inode.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

Comments

David Sterba Sept. 11, 2023, 5:28 p.m. UTC | #1
On Sat, Sep 09, 2023 at 01:08:30PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Tweak and fix a bug when reading directory entries after a rewinddir(3)
> call. Reported by Ian Johnson.
> 
> Link: https://lore.kernel.org/linux-btrfs/YR1P0S.NGASEG570GJ8@ianjohnson.dev/T/#u
> 
> Filipe Manana (2):
>   btrfs: set last dir index to the current last index when opening dir
>   btrfs: refresh dir last index during a rewinddir(3) call

Thanks for the quick fixes, added to misc-next.
Josef Bacik Sept. 11, 2023, 5:35 p.m. UTC | #2
On Sat, Sep 09, 2023 at 01:08:30PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Tweak and fix a bug when reading directory entries after a rewinddir(3)
> call. Reported by Ian Johnson.
> 
> Link: https://lore.kernel.org/linux-btrfs/YR1P0S.NGASEG570GJ8@ianjohnson.dev/T/#u
> 
> Filipe Manana (2):
>   btrfs: set last dir index to the current last index when opening dir
>   btrfs: refresh dir last index during a rewinddir(3) call
> 
>  fs/btrfs/inode.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

I didn't see an fstest for this, is it forthcoming?  Thanks,

Josef
Filipe Manana Sept. 11, 2023, 5:40 p.m. UTC | #3
On Mon, Sep 11, 2023 at 6:35 PM Josef Bacik <josef@toxicpanda.com> wrote:
>
> On Sat, Sep 09, 2023 at 01:08:30PM +0100, fdmanana@kernel.org wrote:
> > From: Filipe Manana <fdmanana@suse.com>
> >
> > Tweak and fix a bug when reading directory entries after a rewinddir(3)
> > call. Reported by Ian Johnson.
> >
> > Link: https://lore.kernel.org/linux-btrfs/YR1P0S.NGASEG570GJ8@ianjohnson.dev/T/#u
> >
> > Filipe Manana (2):
> >   btrfs: set last dir index to the current last index when opening dir
> >   btrfs: refresh dir last index during a rewinddir(3) call
> >
> >  fs/btrfs/inode.c | 18 ++++++++++++++++--
> >  1 file changed, 16 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
>
> I didn't see an fstest for this, is it forthcoming?  Thanks,

Give me a break... I did this on a Saturday morning.
Be patient...

>
> Josef