| Message ID | 20230911-msm8916-rmem-v1-3-b7089ec3e3a1@gerhold.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 40eb256e5fd1fd49813a27a252b7f45ccca89fde |
| Headers | show |
| Series | arm64: dts: qcom: msm8916/39: Reserve firmware memory dynamically | expand |
On 11/09/2023 18:41, Stephan Gerhold wrote: > gps_mem is needed by the modem firmware for GPS to work. However, it is > accessed via QMI memshare [1] which is not available upstream yet. > Until it lands upstream reserving this does not provide any advantage. > > [1]: https://lore.kernel.org/linux-arm-msm/20210319172321.22248-1-nikitos.tr@gmail.com/ > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- > arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi > index c759c0544dd9..69f268db4df9 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi > @@ -22,11 +22,6 @@ mpss_mem: mpss@86800000 { > reg = <0x0 0x86800000 0x0 0x5500000>; > no-map; > }; > - > - gps_mem: gps@8bd00000 { > - reg = <0x0 0x8bd00000 0x0 0x200000>; > - no-map; > - }; > }; > > gpio-keys { > Should this have a Fixes tag, should probably be applied to stable. Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Tue, Sep 12, 2023 at 07:36:43AM +0100, Bryan O'Donoghue wrote: > On 11/09/2023 18:41, Stephan Gerhold wrote: > > gps_mem is needed by the modem firmware for GPS to work. However, it is > > accessed via QMI memshare [1] which is not available upstream yet. > > Until it lands upstream reserving this does not provide any advantage. > > > > [1]: https://lore.kernel.org/linux-arm-msm/20210319172321.22248-1-nikitos.tr@gmail.com/ > > > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > > --- > > arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi > > index c759c0544dd9..69f268db4df9 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi > > @@ -22,11 +22,6 @@ mpss_mem: mpss@86800000 { > > reg = <0x0 0x86800000 0x0 0x5500000>; > > no-map; > > }; > > - > > - gps_mem: gps@8bd00000 { > > - reg = <0x0 0x8bd00000 0x0 0x200000>; > > - no-map; > > - }; > > }; > > gpio-keys { > > > > Should this have a Fixes tag, should probably be applied to stable. > I'm probably a bit "overcautious" when it comes to stable backporting, but I think this is not strictly a fix but more like cleanup. It doesn't cause any trouble to reserve the extra memory, it just wastes some RAM. Thanks, Stephan
diff --git a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi index c759c0544dd9..69f268db4df9 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi @@ -22,11 +22,6 @@ mpss_mem: mpss@86800000 { reg = <0x0 0x86800000 0x0 0x5500000>; no-map; }; - - gps_mem: gps@8bd00000 { - reg = <0x0 0x8bd00000 0x0 0x200000>; - no-map; - }; }; gpio-keys {
gps_mem is needed by the modem firmware for GPS to work. However, it is accessed via QMI memshare [1] which is not available upstream yet. Until it lands upstream reserving this does not provide any advantage. [1]: https://lore.kernel.org/linux-arm-msm/20210319172321.22248-1-nikitos.tr@gmail.com/ Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- arch/arm64/boot/dts/qcom/msm8916-ufi.dtsi | 5 ----- 1 file changed, 5 deletions(-)