diff mbox series

[V2,4/5] ASoC: codecs: Change the aw88261 variable name and i2c driver name

Message ID 20230912065852.347000-5-wangweidong.a@awinic.com (mailing list archive)
State Superseded
Headers show
Series ASoC: codecs: Add aw87390 amplifier driver | expand

Commit Message

wangweidong.a@awinic.com Sept. 12, 2023, 6:58 a.m. UTC 
From: Weidong Wang <wangweidong.a@awinic.com>

Change "sound-channel" to "awinic,audio-channel"
Change "aw88261_smartpa" to "aw88261"

Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
---
 sound/soc/codecs/aw88261.c | 23 ++++++++++++-----------
 sound/soc/codecs/aw88261.h |  2 +-
 2 files changed, 13 insertions(+), 12 deletions(-)

Comments

Krzysztof Kozlowski Sept. 13, 2023, 7:03 a.m. UTC | #1 
On 12/09/2023 08:58, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
> 
> Change "sound-channel" to "awinic,audio-channel"
> Change "aw88261_smartpa" to "aw88261"



> -	prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count);
> -	if (!prof_name) {
> +	ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name);
> +	if (ret) {
>  		strscpy(uinfo->value.enumerated.name, "null",
>  						strlen("null") + 1);
>  		return 0;
> @@ -1189,7 +1190,7 @@ static void aw88261_parse_channel_dt(struct aw88261 *aw88261)
>  	u32 channel_value = AW88261_DEV_DEFAULT_CH;
>  	u32 sync_enable = false;
>  
> -	of_property_read_u32(np, "sound-channel", &channel_value);
> +	of_property_read_u32(np, "awinic,audio-channel", &channel_value);
>  	of_property_read_u32(np, "sync-flag", &sync_enable);

What about this?

Best regards,
Krzysztof
wangweidong.a@awinic.com Sept. 13, 2023, 8 a.m. UTC | #2 
Thank you very much for your review.

On 13/09/2023 09:03, krzysztof.kozlowski@linaro.org wrote:
> On 12/09/2023 08:58, wangweidong.a@awinic.com wrote:
>> From: Weidong Wang <wangweidong.a@awinic.com>
>> 
>> Change "sound-channel" to "awinic,audio-channel"
>> Change "aw88261_smartpa" to "aw88261"

I'll add "This change is for consistency with yaml properties" to the commit message.

>> -	prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count);
>> -	if (!prof_name) {
>> +	ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name);
>> +	if (ret) {
>>  		strscpy(uinfo->value.enumerated.name, "null",
>>  						strlen("null") + 1);
>>  		return 0;
>> @@ -1189,7 +1190,7 @@ static void aw88261_parse_channel_dt(struct aw88261 *aw88261)
>>  	u32 channel_value = AW88261_DEV_DEFAULT_CH;
>>  	u32 sync_enable = false;
>>  
>> -	of_property_read_u32(np, "sound-channel", &channel_value);
>> +	of_property_read_u32(np, "awinic,audio-channel", &channel_value);
>>  	of_property_read_u32(np, "sync-flag", &sync_enable);

> What about this?

This change is to be consistent with the name in the yaml file

Best regards,
Weidong Wang
diff mbox series

Patch

diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c
index a697b5006b45..d01c3ea1bb7d 100644
--- a/sound/soc/codecs/aw88261.c
+++ b/sound/soc/codecs/aw88261.c
@@ -477,7 +477,7 @@  static int aw88261_dev_reg_update(struct aw88261 *aw88261,
 	return ret;
 }
 
-static char *aw88261_dev_get_prof_name(struct aw_device *aw_dev, int index)
+static int aw88261_dev_get_prof_name(struct aw_device *aw_dev, int index, char **prof_name)
 {
 	struct aw_prof_info *prof_info = &aw_dev->prof_info;
 	struct aw_prof_desc *prof_desc;
@@ -485,12 +485,14 @@  static char *aw88261_dev_get_prof_name(struct aw_device *aw_dev, int index)
 	if ((index >= aw_dev->prof_info.count) || (index < 0)) {
 		dev_err(aw_dev->dev, "index[%d] overflow count[%d]",
 			index, aw_dev->prof_info.count);
-		return NULL;
+		return -EINVAL;
 	}
 
 	prof_desc = &aw_dev->prof_info.prof_desc[index];
 
-	return prof_info->prof_name_list[prof_desc->id];
+	*prof_name = prof_info->prof_name_list[prof_desc->id];
+
+	return 0;
 }
 
 static int aw88261_dev_get_prof_data(struct aw_device *aw_dev, int index,
@@ -515,8 +517,8 @@  static int aw88261_dev_fw_update(struct aw88261 *aw88261)
 	char *prof_name;
 	int ret;
 
-	prof_name = aw88261_dev_get_prof_name(aw_dev, aw_dev->prof_index);
-	if (!prof_name) {
+	ret = aw88261_dev_get_prof_name(aw_dev, aw_dev->prof_index, &prof_name);
+	if (ret) {
 		dev_err(aw_dev->dev, "get prof name failed");
 		return -EINVAL;
 	}
@@ -818,9 +820,8 @@  static int aw88261_profile_info(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_component *codec = snd_soc_kcontrol_component(kcontrol);
 	struct aw88261 *aw88261 = snd_soc_component_get_drvdata(codec);
-	const char *prof_name;
-	char *name;
-	int count;
+	char *prof_name, *name;
+	int count, ret;
 
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
 	uinfo->count = 1;
@@ -839,8 +840,8 @@  static int aw88261_profile_info(struct snd_kcontrol *kcontrol,
 	name = uinfo->value.enumerated.name;
 	count = uinfo->value.enumerated.item;
 
-	prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count);
-	if (!prof_name) {
+	ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name);
+	if (ret) {
 		strscpy(uinfo->value.enumerated.name, "null",
 						strlen("null") + 1);
 		return 0;
@@ -1189,7 +1190,7 @@  static void aw88261_parse_channel_dt(struct aw88261 *aw88261)
 	u32 channel_value = AW88261_DEV_DEFAULT_CH;
 	u32 sync_enable = false;
 
-	of_property_read_u32(np, "sound-channel", &channel_value);
+	of_property_read_u32(np, "awinic,audio-channel", &channel_value);
 	of_property_read_u32(np, "sync-flag", &sync_enable);
 
 	aw_dev->channel = channel_value;
diff --git a/sound/soc/codecs/aw88261.h b/sound/soc/codecs/aw88261.h
index 4f3dbf438510..bd0841fa9b77 100644
--- a/sound/soc/codecs/aw88261.h
+++ b/sound/soc/codecs/aw88261.h
@@ -370,7 +370,7 @@ 
 #define AW88261_START_RETRIES		(5)
 #define AW88261_START_WORK_DELAY_MS	(0)
 
-#define AW88261_I2C_NAME		"aw88261_smartpa"
+#define AW88261_I2C_NAME		"aw88261"
 
 #define AW88261_RATES (SNDRV_PCM_RATE_8000_48000 | \
 			SNDRV_PCM_RATE_96000)