mbox

[PULL,v2,0/1] Merge tpm 2023/09/12 v2

Message ID 20230913115449.502183-1-stefanb@linux.ibm.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2023-09-12-2

Message

Stefan Berger Sept. 13, 2023, 11:54 a.m. UTC 
Hello!

  This PR contains a fix for the case where the TPM file descriptor is >= 1024
and the select() call cannot be used. It also avoids unnecessary errors due to
EINTR being returned from the syscall.

Regards,
   Stefan

The following changes since commit 9ef497755afc252fb8e060c9ea6b0987abfd20b6:

  Merge tag 'pull-vfio-20230911' of https://github.com/legoater/qemu into staging (2023-09-11 09:13:08 -0400)

are available in the Git repository at:

  https://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2023-09-12-2

for you to fetch changes up to 07160c57e47ce38bd256af3eae0481543fb52626:

  tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR (2023-09-13 07:46:59 -0400)

----------------------------------------------------------------

Marc-Andr޸ Lureau (1):
  tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR

 backends/tpm/tpm_util.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Philippe Mathieu-Daudé Sept. 13, 2023, 12:27 p.m. UTC | #1 
Hi Stefan,

On 13/9/23 13:54, Stefan Berger wrote:
> Hello!
> 
>    This PR contains a fix for the case where the TPM file descriptor is >= 1024
> and the select() call cannot be used. It also avoids unnecessary errors due to
> EINTR being returned from the syscall.
> 
> Regards,
>     Stefan
> 
> The following changes since commit 9ef497755afc252fb8e060c9ea6b0987abfd20b6:
> 
>    Merge tag 'pull-vfio-20230911' of https://github.com/legoater/qemu into staging (2023-09-11 09:13:08 -0400)
> 
> are available in the Git repository at:
> 
>    https://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2023-09-12-2
> 
> for you to fetch changes up to 07160c57e47ce38bd256af3eae0481543fb52626:
> 
>    tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR (2023-09-13 07:46:59 -0400)
> 
> ----------------------------------------------------------------
> 
> Marc-Andr޸ Lureau (1):
>    tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR

I recommend you the b4 tool, see:
https://pypi.org/project/b4/
https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation
Stefan Berger Sept. 13, 2023, 12:40 p.m. UTC | #2 
On 9/13/23 08:27, Philippe Mathieu-Daudé wrote:
> Hi Stefan,
>
> On 13/9/23 13:54, Stefan Berger wrote:
>> Hello!
>>
>>    This PR contains a fix for the case where the TPM file descriptor 
>> is >= 1024
>> and the select() call cannot be used. It also avoids unnecessary 
>> errors due to
>> EINTR being returned from the syscall.
>>
>> Regards,
>>     Stefan
>>
>> The following changes since commit 
>> 9ef497755afc252fb8e060c9ea6b0987abfd20b6:
>>
>>    Merge tag 'pull-vfio-20230911' of https://github.com/legoater/qemu 
>> into staging (2023-09-11 09:13:08 -0400)
>>
>> are available in the Git repository at:
>>
>>    https://github.com/stefanberger/qemu-tpm.git 
>> tags/pull-tpm-2023-09-12-2
>>
>> for you to fetch changes up to 07160c57e47ce38bd256af3eae0481543fb52626:
>>
>>    tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR 
>> (2023-09-13 07:46:59 -0400)
>>
>> ----------------------------------------------------------------
>>
>> Marc-Andr޸ Lureau (1):
>>    tpm: fix crash when FD >= 1024 and unnecessary errors due to EINTR
>
> I recommend you the b4 tool, see:
> https://pypi.org/project/b4/
> https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation 
>

I had tried to use 'patches' but it doesn't seem to work anymore on the 
python level. So I ended up saving the email via Thunderbird and applied 
it. Maybe that's the mistake? Otherwise I know the b4 tool and typically 
am using it for Linux patches but I see now that there's lore.kernel.org 
for qemu-devel as well. Alright, v3 coming up soon.

    Stefan