mbox series

[00/12] drm/i915: Populate connector->ddc always

Message ID 20230829113920.13713-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Populate connector->ddc always | expand

Message

Ville Syrjala Aug. 29, 2023, 11:39 a.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Populate connector->ddc for all output types that don't already
do so, and clean up a bunch of code as a result of having the
ddc i2c adapter in easy reach. And this also provides the sysfs
"ddc" symlink.

There are potentially a few oddball (mostly DVI-I) cases where
the connector detection/EDID read uses an alternate DDC bus
internally, and so for those the symlink might not point at the
correct i2c adapter. I'm not interested in spending extra brain
cells on those, so we'll leave them as is for now.

Ville Syrjälä (12):
  drm: Reorder drm_sysfs_connector_remove() vs.
    drm_debugfs_connector_remove()
  drm/sysfs: Register "ddc" symlink later
  drm/i915: Call the DDC bus i2c adapter "ddc"
  drm/i915/lvds: Populate connector->ddc
  drm/i915/crt: Populate connector->ddc
  drm/i915/dvo: Populate connector->ddc
  drm/i915/dp: Populate connector->ddc
  drm/i915/mst: Populate connector->ddc
  drm/i915/hdmi: Use connector->ddc everwhere
  drm/i915/hdmi: Nuke hdmi->ddc_bus
  drm/i915/hdmi: Remove old i2c symlink
  drm/i915/sdvo: Constify mapping structs

 drivers/gpu/drm/drm_connector.c               | 11 ++-
 drivers/gpu/drm/drm_internal.h                |  2 +
 drivers/gpu/drm/drm_sysfs.c                   | 22 +++--
 .../gpu/drm/i915/display/intel_connector.c    |  6 +-
 .../gpu/drm/i915/display/intel_connector.h    |  2 +-
 drivers/gpu/drm/i915/display/intel_crt.c      | 38 +++----
 drivers/gpu/drm/i915/display/intel_ddi.c      |  5 +-
 .../drm/i915/display/intel_display_types.h    |  1 -
 drivers/gpu/drm/i915/display/intel_dp.c       |  9 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  6 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      | 11 +--
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 98 ++++++-------------
 drivers/gpu/drm/i915/display/intel_lspcon.c   | 14 +--
 drivers/gpu/drm/i915/display/intel_lvds.c     | 23 +++--
 drivers/gpu/drm/i915/display/intel_sdvo.c     |  6 +-
 15 files changed, 119 insertions(+), 135 deletions(-)

Comments

Ville Syrjala Sept. 13, 2023, 12:28 p.m. UTC | #1
On Tue, Aug 29, 2023 at 02:39:08PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Populate connector->ddc for all output types that don't already
> do so, and clean up a bunch of code as a result of having the
> ddc i2c adapter in easy reach. And this also provides the sysfs
> "ddc" symlink.
> 
> There are potentially a few oddball (mostly DVI-I) cases where
> the connector detection/EDID read uses an alternate DDC bus
> internally, and so for those the symlink might not point at the
> correct i2c adapter. I'm not interested in spending extra brain
> cells on those, so we'll leave them as is for now.
> 
> Ville Syrjälä (12):
>   drm: Reorder drm_sysfs_connector_remove() vs.
>     drm_debugfs_connector_remove()
>   drm/sysfs: Register "ddc" symlink later

Maarten/Maxime/Thomas can I get an ack for merging these two
via drm-intel-next? Would avoid having to wait for a backmerge...

>   drm/i915: Call the DDC bus i2c adapter "ddc"
>   drm/i915/lvds: Populate connector->ddc
>   drm/i915/crt: Populate connector->ddc
>   drm/i915/dvo: Populate connector->ddc
>   drm/i915/dp: Populate connector->ddc
>   drm/i915/mst: Populate connector->ddc
>   drm/i915/hdmi: Use connector->ddc everwhere
>   drm/i915/hdmi: Nuke hdmi->ddc_bus
>   drm/i915/hdmi: Remove old i2c symlink
>   drm/i915/sdvo: Constify mapping structs
> 
>  drivers/gpu/drm/drm_connector.c               | 11 ++-
>  drivers/gpu/drm/drm_internal.h                |  2 +
>  drivers/gpu/drm/drm_sysfs.c                   | 22 +++--
>  .../gpu/drm/i915/display/intel_connector.c    |  6 +-
>  .../gpu/drm/i915/display/intel_connector.h    |  2 +-
>  drivers/gpu/drm/i915/display/intel_crt.c      | 38 +++----
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  5 +-
>  .../drm/i915/display/intel_display_types.h    |  1 -
>  drivers/gpu/drm/i915/display/intel_dp.c       |  9 +-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |  6 +-
>  drivers/gpu/drm/i915/display/intel_dvo.c      | 11 +--
>  drivers/gpu/drm/i915/display/intel_hdmi.c     | 98 ++++++-------------
>  drivers/gpu/drm/i915/display/intel_lspcon.c   | 14 +--
>  drivers/gpu/drm/i915/display/intel_lvds.c     | 23 +++--
>  drivers/gpu/drm/i915/display/intel_sdvo.c     |  6 +-
>  15 files changed, 119 insertions(+), 135 deletions(-)
> 
> -- 
> 2.41.0