mbox series

[net-next,v2,0/2] vsock: handle writes to shutdowned socket

Message ID 20230911202027.1928574-1-avkrasnov@salutedevices.com (mailing list archive)
Headers show
Series vsock: handle writes to shutdowned socket | expand

Message

Arseniy Krasnov Sept. 11, 2023, 8:20 p.m. UTC 
Hello,

this small patchset adds POSIX compliant behaviour on writes to the
socket which was shutdowned with 'shutdown()' (both sides - local with
SHUT_WR flag, peer - with SHUT_RD flag). According POSIX we must send
SIGPIPE in such cases (but SIGPIPE is not send when MSG_NOSIGNAL is set).

First patch is implemented in the same way as net/ipv4/tcp.c:tcp_sendmsg_locked().
It uses 'sk_stream_error()' function which handles EPIPE error. Another
way is to use code from net/unix/af_unix.c:unix_stream_sendmsg() where
same logic from 'sk_stream_error()' is implemented "from scratch", but
it doesn't check 'sk_err' field. I think error from this field has more
priority to be returned from syscall. So I guess it is better to reuse
currently implemented 'sk_stream_error()' function.

Test is also added.

Head for this patchset is:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=73be7fb14e83d24383f840a22f24d3ed222ca319

Link to v1:
https://lore.kernel.org/netdev/20230801141727.481156-1-AVKrasnov@sberdevices.ru/
Link to v2 (RFC):
https://lore.kernel.org/netdev/20230826175900.3693844-1-avkrasnov@salutedevices.com/

Changelog:
v1 -> v2:
 * 0001 stills the same - SIGPIPE is sent only for SOCK_STREAM as discussed in v1
   with Stefano Garzarella <sgarzare@redhat.com>.
 * 0002 - use 'sig_atomic_t' instead of 'bool' for flag variables updated from
   signal handler.

Arseniy Krasnov (2):
  vsock: send SIGPIPE on write to shutdowned socket
  test/vsock: shutdowned socket test

 net/vmw_vsock/af_vsock.c         |   3 +
 tools/testing/vsock/vsock_test.c | 138 +++++++++++++++++++++++++++++++
 2 files changed, 141 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org Sept. 14, 2023, 6:40 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 11 Sep 2023 23:20:25 +0300 you wrote:
> Hello,
> 
> this small patchset adds POSIX compliant behaviour on writes to the
> socket which was shutdowned with 'shutdown()' (both sides - local with
> SHUT_WR flag, peer - with SHUT_RD flag). According POSIX we must send
> SIGPIPE in such cases (but SIGPIPE is not send when MSG_NOSIGNAL is set).
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] vsock: send SIGPIPE on write to shutdowned socket
    https://git.kernel.org/netdev/net-next/c/8ecf0cedc08a
  - [net-next,v2,2/2] test/vsock: shutdowned socket test
    https://git.kernel.org/netdev/net-next/c/b698bd97c571

You are awesome, thank you!