| Message ID | cover.1693126687.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| Headers | show |
| Series | clk: imx: imx8: Fix some error handling paths | expand |
On 8/27/2023 5:37 PM, Christophe JAILLET wrote: > This serie fix some error handling paths. It is split in different patches to > ease review because the issues are unrelated and the proposed fixes are maybe > wrong (I don't have the hardware to test anything) > > Patch 2 and 3 are more speculative than the 3 oher ones. Review with care. > > > Finally, I got some problem when generating the serie, and some patches have > been hand-modified afterwards. > They look good to me, but I hope have not screwed up things... > > Christophe JAILLET (5): > clk: imx: imx8: Fix an error handling path in > clk_imx_acm_attach_pm_domains() > clk: imx: imx8: Fix an error handling path if > devm_clk_hw_register_mux_parent_data_table() fails > clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe() > clk: imx: imx8: Add a message in case of > devm_clk_hw_register_mux_parent_data_table() error > clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains() > > drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------ > 1 file changed, 15 insertions(+), 12 deletions(-) > LGTM, for the patchset Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > This serie fix some error handling paths. It is split in different patches to ease > review because the issues are unrelated and the proposed fixes are maybe > wrong (I don't have the hardware to test anything) > > Patch 2 and 3 are more speculative than the 3 oher ones. Review with care. > > > Finally, I got some problem when generating the serie, and some patches > have been hand-modified afterwards. > They look good to me, but I hope have not screwed up things... From the 3rd patch, it can't be applied, maybe there is generating issue. Best regards Wang Shengjiu > > Christophe JAILLET (5): > clk: imx: imx8: Fix an error handling path in > clk_imx_acm_attach_pm_domains() > clk: imx: imx8: Fix an error handling path if > devm_clk_hw_register_mux_parent_data_table() fails > clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe() > clk: imx: imx8: Add a message in case of > devm_clk_hw_register_mux_parent_data_table() error > clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains() > > drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------ > 1 file changed, 15 insertions(+), 12 deletions(-) > > -- > 2.34.1
Le 14/09/2023 à 12:22, S.J. Wang a écrit : >> >> This serie fix some error handling paths. It is split in different patches to ease >> review because the issues are unrelated and the proposed fixes are maybe >> wrong (I don't have the hardware to test anything) >> >> Patch 2 and 3 are more speculative than the 3 oher ones. Review with care. >> >> >> Finally, I got some problem when generating the serie, and some patches >> have been hand-modified afterwards. >> They look good to me, but I hope have not screwed up things... > > > From the 3rd patch, it can't be applied, maybe there is generating issue. I will resend. CJ > > Best regards > Wang Shengjiu > >> >> Christophe JAILLET (5): >> clk: imx: imx8: Fix an error handling path in >> clk_imx_acm_attach_pm_domains() >> clk: imx: imx8: Fix an error handling path if >> devm_clk_hw_register_mux_parent_data_table() fails >> clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe() >> clk: imx: imx8: Add a message in case of >> devm_clk_hw_register_mux_parent_data_table() error >> clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains() >> >> drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------ >> 1 file changed, 15 insertions(+), 12 deletions(-) >> >> -- >> 2.34.1 > >
This serie fix some error handling paths. It is split in different patches to ease review because the issues are unrelated and the proposed fixes are maybe wrong (I don't have the hardware to test anything) Patch 2 and 3 are more speculative than the 3 oher ones. Review with care. Finally, I got some problem when generating the serie, and some patches have been hand-modified afterwards. They look good to me, but I hope have not screwed up things... Christophe JAILLET (5): clk: imx: imx8: Fix an error handling path in clk_imx_acm_attach_pm_domains() clk: imx: imx8: Fix an error handling path if devm_clk_hw_register_mux_parent_data_table() fails clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe() clk: imx: imx8: Add a message in case of devm_clk_hw_register_mux_parent_data_table() error clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains() drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-)