| Message ID | 20230914111712.586522-1-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pmdomain: Move Kconfig options/files to the pmdomain subsystem | expand |
On Thu, 14 Sept 2023 at 12:24, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > The Kconfig option belongs closer to the corresponding implementation, > hence let's move it from the soc subsystem to the pmdomain subsystem. > > Cc: Hector Martin <marcan@marcan.st> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io> > Cc: <asahi@lists.linux.dev> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Makes sense, since the C code and Makefile is there now. Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > --- > drivers/pmdomain/Kconfig | 1 + > drivers/pmdomain/apple/Kconfig | 18 ++++++++++++++++++ > drivers/soc/apple/Kconfig | 13 ------------- > 3 files changed, 19 insertions(+), 13 deletions(-) > create mode 100644 drivers/pmdomain/apple/Kconfig > > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig > index 07d2f8165abe..55a9ca191849 100644 > --- a/drivers/pmdomain/Kconfig > +++ b/drivers/pmdomain/Kconfig > @@ -3,5 +3,6 @@ menu "Power Domains Support" > > source "drivers/pmdomain/actions/Kconfig" > source "drivers/pmdomain/amlogic/Kconfig" > +source "drivers/pmdomain/apple/Kconfig" > > endmenu > diff --git a/drivers/pmdomain/apple/Kconfig b/drivers/pmdomain/apple/Kconfig > new file mode 100644 > index 000000000000..12237cbcfaa9 > --- /dev/null > +++ b/drivers/pmdomain/apple/Kconfig > @@ -0,0 +1,18 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +if ARCH_APPLE || COMPILE_TEST > + > +config APPLE_PMGR_PWRSTATE > + bool "Apple SoC PMGR power state control" > + depends on PM > + select REGMAP > + select MFD_SYSCON > + select PM_GENERIC_DOMAINS > + select RESET_CONTROLLER > + default ARCH_APPLE > + help > + The PMGR block in Apple SoCs provides high-level power state > + controls for SoC devices. This driver manages them through the > + generic power domain framework, and also provides reset support. > + > +endif > diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig > index a1596fefacff..eff486a77337 100644 > --- a/drivers/soc/apple/Kconfig > +++ b/drivers/soc/apple/Kconfig > @@ -4,19 +4,6 @@ if ARCH_APPLE || COMPILE_TEST > > menu "Apple SoC drivers" > > -config APPLE_PMGR_PWRSTATE > - bool "Apple SoC PMGR power state control" > - depends on PM > - select REGMAP > - select MFD_SYSCON > - select PM_GENERIC_DOMAINS > - select RESET_CONTROLLER > - default ARCH_APPLE > - help > - The PMGR block in Apple SoCs provides high-level power state > - controls for SoC devices. This driver manages them through the > - generic power domain framework, and also provides reset support. > - > config APPLE_RTKIT > tristate "Apple RTKit co-processor IPC protocol" > depends on MAILBOX > -- > 2.34.1 > >
On Thu, Sep 14, 2023 at 7:17 AM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > The Kconfig option belongs closer to the corresponding implementation, > hence let's move it from the soc subsystem to the pmdomain subsystem. > > Cc: Hector Martin <marcan@marcan.st> > Cc: Sven Peter <sven@svenpeter.dev> > Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io> > Cc: <asahi@lists.linux.dev> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > drivers/pmdomain/Kconfig | 1 + > drivers/pmdomain/apple/Kconfig | 18 ++++++++++++++++++ > drivers/soc/apple/Kconfig | 13 ------------- > 3 files changed, 19 insertions(+), 13 deletions(-) > create mode 100644 drivers/pmdomain/apple/Kconfig > > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig > index 07d2f8165abe..55a9ca191849 100644 > --- a/drivers/pmdomain/Kconfig > +++ b/drivers/pmdomain/Kconfig > @@ -3,5 +3,6 @@ menu "Power Domains Support" > > source "drivers/pmdomain/actions/Kconfig" > source "drivers/pmdomain/amlogic/Kconfig" > +source "drivers/pmdomain/apple/Kconfig" > > endmenu > diff --git a/drivers/pmdomain/apple/Kconfig b/drivers/pmdomain/apple/Kconfig > new file mode 100644 > index 000000000000..12237cbcfaa9 > --- /dev/null > +++ b/drivers/pmdomain/apple/Kconfig > @@ -0,0 +1,18 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +if ARCH_APPLE || COMPILE_TEST > + > +config APPLE_PMGR_PWRSTATE > + bool "Apple SoC PMGR power state control" > + depends on PM > + select REGMAP > + select MFD_SYSCON > + select PM_GENERIC_DOMAINS > + select RESET_CONTROLLER > + default ARCH_APPLE > + help > + The PMGR block in Apple SoCs provides high-level power state > + controls for SoC devices. This driver manages them through the > + generic power domain framework, and also provides reset support. > + > +endif > diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig > index a1596fefacff..eff486a77337 100644 > --- a/drivers/soc/apple/Kconfig > +++ b/drivers/soc/apple/Kconfig > @@ -4,19 +4,6 @@ if ARCH_APPLE || COMPILE_TEST > > menu "Apple SoC drivers" > > -config APPLE_PMGR_PWRSTATE > - bool "Apple SoC PMGR power state control" > - depends on PM > - select REGMAP > - select MFD_SYSCON > - select PM_GENERIC_DOMAINS > - select RESET_CONTROLLER > - default ARCH_APPLE > - help > - The PMGR block in Apple SoCs provides high-level power state > - controls for SoC devices. This driver manages them through the > - generic power domain framework, and also provides reset support. > - > config APPLE_RTKIT > tristate "Apple RTKit co-processor IPC protocol" > depends on MAILBOX > -- > 2.34.1 > Makes sense to me. Reviewed-by: Neal Gompa <neal@gompa.dev>
diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig index 07d2f8165abe..55a9ca191849 100644 --- a/drivers/pmdomain/Kconfig +++ b/drivers/pmdomain/Kconfig @@ -3,5 +3,6 @@ menu "Power Domains Support" source "drivers/pmdomain/actions/Kconfig" source "drivers/pmdomain/amlogic/Kconfig" +source "drivers/pmdomain/apple/Kconfig" endmenu diff --git a/drivers/pmdomain/apple/Kconfig b/drivers/pmdomain/apple/Kconfig new file mode 100644 index 000000000000..12237cbcfaa9 --- /dev/null +++ b/drivers/pmdomain/apple/Kconfig @@ -0,0 +1,18 @@ +# SPDX-License-Identifier: GPL-2.0-only + +if ARCH_APPLE || COMPILE_TEST + +config APPLE_PMGR_PWRSTATE + bool "Apple SoC PMGR power state control" + depends on PM + select REGMAP + select MFD_SYSCON + select PM_GENERIC_DOMAINS + select RESET_CONTROLLER + default ARCH_APPLE + help + The PMGR block in Apple SoCs provides high-level power state + controls for SoC devices. This driver manages them through the + generic power domain framework, and also provides reset support. + +endif diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig index a1596fefacff..eff486a77337 100644 --- a/drivers/soc/apple/Kconfig +++ b/drivers/soc/apple/Kconfig @@ -4,19 +4,6 @@ if ARCH_APPLE || COMPILE_TEST menu "Apple SoC drivers" -config APPLE_PMGR_PWRSTATE - bool "Apple SoC PMGR power state control" - depends on PM - select REGMAP - select MFD_SYSCON - select PM_GENERIC_DOMAINS - select RESET_CONTROLLER - default ARCH_APPLE - help - The PMGR block in Apple SoCs provides high-level power state - controls for SoC devices. This driver manages them through the - generic power domain framework, and also provides reset support. - config APPLE_RTKIT tristate "Apple RTKit co-processor IPC protocol" depends on MAILBOX
The Kconfig option belongs closer to the corresponding implementation, hence let's move it from the soc subsystem to the pmdomain subsystem. Cc: Hector Martin <marcan@marcan.st> Cc: Sven Peter <sven@svenpeter.dev> Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io> Cc: <asahi@lists.linux.dev> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/pmdomain/Kconfig | 1 + drivers/pmdomain/apple/Kconfig | 18 ++++++++++++++++++ drivers/soc/apple/Kconfig | 13 ------------- 3 files changed, 19 insertions(+), 13 deletions(-) create mode 100644 drivers/pmdomain/apple/Kconfig