| Message ID | E1qgmkk-007Z4l-BK@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: add and use library for setting clock | expand |
On Thu, Sep 14, 2023 at 02:51:30PM +0100, Russell King (Oracle) wrote: > Use stmmac_set_tx_clk_gmii(). > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > --- > .../stmicro/stmmac/dwmac-intel-plat.c | 34 +++++-------------- > 1 file changed, 8 insertions(+), 26 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > index d352a14f9d48..c6ebd1d91f38 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > @@ -31,32 +31,14 @@ struct intel_dwmac_data { > static void kmb_eth_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) > { > struct intel_dwmac *dwmac = priv; > - unsigned long rate; > - int ret; > - > - rate = clk_get_rate(dwmac->tx_clk); > - > - switch (speed) { > - case SPEED_1000: > - rate = 125000000; > - break; > - > - case SPEED_100: > - rate = 25000000; > - break; > - > - case SPEED_10: > - rate = 2500000; > - break; > - > - default: > - dev_err(dwmac->dev, "Invalid speed\n"); > - break; > - } > - > - ret = clk_set_rate(dwmac->tx_clk, rate); > - if (ret) > - dev_err(dwmac->dev, "Failed to configure tx clock rate\n"); > + int err; > + > + err = stmmac_set_tx_clk_gmii(dwmac->tx_clk, speed); > + if (err == -ENOTSUPP) > + dev_err(dwmac->dev, "invalid speed %uMbps\n", speed); > + else if (err) > + dev_err(dwmac->dev, "failed to set tx rate for speed %uMbps: %pe\n", > + speed, ERR_PTR(err)); > } > > static const struct intel_dwmac_data kmb_data = { > -- > 2.30.2 > >
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c index d352a14f9d48..c6ebd1d91f38 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c @@ -31,32 +31,14 @@ struct intel_dwmac_data { static void kmb_eth_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) { struct intel_dwmac *dwmac = priv; - unsigned long rate; - int ret; - - rate = clk_get_rate(dwmac->tx_clk); - - switch (speed) { - case SPEED_1000: - rate = 125000000; - break; - - case SPEED_100: - rate = 25000000; - break; - - case SPEED_10: - rate = 2500000; - break; - - default: - dev_err(dwmac->dev, "Invalid speed\n"); - break; - } - - ret = clk_set_rate(dwmac->tx_clk, rate); - if (ret) - dev_err(dwmac->dev, "Failed to configure tx clock rate\n"); + int err; + + err = stmmac_set_tx_clk_gmii(dwmac->tx_clk, speed); + if (err == -ENOTSUPP) + dev_err(dwmac->dev, "invalid speed %uMbps\n", speed); + else if (err) + dev_err(dwmac->dev, "failed to set tx rate for speed %uMbps: %pe\n", + speed, ERR_PTR(err)); } static const struct intel_dwmac_data kmb_data = {
Use stmmac_set_tx_clk_gmii(). Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- .../stmicro/stmmac/dwmac-intel-plat.c | 34 +++++-------------- 1 file changed, 8 insertions(+), 26 deletions(-)