diff mbox series

[2/3] vdpa net: stop probing if cannot set features

Message ID 20230915170322.3076956-3-eperezma@redhat.com (mailing list archive)
State New, archived
Headers show
Series Follow VirtIO initialization properly at vdpa net cvq isolation probing | expand

Commit Message

Eugenio Perez Martin Sept. 15, 2023, 5:03 p.m. UTC 
Otherwise it continues the CVQ isolation probing.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 net/vhost-vdpa.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Philippe Mathieu-Daudé Sept. 15, 2023, 5:07 p.m. UTC | #1 
On 15/9/23 19:03, Eugenio Pérez wrote:
> Otherwise it continues the CVQ isolation probing.
> 

Fixes: 152128d646 ("vdpa: move CVQ isolation check to net_init_vhost_vdpa")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
>   net/vhost-vdpa.c | 1 +
>   1 file changed, 1 insertion(+)
Jason Wang Sept. 18, 2023, 8:55 a.m. UTC | #2 
On Sat, Sep 16, 2023 at 1:03 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Otherwise it continues the CVQ isolation probing.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks

> ---
>  net/vhost-vdpa.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 9845e2db9c..51d8144070 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -1289,6 +1289,7 @@ static int vhost_vdpa_probe_cvq_isolation(int device_fd, uint64_t features,
>      r = ioctl(device_fd, VHOST_SET_FEATURES, &features);
>      if (unlikely(r)) {
>          error_setg_errno(errp, errno, "Cannot set features");
> +        goto out;
>      }
>
>      r = ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status);
> --
> 2.39.3
>
diff mbox series

Patch

diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 9845e2db9c..51d8144070 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -1289,6 +1289,7 @@  static int vhost_vdpa_probe_cvq_isolation(int device_fd, uint64_t features,
     r = ioctl(device_fd, VHOST_SET_FEATURES, &features);
     if (unlikely(r)) {
         error_setg_errno(errp, errno, "Cannot set features");
+        goto out;
     }
 
     r = ioctl(device_fd, VHOST_VDPA_SET_STATUS, &status);