diff mbox series

drm/i915: Remove runtime suspended boolean from intel_runtime_pm struct

Message ID 20230913100430.3433969-1-jouni.hogander@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915: Remove runtime suspended boolean from intel_runtime_pm struct | expand

Commit Message

Hogander, Jouni Sept. 13, 2023, 10:04 a.m. UTC
It's not necessary to carry separate suspended status information in
intel_runtime_pm struct as this information is already in underlying device
structure. Remove it and use pm_runtime_suspended() to obtain suspended
status information when needed.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
 drivers/gpu/drm/i915/i915_driver.c                 | 3 ---
 drivers/gpu/drm/i915/i915_gpu_error.c              | 2 +-
 drivers/gpu/drm/i915/intel_runtime_pm.c            | 1 -
 drivers/gpu/drm/i915/intel_runtime_pm.h            | 4 ++--
 5 files changed, 4 insertions(+), 8 deletions(-)

Comments

Jani Nikula Sept. 13, 2023, 12:02 p.m. UTC | #1
On Wed, 13 Sep 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> It's not necessary to carry separate suspended status information in
> intel_runtime_pm struct as this information is already in underlying device
> structure. Remove it and use pm_runtime_suspended() to obtain suspended
> status information when needed.

I started wondering if this is racy, and my conclusion is that it's
"less" racy than the original. rpm->suspended gets toggled in the middle
of the suspend/resume sequences. So it could be halfway. Dunno if
anything *after* those toggles depends on the state having been changed
already; didn't find any. Maybe Imre has a better idea.

Also, pm_runtime_suspended() seems more reliable when suspend/resume
fails.

Acked-by: Jani Nikula <jani.nikula@intel.com>


>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
>  drivers/gpu/drm/i915/i915_driver.c                 | 3 ---
>  drivers/gpu/drm/i915/i915_gpu_error.c              | 2 +-
>  drivers/gpu/drm/i915/intel_runtime_pm.c            | 1 -
>  drivers/gpu/drm/i915/intel_runtime_pm.h            | 4 ++--
>  5 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 68cf5e6b0b46..889bb26009a2 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -216,7 +216,7 @@ bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
>  	struct i915_power_well *power_well;
>  	bool is_enabled;
>  
> -	if (dev_priv->runtime_pm.suspended)
> +	if (pm_runtime_suspended(dev_priv->drm.dev))
>  		return false;
>  
>  	is_enabled = true;
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index f8dbee7a5af7..cd98ee740976 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -1569,8 +1569,6 @@ static int intel_runtime_suspend(struct device *kdev)
>  	if (root_pdev)
>  		pci_d3cold_disable(root_pdev);
>  
> -	rpm->suspended = true;
> -
>  	/*
>  	 * FIXME: We really should find a document that references the arguments
>  	 * used below!
> @@ -1621,7 +1619,6 @@ static int intel_runtime_resume(struct device *kdev)
>  	disable_rpm_wakeref_asserts(rpm);
>  
>  	intel_opregion_notify_adapter(dev_priv, PCI_D0);
> -	rpm->suspended = false;
>  
>  	root_pdev = pcie_find_root_port(pdev);
>  	if (root_pdev)
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 4008bb09fdb5..a60bab177c55 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -1972,7 +1972,7 @@ static void capture_gen(struct i915_gpu_coredump *error)
>  	struct drm_i915_private *i915 = error->i915;
>  
>  	error->wakelock = atomic_read(&i915->runtime_pm.wakeref_count);
> -	error->suspended = i915->runtime_pm.suspended;
> +	error->suspended = pm_runtime_suspended(i915->drm.dev);
>  
>  	error->iommu = i915_vtd_active(i915);
>  	error->reset_count = i915_reset_count(&i915->gpu_error);
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 6d8e5e5c0cba..8743153fad87 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -652,7 +652,6 @@ void intel_runtime_pm_init_early(struct intel_runtime_pm *rpm)
>  
>  	rpm->kdev = kdev;
>  	rpm->available = HAS_RUNTIME_PM(i915);
> -	rpm->suspended = false;
>  	atomic_set(&rpm->wakeref_count, 0);
>  
>  	init_intel_runtime_pm_wakeref(rpm);
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h b/drivers/gpu/drm/i915/intel_runtime_pm.h
> index 764b183ae452..f79cda7a2503 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.h
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
> @@ -6,6 +6,7 @@
>  #ifndef __INTEL_RUNTIME_PM_H__
>  #define __INTEL_RUNTIME_PM_H__
>  
> +#include <linux/pm_runtime.h>
>  #include <linux/types.h>
>  
>  #include "intel_wakeref.h"
> @@ -43,7 +44,6 @@ struct intel_runtime_pm {
>  	atomic_t wakeref_count;
>  	struct device *kdev; /* points to i915->drm.dev */
>  	bool available;
> -	bool suspended;
>  	bool irqs_enabled;
>  	bool no_wakeref_tracking;
>  
> @@ -110,7 +110,7 @@ intel_rpm_wakelock_count(int wakeref_count)
>  static inline void
>  assert_rpm_device_not_suspended(struct intel_runtime_pm *rpm)
>  {
> -	WARN_ONCE(rpm->suspended,
> +	WARN_ONCE(pm_runtime_suspended(rpm->kdev),
>  		  "Device suspended during HW access\n");
>  }
Imre Deak Sept. 13, 2023, 3:01 p.m. UTC | #2
On Wed, Sep 13, 2023 at 03:02:58PM +0300, Jani Nikula wrote:
> On Wed, 13 Sep 2023, Jouni Högander <jouni.hogander@intel.com> wrote:
> > It's not necessary to carry separate suspended status information in
> > intel_runtime_pm struct as this information is already in underlying device
> > structure. Remove it and use pm_runtime_suspended() to obtain suspended
> > status information when needed.
> 
> I started wondering if this is racy, and my conclusion is that it's
> "less" racy than the original. rpm->suspended gets toggled in the middle
> of the suspend/resume sequences. So it could be halfway. Dunno if
> anything *after* those toggles depends on the state having been changed
> already; didn't find any. Maybe Imre has a better idea.
> 
> Also, pm_runtime_suspended() seems more reliable when suspend/resume
> fails.

The flag was added in the initial runtime PM enabling patch to detect
MMIO accesses while runtime suspended, looks like pm_runtime_suspended()
would've worked ok already at that point.

I wondered how the above detection would change in the system suspend /
resume handlers but that looks ok as well with the disable_depth check
in pm_runtime_suspended():
Reviewed-by: Imre Deak <imre.deak@intel.com>

> Acked-by: Jani Nikula <jani.nikula@intel.com>
> 
> 
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> >
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> >  drivers/gpu/drm/i915/i915_driver.c                 | 3 ---
> >  drivers/gpu/drm/i915/i915_gpu_error.c              | 2 +-
> >  drivers/gpu/drm/i915/intel_runtime_pm.c            | 1 -
> >  drivers/gpu/drm/i915/intel_runtime_pm.h            | 4 ++--
> >  5 files changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> > index 68cf5e6b0b46..889bb26009a2 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> > @@ -216,7 +216,7 @@ bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
> >  	struct i915_power_well *power_well;
> >  	bool is_enabled;
> >  
> > -	if (dev_priv->runtime_pm.suspended)
> > +	if (pm_runtime_suspended(dev_priv->drm.dev))
> >  		return false;
> >  
> >  	is_enabled = true;
> > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> > index f8dbee7a5af7..cd98ee740976 100644
> > --- a/drivers/gpu/drm/i915/i915_driver.c
> > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > @@ -1569,8 +1569,6 @@ static int intel_runtime_suspend(struct device *kdev)
> >  	if (root_pdev)
> >  		pci_d3cold_disable(root_pdev);
> >  
> > -	rpm->suspended = true;
> > -
> >  	/*
> >  	 * FIXME: We really should find a document that references the arguments
> >  	 * used below!
> > @@ -1621,7 +1619,6 @@ static int intel_runtime_resume(struct device *kdev)
> >  	disable_rpm_wakeref_asserts(rpm);
> >  
> >  	intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > -	rpm->suspended = false;
> >  
> >  	root_pdev = pcie_find_root_port(pdev);
> >  	if (root_pdev)
> > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> > index 4008bb09fdb5..a60bab177c55 100644
> > --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> > @@ -1972,7 +1972,7 @@ static void capture_gen(struct i915_gpu_coredump *error)
> >  	struct drm_i915_private *i915 = error->i915;
> >  
> >  	error->wakelock = atomic_read(&i915->runtime_pm.wakeref_count);
> > -	error->suspended = i915->runtime_pm.suspended;
> > +	error->suspended = pm_runtime_suspended(i915->drm.dev);
> >  
> >  	error->iommu = i915_vtd_active(i915);
> >  	error->reset_count = i915_reset_count(&i915->gpu_error);
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index 6d8e5e5c0cba..8743153fad87 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -652,7 +652,6 @@ void intel_runtime_pm_init_early(struct intel_runtime_pm *rpm)
> >  
> >  	rpm->kdev = kdev;
> >  	rpm->available = HAS_RUNTIME_PM(i915);
> > -	rpm->suspended = false;
> >  	atomic_set(&rpm->wakeref_count, 0);
> >  
> >  	init_intel_runtime_pm_wakeref(rpm);
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h b/drivers/gpu/drm/i915/intel_runtime_pm.h
> > index 764b183ae452..f79cda7a2503 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.h
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
> > @@ -6,6 +6,7 @@
> >  #ifndef __INTEL_RUNTIME_PM_H__
> >  #define __INTEL_RUNTIME_PM_H__
> >  
> > +#include <linux/pm_runtime.h>
> >  #include <linux/types.h>
> >  
> >  #include "intel_wakeref.h"
> > @@ -43,7 +44,6 @@ struct intel_runtime_pm {
> >  	atomic_t wakeref_count;
> >  	struct device *kdev; /* points to i915->drm.dev */
> >  	bool available;
> > -	bool suspended;
> >  	bool irqs_enabled;
> >  	bool no_wakeref_tracking;
> >  
> > @@ -110,7 +110,7 @@ intel_rpm_wakelock_count(int wakeref_count)
> >  static inline void
> >  assert_rpm_device_not_suspended(struct intel_runtime_pm *rpm)
> >  {
> > -	WARN_ONCE(rpm->suspended,
> > +	WARN_ONCE(pm_runtime_suspended(rpm->kdev),
> >  		  "Device suspended during HW access\n");
> >  }
> 
> -- 
> Jani Nikula, Intel
Hogander, Jouni Sept. 18, 2023, 5:41 a.m. UTC | #3
On Fri, 2023-09-15 at 15:59 +0000, Patchwork wrote:
Patch Details
Series: drm/i915: Remove runtime suspended boolean from intel_runtime_pm struct (rev4)
URL:    https://patchwork.freedesktop.org/series/123637/
State:  failure
Details:        https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/index.html
CI Bug Log - changes from CI_DRM_13635_full -> Patchwork_123637v4_full
Summary

FAILURE

Serious unknown changes coming with Patchwork_123637v4_full absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_123637v4_full, please notify your bug team (lgci.bug.filing@intel.com) to allow them
to document this new failure mode, which will reduce false positives in CI.

Participating hosts (9 -> 9)

No changes in participating hosts

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_123637v4_full:

IGT changes
Possible regressions

  *   igt@gem_create@create-clear@smem0:
     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-6/igt@gem_create@create-clear@smem0.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-5/igt@gem_create@create-clear@smem0.html>

i can't see how this could be related. Also there is already similar failure earlier:

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13640/shard-mtlp-5/igt@gem_exec_capture@pi@ccs0.html#dmesg-warnings24

BR,

Jouni Högander

Known issues

Here are the changes found in Patchwork_123637v4_full that come from known issues:

IGT changes
Issues hit

  *   igt@api_intel_bb@blit-reloc-purge-cache:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@api_intel_bb@blit-reloc-purge-cache.html> (i915#8411<https://gitlab.freedesktop.org/drm/intel/issues/8411>)
  *   igt@device_reset@unbind-cold-reset-rebind:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@device_reset@unbind-cold-reset-rebind.html> (i915#7701<https://gitlab.freedesktop.org/drm/intel/issues/7701>)
  *   igt@drm_buddy@drm_buddy_test:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@drm_buddy@drm_buddy_test.html> (i915#8661<https://gitlab.freedesktop.org/drm/intel/issues/8661>)
  *   igt@drm_fdinfo@virtual-busy-all:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@drm_fdinfo@virtual-busy-all.html> (i915#8414<https://gitlab.freedesktop.org/drm/intel/issues/8414>)
  *   igt@gem_ccs@suspend-resume:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_ccs@suspend-resume.html> (i915#9323<https://gitlab.freedesktop.org/drm/intel/issues/9323>)
  *   igt@gem_ccs@suspend-resume@tile64-compressed-compfmt0-smem-lmem0:

     *   shard-dg2: NOTRUN -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-2/igt@gem_ccs@suspend-resume@tile64-compressed-compfmt0-smem-lmem0.html> (i915#7297<https://gitlab.freedesktop.org/drm/intel/issues/7297>)
  *   igt@gem_ctx_exec@basic-nohangcheck:

     *   shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-7/igt@gem_ctx_exec@basic-nohangcheck.html> (i915#6268<https://gitlab.freedesktop.org/drm/intel/issues/6268>)
  *   igt@gem_ctx_isolation@preservation@vcs1:

     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-3/igt@gem_ctx_isolation@preservation@vcs1.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-1/igt@gem_ctx_isolation@preservation@vcs1.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>) +1 other test abort
  *   igt@gem_ctx_persistence@engines-hang@vcs0:

     *   shard-mtlp: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_ctx_persistence@engines-hang@vcs0.html> (i915#2410<https://gitlab.freedesktop.org/drm/intel/issues/2410>)
  *   igt@gem_ctx_persistence@hang:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb4/igt@gem_ctx_persistence@hang.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#1099<https://gitlab.freedesktop.org/drm/intel/issues/1099>)
  *   igt@gem_eio@hibernate:

     *   shard-dg1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg1-18/igt@gem_eio@hibernate.html> -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-14/igt@gem_eio@hibernate.html> (i915#7975<https://gitlab.freedesktop.org/drm/intel/issues/7975> / i915#8213<https://gitlab.freedesktop.org/drm/intel/issues/8213>)
  *   igt@gem_eio@in-flight-suspend:

     *   shard-mtlp: NOTRUN -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@gem_eio@in-flight-suspend.html> (i915#7892<https://gitlab.freedesktop.org/drm/intel/issues/7892> / i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>)
  *   igt@gem_eio@reset-stress:

     *   shard-dg1: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg1-18/igt@gem_eio@reset-stress.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-14/igt@gem_eio@reset-stress.html> (i915#5784<https://gitlab.freedesktop.org/drm/intel/issues/5784>)
  *   igt@gem_exec_balancer@bonded-dual:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_exec_balancer@bonded-dual.html> (i915#4771<https://gitlab.freedesktop.org/drm/intel/issues/4771>)
  *   igt@gem_exec_fair@basic-flow@rcs0:

     *   shard-tglu: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-tglu-2/igt@gem_exec_fair@basic-flow@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-tglu-8/igt@gem_exec_fair@basic-flow@rcs0.html> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>)
  *   igt@gem_exec_fair@basic-pace@rcs0:

     *   shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>)
  *   igt@gem_exec_fence@submit3:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_exec_fence@submit3.html> (i915#4812<https://gitlab.freedesktop.org/drm/intel/issues/4812>)
  *   igt@gem_exec_params@secure-non-master:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_exec_params@secure-non-master.html> (fdo#112283<https://bugs.freedesktop.org/show_bug.cgi?id=112283>)
  *   igt@gem_exec_reloc@basic-cpu-gtt-active:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_exec_reloc@basic-cpu-gtt-active.html> (i915#3281<https://gitlab.freedesktop.org/drm/intel/issues/3281>) +1 other test skip
  *   igt@gem_exec_reloc@basic-cpu-read-noreloc:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@gem_exec_reloc@basic-cpu-read-noreloc.html> (i915#3281<https://gitlab.freedesktop.org/drm/intel/issues/3281>) +1 other test skip
  *   igt@gem_exec_reloc@basic-write-wc-noreloc:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gem_exec_reloc@basic-write-wc-noreloc.html> (i915#3281<https://gitlab.freedesktop.org/drm/intel/issues/3281>)
  *   igt@gem_exec_schedule@noreorder@bcs0:

     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-7/igt@gem_exec_schedule@noreorder@bcs0.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_exec_schedule@noreorder@bcs0.html> (i915#9121<https://gitlab.freedesktop.org/drm/intel/issues/9121>)
  *   igt@gem_exec_schedule@noreorder@ccs0:

     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-7/igt@gem_exec_schedule@noreorder@ccs0.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_exec_schedule@noreorder@ccs0.html> (i915#8962<https://gitlab.freedesktop.org/drm/intel/issues/8962> / i915#9121<https://gitlab.freedesktop.org/drm/intel/issues/9121>)
  *   igt@gem_exec_schedule@noreorder@rcs0:

     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-7/igt@gem_exec_schedule@noreorder@rcs0.html> -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_exec_schedule@noreorder@rcs0.html> (i915#9121<https://gitlab.freedesktop.org/drm/intel/issues/9121>)
  *   igt@gem_exec_schedule@preempt-queue-chain:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_exec_schedule@preempt-queue-chain.html> (i915#4537<https://gitlab.freedesktop.org/drm/intel/issues/4537> / i915#4812<https://gitlab.freedesktop.org/drm/intel/issues/4812>)
  *   igt@gem_fenced_exec_thrash@too-many-fences:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_fenced_exec_thrash@too-many-fences.html> (i915#4860<https://gitlab.freedesktop.org/drm/intel/issues/4860>)
  *   igt@gem_lmem_swapping@heavy-verify-random-ccs:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@gem_lmem_swapping@heavy-verify-random-ccs.html> (i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>)
  *   igt@gem_lmem_swapping@parallel-random-verify:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl3/igt@gem_lmem_swapping@parallel-random-verify.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>)
  *   igt@gem_lmem_swapping@parallel-random-verify-ccs@lmem0:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gem_lmem_swapping@parallel-random-verify-ccs@lmem0.html> (i915#4565<https://gitlab.freedesktop.org/drm/intel/issues/4565>)
  *   igt@gem_madvise@dontneed-before-pwrite:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_madvise@dontneed-before-pwrite.html> (i915#3282<https://gitlab.freedesktop.org/drm/intel/issues/3282>) +1 other test skip
  *   igt@gem_mmap_gtt@bad-object:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_mmap_gtt@bad-object.html> (i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +3 other tests skip
  *   igt@gem_mmap_gtt@cpuset-big-copy-odd:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gem_mmap_gtt@cpuset-big-copy-odd.html> (i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +4 other tests skip
  *   igt@gem_mmap_wc@read:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gem_mmap_wc@read.html> (i915#4083<https://gitlab.freedesktop.org/drm/intel/issues/4083>)
  *   igt@gem_partial_pwrite_pread@reads-display:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_partial_pwrite_pread@reads-display.html> (i915#3282<https://gitlab.freedesktop.org/drm/intel/issues/3282>) +3 other tests skip
  *   igt@gem_pxp@regular-baseline-src-copy-readible:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gem_pxp@regular-baseline-src-copy-readible.html> (i915#4270<https://gitlab.freedesktop.org/drm/intel/issues/4270>)
  *   igt@gem_render_copy@linear-to-vebox-yf-tiled:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_render_copy@linear-to-vebox-yf-tiled.html> (i915#5190<https://gitlab.freedesktop.org/drm/intel/issues/5190>) +3 other tests skip
  *   igt@gem_set_tiling_vs_blt@tiled-to-untiled:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html> (i915#4079<https://gitlab.freedesktop.org/drm/intel/issues/4079>)
  *   igt@gem_userptr_blits@dmabuf-sync:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_userptr_blits@dmabuf-sync.html> (i915#3297<https://gitlab.freedesktop.org/drm/intel/issues/3297>)
  *   igt@gem_userptr_blits@vma-merge:

     *   shard-dg2: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gem_userptr_blits@vma-merge.html> (i915#3318<https://gitlab.freedesktop.org/drm/intel/issues/3318>)
  *   igt@gen7_exec_parse@basic-allocation:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gen7_exec_parse@basic-allocation.html> (fdo#109289<https://bugs.freedesktop.org/show_bug.cgi?id=109289>)
  *   igt@gen7_exec_parse@basic-offset:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gen7_exec_parse@basic-offset.html> (fdo#109289<https://bugs.freedesktop.org/show_bug.cgi?id=109289>) +2 other tests skip
  *   igt@gen9_exec_parse@basic-rejected:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@gen9_exec_parse@basic-rejected.html> (i915#2856<https://gitlab.freedesktop.org/drm/intel/issues/2856>)
  *   igt@gen9_exec_parse@bb-start-param:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@gen9_exec_parse@bb-start-param.html> (i915#2856<https://gitlab.freedesktop.org/drm/intel/issues/2856>)
  *   igt@i915_hangman@engine-error-state-capture@vcs1:

     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-7/igt@i915_hangman@engine-error-state-capture@vcs1.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-6/igt@i915_hangman@engine-error-state-capture@vcs1.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>)
  *   igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:

     *   shard-rkl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-1/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html> (i915#1397<https://gitlab.freedesktop.org/drm/intel/issues/1397>)
  *   igt@i915_pm_rpm@modeset-non-lpsp:

     *   shard-dg2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg2-11/igt@i915_pm_rpm@modeset-non-lpsp.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp.html> (i915#1397<https://gitlab.freedesktop.org/drm/intel/issues/1397>) +1 other test skip
  *   igt@i915_pm_rps@min-max-config-loaded:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@i915_pm_rps@min-max-config-loaded.html> (i915#6621<https://gitlab.freedesktop.org/drm/intel/issues/6621>)
  *   igt@i915_query@query-topology-coherent-slice-mask:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@i915_query@query-topology-coherent-slice-mask.html> (i915#6188<https://gitlab.freedesktop.org/drm/intel/issues/6188>)
  *   igt@i915_query@query-topology-unsupported:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@i915_query@query-topology-unsupported.html> (fdo#109302<https://bugs.freedesktop.org/show_bug.cgi?id=109302>)
  *   igt@i915_query@test-query-geometry-subslices:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@i915_query@test-query-geometry-subslices.html> (i915#5723<https://gitlab.freedesktop.org/drm/intel/issues/5723>)
  *   igt@i915_selftest@mock@memory_region:

     *   shard-snb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb4/igt@i915_selftest@mock@memory_region.html> (i915#9312<https://gitlab.freedesktop.org/drm/intel/issues/9312>)
  *   igt@i915_suspend@fence-restore-tiled2untiled:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@i915_suspend@fence-restore-tiled2untiled.html> (i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1 other test skip
  *   igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs:

     *   shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-4/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs.html> (i915#8502<https://gitlab.freedesktop.org/drm/intel/issues/8502>) +3 other tests skip
  *   igt@kms_async_flips@crc@pipe-a-hdmi-a-3:

     *   shard-dg2: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-3/igt@kms_async_flips@crc@pipe-a-hdmi-a-3.html> (i915#8247<https://gitlab.freedesktop.org/drm/intel/issues/8247>) +3 other tests fail
  *   igt@kms_async_flips@crc@pipe-d-hdmi-a-4:

     *   shard-dg1: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-16/igt@kms_async_flips@crc@pipe-d-hdmi-a-4.html> (i915#8247<https://gitlab.freedesktop.org/drm/intel/issues/8247>) +3 other tests fail
  *   igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html> (i915#4538<https://gitlab.freedesktop.org/drm/intel/issues/4538> / i915#5286<https://gitlab.freedesktop.org/drm/intel/issues/5286>)
  *   igt@kms_big_fb@x-tiled-16bpp-rotate-90:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@kms_big_fb@x-tiled-16bpp-rotate-90.html> (fdo#111614<https://bugs.freedesktop.org/show_bug.cgi?id=111614>)
  *   igt@kms_big_fb@x-tiled-32bpp-rotate-90:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html> (i915#3638<https://gitlab.freedesktop.org/drm/intel/issues/3638>)
  *   igt@kms_big_fb@x-tiled-64bpp-rotate-90:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_big_fb@x-tiled-64bpp-rotate-90.html> (fdo#111614<https://bugs.freedesktop.org/show_bug.cgi?id=111614>)
  *   igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:

     *   shard-tglu: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-tglu-4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-tglu-9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html> (i915#3743<https://gitlab.freedesktop.org/drm/intel/issues/3743>)
  *   igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +58 other tests skip
  *   igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html> (fdo#111615<https://bugs.freedesktop.org/show_bug.cgi?id=111615>) +6 other tests skip
  *   igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html> (i915#4538<https://gitlab.freedesktop.org/drm/intel/issues/4538>)
  *   igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip.html> (i915#4538<https://gitlab.freedesktop.org/drm/intel/issues/4538> / i915#5190<https://gitlab.freedesktop.org/drm/intel/issues/5190>)
  *   igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html> (i915#3886<https://gitlab.freedesktop.org/drm/intel/issues/3886> / i915#6095<https://gitlab.freedesktop.org/drm/intel/issues/6095>)
  *   igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html> (i915#3689<https://gitlab.freedesktop.org/drm/intel/issues/3689> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>) +4 other tests skip
  *   igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html> (i915#3689<https://gitlab.freedesktop.org/drm/intel/issues/3689> / i915#3886<https://gitlab.freedesktop.org/drm/intel/issues/3886> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>) +2 other tests skip
  *   igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html> (i915#3689<https://gitlab.freedesktop.org/drm/intel/issues/3689> / i915#3886<https://gitlab.freedesktop.org/drm/intel/issues/3886> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354> / i915#6095<https://gitlab.freedesktop.org/drm/intel/issues/6095>)
  *   igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html> (i915#3689<https://gitlab.freedesktop.org/drm/intel/issues/3689> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354> / i915#6095<https://gitlab.freedesktop.org/drm/intel/issues/6095>) +1 other test skip
  *   igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-2/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html> (i915#6095<https://gitlab.freedesktop.org/drm/intel/issues/6095>) +5 other tests skip
  *   igt@kms_ccs@pipe-d-missing-ccs-buffer-4_tiled_mtl_rc_ccs_cc:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_ccs@pipe-d-missing-ccs-buffer-4_tiled_mtl_rc_ccs_cc.html> (i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354> / i915#6095<https://gitlab.freedesktop.org/drm/intel/issues/6095>) +3 other tests skip
  *   igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-7/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3.html> (i915#4087<https://gitlab.freedesktop.org/drm/intel/issues/4087> / i915#7213<https://gitlab.freedesktop.org/drm/intel/issues/7213>) +3 other tests skip
  *   igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-1/igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3.html> (i915#4087<https://gitlab.freedesktop.org/drm/intel/issues/4087>) +3 other tests skip
  *   igt@kms_chamelium_color@gamma:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_chamelium_color@gamma.html> (fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>)
  *   igt@kms_chamelium_frames@dp-crc-single:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_chamelium_frames@dp-crc-single.html> (i915#7828<https://gitlab.freedesktop.org/drm/intel/issues/7828>) +3 other tests skip
  *   igt@kms_chamelium_hpd@dp-hpd:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_chamelium_hpd@dp-hpd.html> (i915#7828<https://gitlab.freedesktop.org/drm/intel/issues/7828>)
  *   igt@kms_color@deep-color:

     *   shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-1/igt@kms_color@deep-color.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555>)
  *   igt@kms_content_protection@atomic:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_content_protection@atomic.html> (i915#7118<https://gitlab.freedesktop.org/drm/intel/issues/7118>)
  *   igt@kms_content_protection@lic@pipe-a-dp-4:

     *   shard-dg2: NOTRUN -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-11/igt@kms_content_protection@lic@pipe-a-dp-4.html> (i915#7173<https://gitlab.freedesktop.org/drm/intel/issues/7173>)
  *   igt@kms_content_protection@mei_interface:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_content_protection@mei_interface.html> (i915#8063<https://gitlab.freedesktop.org/drm/intel/issues/8063>)
  *   igt@kms_cursor_crc@cursor-random-512x170:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@kms_cursor_crc@cursor-random-512x170.html> (i915#3359<https://gitlab.freedesktop.org/drm/intel/issues/3359>) +1 other test skip
  *   igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html> (i915#3546<https://gitlab.freedesktop.org/drm/intel/issues/3546>) +1 other test skip
  *   igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103> / i915#4213<https://gitlab.freedesktop.org/drm/intel/issues/4213>)
  *   igt@kms_cursor_legacy@cursor-vs-flip-toggle:

     *   shard-mtlp: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-8/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html> (i915#8248<https://gitlab.freedesktop.org/drm/intel/issues/8248>)
  *   igt@kms_cursor_legacy@cursora-vs-flipb-legacy:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_cursor_legacy@cursora-vs-flipb-legacy.html> (fdo#109274<https://bugs.freedesktop.org/show_bug.cgi?id=109274> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>)
  *   igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:

     *   shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>)
  *   igt@kms_cursor_legacy@single-move@all-pipes:

     *   shard-mtlp: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_cursor_legacy@single-move@all-pipes.html> (i915#2017<https://gitlab.freedesktop.org/drm/intel/issues/2017>)
  *   igt@kms_dirtyfb@dirtyfb-ioctl@fbc-hdmi-a-4:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-16/igt@kms_dirtyfb@dirtyfb-ioctl@fbc-hdmi-a-4.html> (i915#9227<https://gitlab.freedesktop.org/drm/intel/issues/9227>)
  *   igt@kms_dirtyfb@dirtyfb-ioctl@psr-hdmi-a-4:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-16/igt@kms_dirtyfb@dirtyfb-ioctl@psr-hdmi-a-4.html> (i915#9226<https://gitlab.freedesktop.org/drm/intel/issues/9226> / i915#9261<https://gitlab.freedesktop.org/drm/intel/issues/9261>) +1 other test skip
  *   igt@kms_dither@fb-8bpc-vs-panel-8bpc:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-1/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555>) +2 other tests skip
  *   igt@kms_fbcon_fbt@fbc-suspend:

     *   shard-snb: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb4/igt@kms_fbcon_fbt@fbc-suspend.html> (i915#8841<https://gitlab.freedesktop.org/drm/intel/issues/8841>)
  *   igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html> (i915#2672<https://gitlab.freedesktop.org/drm/intel/issues/2672>) +1 other test skip
  *   igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:

     *   shard-snb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>)
  *   igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc.html> (i915#8708<https://gitlab.freedesktop.org/drm/intel/issues/8708>) +2 other tests skip
  *   igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-wc.html> (i915#1825<https://gitlab.freedesktop.org/drm/intel/issues/1825>) +4 other tests skip
  *   igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:

     *   shard-snb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +62 other tests skip
  *   igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-render.html> (i915#3458<https://gitlab.freedesktop.org/drm/intel/issues/3458>) +1 other test skip
  *   igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html> (i915#8708<https://gitlab.freedesktop.org/drm/intel/issues/8708>)
  *   igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html> (i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>) +14 other tests skip
  *   igt@kms_frontbuffer_tracking@fbcpsr-stridechange:

     *   shard-mtlp: NOTRUN -> ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_frontbuffer_tracking@fbcpsr-stridechange.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>) +1 other test abort
  *   igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_frontbuffer_tracking@fbcpsr-tiling-4.html> (i915#5439<https://gitlab.freedesktop.org/drm/intel/issues/5439>)
  *   igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt.html> (i915#8708<https://gitlab.freedesktop.org/drm/intel/issues/8708>) +4 other tests skip
  *   igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html> (fdo#111825<https://bugs.freedesktop.org/show_bug.cgi?id=111825>) +6 other tests skip
  *   igt@kms_frontbuffer_tracking@psr-suspend:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_frontbuffer_tracking@psr-suspend.html> (i915#3458<https://gitlab.freedesktop.org/drm/intel/issues/3458>) +1 other test skip
  *   igt@kms_hdr@bpc-switch:

     *   shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-1/igt@kms_hdr@bpc-switch.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#8228<https://gitlab.freedesktop.org/drm/intel/issues/8228>)
  *   igt@kms_hdr@bpc-switch-suspend:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-1/igt@kms_hdr@bpc-switch-suspend.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#8228<https://gitlab.freedesktop.org/drm/intel/issues/8228>)
  *   igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html> (i915#5176<https://gitlab.freedesktop.org/drm/intel/issues/5176>) +7 other tests skip
  *   igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-a-hdmi-a-1:

     *   shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-a-hdmi-a-1.html> (i915#5176<https://gitlab.freedesktop.org/drm/intel/issues/5176>) +5 other tests skip
  *   igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-14/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-4.html> (i915#5176<https://gitlab.freedesktop.org/drm/intel/issues/5176>) +27 other tests skip
  *   igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-edp-1:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-edp-1.html> (i915#5235<https://gitlab.freedesktop.org/drm/intel/issues/5235>) +3 other tests skip
  *   igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-3:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-3/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-3.html> (i915#5235<https://gitlab.freedesktop.org/drm/intel/issues/5235>) +19 other tests skip
  *   igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-2:

     *   shard-rkl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-4/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-2.html> (i915#5235<https://gitlab.freedesktop.org/drm/intel/issues/5235>) +3 other tests skip
  *   igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-4:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-4.html> (i915#5235<https://gitlab.freedesktop.org/drm/intel/issues/5235>) +15 other tests skip
  *   igt@kms_psr2_su@page_flip-nv12:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_psr2_su@page_flip-nv12.html> (i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>)
  *   igt@kms_psr2_su@page_flip-p010:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl3/igt@kms_psr2_su@page_flip-p010.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#658<https://gitlab.freedesktop.org/drm/intel/issues/658>)
  *   igt@kms_psr@psr2_primary_mmap_gtt:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_psr@psr2_primary_mmap_gtt.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +1 other test skip
  *   igt@kms_psr@psr2_sprite_plane_move:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@kms_psr@psr2_sprite_plane_move.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>)
  *   igt@kms_universal_plane@cursor-fb-leak-pipe-c:

     *   shard-tglu: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-tglu-2/igt@kms_universal_plane@cursor-fb-leak-pipe-c.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-tglu-8/igt@kms_universal_plane@cursor-fb-leak-pipe-c.html> (i915#9196<https://gitlab.freedesktop.org/drm/intel/issues/9196>)
  *   igt@kms_vblank@pipe-c-ts-continuation-suspend:

     *   shard-dg2: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg2-7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-11/igt@kms_vblank@pipe-c-ts-continuation-suspend.html> (fdo#103375<https://bugs.freedesktop.org/show_bug.cgi?id=103375>)
  *   igt@kms_vblank@pipe-d-wait-idle:

     *   shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl3/igt@kms_vblank@pipe-d-wait-idle.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#533<https://gitlab.freedesktop.org/drm/intel/issues/533>)
  *   igt@kms_vrr@flip-suspend:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@kms_vrr@flip-suspend.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#8808<https://gitlab.freedesktop.org/drm/intel/issues/8808>)
  *   igt@kms_writeback@writeback-check-output:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_writeback@writeback-check-output.html> (i915#2437<https://gitlab.freedesktop.org/drm/intel/issues/2437>) +1 other test skip
  *   igt@perf@polling@1-vcs0:

     *   shard-mtlp: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-6/igt@perf@polling@1-vcs0.html> (i915#9259<https://gitlab.freedesktop.org/drm/intel/issues/9259>)
  *   igt@prime_udl:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@prime_udl.html> (fdo#109291<https://bugs.freedesktop.org/show_bug.cgi?id=109291>)
  *   igt@runner@aborted:

     *   shard-snb: NOTRUN -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb7/igt@runner@aborted.html>) (i915#7812<https://gitlab.freedesktop.org/drm/intel/issues/7812> / i915#8848<https://gitlab.freedesktop.org/drm/intel/issues/8848>)
  *   igt@v3d/v3d_submit_cl@bad-multisync-out-sync:

     *   shard-mtlp: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-7/igt@v3d/v3d_submit_cl@bad-multisync-out-sync.html> (i915#2575<https://gitlab.freedesktop.org/drm/intel/issues/2575>) +2 other tests skip
  *   igt@v3d/v3d_submit_cl@bad-perfmon:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@v3d/v3d_submit_cl@bad-perfmon.html> (i915#2575<https://gitlab.freedesktop.org/drm/intel/issues/2575>) +1 other test skip
  *   igt@v3d/v3d_submit_cl@simple-flush-cache:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@v3d/v3d_submit_cl@simple-flush-cache.html> (i915#2575<https://gitlab.freedesktop.org/drm/intel/issues/2575>) +1 other test skip
  *   igt@vc4/vc4_create_bo@create-bo-4096:

     *   shard-dg2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@vc4/vc4_create_bo@create-bo-4096.html> (i915#7711<https://gitlab.freedesktop.org/drm/intel/issues/7711>) +2 other tests skip
  *   igt@vc4/vc4_label_bo@set-bad-name:

     *   shard-dg1: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@vc4/vc4_label_bo@set-bad-name.html> (i915#7711<https://gitlab.freedesktop.org/drm/intel/issues/7711>) +1 other test skip

Possible fixes

  *   igt@gem_ccs@suspend-resume@tile4-compressed-compfmt0-smem-lmem0:

     *   shard-dg2: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg2-1/igt@gem_ccs@suspend-resume@tile4-compressed-compfmt0-smem-lmem0.html> (i915#7297<https://gitlab.freedesktop.org/drm/intel/issues/7297>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-2/igt@gem_ccs@suspend-resume@tile4-compressed-compfmt0-smem-lmem0.html>
  *   igt@gem_ctx_persistence@legacy-engines-hostile@blt:

     *   shard-mtlp: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-2/igt@gem_ctx_persistence@legacy-engines-hostile@blt.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@gem_ctx_persistence@legacy-engines-hostile@blt.html> +2 other tests pass
  *   igt@gem_exec_fair@basic-deadline:

     *   shard-rkl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html> (i915#2846<https://gitlab.freedesktop.org/drm/intel/issues/2846>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-4/igt@gem_exec_fair@basic-deadline.html>
  *   igt@gem_exec_fair@basic-flow@rcs0:

     *   shard-rkl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-4/igt@gem_exec_fair@basic-flow@rcs0.html> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-6/igt@gem_exec_fair@basic-flow@rcs0.html> +1 other test pass
  *   igt@gem_exec_fair@basic-pace-share@rcs0:

     *   shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html> (i915#2842<https://gitlab.freedesktop.org/drm/intel/issues/2842>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html>
  *   igt@gem_exec_suspend@basic-s4-devices@lmem0:

     *   shard-dg1: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html> (i915#7975<https://gitlab.freedesktop.org/drm/intel/issues/7975> / i915#8213<https://gitlab.freedesktop.org/drm/intel/issues/8213>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@gem_exec_suspend@basic-s4-devices@lmem0.html>
  *   igt@i915_module_load@reload-with-fault-injection:

     *   shard-dg2: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html> (i915#7061<https://gitlab.freedesktop.org/drm/intel/issues/7061> / i915#8617<https://gitlab.freedesktop.org/drm/intel/issues/8617>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-1/igt@i915_module_load@reload-with-fault-injection.html>
  *   igt@i915_pipe_stress@stress-xrgb8888-untiled:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-apl4/igt@i915_pipe_stress@stress-xrgb8888-untiled.html> (i915#7036<https://gitlab.freedesktop.org/drm/intel/issues/7036>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl7/igt@i915_pipe_stress@stress-xrgb8888-untiled.html>
  *   igt@i915_pm_rc6_residency@rc6-idle@vecs0:

     *   shard-dg1: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html> (i915#3591<https://gitlab.freedesktop.org/drm/intel/issues/3591>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@vecs0.html>
  *   igt@i915_pm_rpm@dpms-lpsp:

     *   shard-dg1: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg1-15/igt@i915_pm_rpm@dpms-lpsp.html> (i915#1397<https://gitlab.freedesktop.org/drm/intel/issues/1397>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-19/igt@i915_pm_rpm@dpms-lpsp.html> +3 other tests pass
  *   igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:

     *   shard-rkl: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html> (i915#1397<https://gitlab.freedesktop.org/drm/intel/issues/1397>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-4/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html> +2 other tests pass
  *   igt@i915_pm_rps@reset:

     *   shard-snb: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-snb4/igt@i915_pm_rps@reset.html> (i915#7790<https://gitlab.freedesktop.org/drm/intel/issues/7790>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb4/igt@i915_pm_rps@reset.html>
  *   igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:

     *   shard-tglu: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-tglu-2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html> (i915#3743<https://gitlab.freedesktop.org/drm/intel/issues/3743>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-tglu-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html> +1 other test pass
  *   igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:

     *   shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html> +1 other test pass
  *   igt@kms_fbcon_fbt@fbc-suspend:

     *   shard-tglu: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-tglu-2/igt@kms_fbcon_fbt@fbc-suspend.html> (i915#4767<https://gitlab.freedesktop.org/drm/intel/issues/4767>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-tglu-8/igt@kms_fbcon_fbt@fbc-suspend.html>
  *   igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1:

     *   shard-apl: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1.html> -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-dp-1.html>
  *   igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-edp-1:

     *   shard-mtlp: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-edp-1.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-2/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-edp-1.html> +2 other tests pass
  *   igt@kms_universal_plane@cursor-fb-leak-pipe-b:

     *   shard-tglu: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html> (i915#9196<https://gitlab.freedesktop.org/drm/intel/issues/9196>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html>
  *   igt@kms_universal_plane@cursor-fb-leak-pipe-d:

     *   shard-mtlp: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-5/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html> (i915#9196<https://gitlab.freedesktop.org/drm/intel/issues/9196>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-5/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html>

Warnings

  *   igt@i915_hangman@engine-error-state-capture@vecs0:

     *   shard-mtlp: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-7/igt@i915_hangman@engine-error-state-capture@vecs0.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-6/igt@i915_hangman@engine-error-state-capture@vecs0.html> (i915#9262<https://gitlab.freedesktop.org/drm/intel/issues/9262>)
  *   igt@i915_suspend@basic-s3-without-i915:

     *   shard-snb: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-snb7/igt@i915_suspend@basic-s3-without-i915.html> (fdo#103375<https://bugs.freedesktop.org/show_bug.cgi?id=103375>) -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-snb6/igt@i915_suspend@basic-s3-without-i915.html> (i915#8841<https://gitlab.freedesktop.org/drm/intel/issues/8841>)
  *   igt@kms_content_protection@type1:

     *   shard-dg2: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg2-11/igt@kms_content_protection@type1.html> (i915#7118<https://gitlab.freedesktop.org/drm/intel/issues/7118> / i915#7162<https://gitlab.freedesktop.org/drm/intel/issues/7162>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-10/igt@kms_content_protection@type1.html> (i915#7118<https://gitlab.freedesktop.org/drm/intel/issues/7118>)
  *   igt@kms_force_connector_basic@force-load-detect:

     *   shard-rkl: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-rkl-6/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-rkl-1/igt@kms_force_connector_basic@force-load-detect.html> (fdo#109285<https://bugs.freedesktop.org/show_bug.cgi?id=109285> / i915#4098<https://gitlab.freedesktop.org/drm/intel/issues/4098>)
  *   igt@kms_psr@cursor_plane_move:

     *   shard-dg1: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg1-16/igt@kms_psr@cursor_plane_move.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072> / i915#4078<https://gitlab.freedesktop.org/drm/intel/issues/4078>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg1-17/igt@kms_psr@cursor_plane_move.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072>) +1 other test skip
  *   igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:

     *   shard-dg2: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-dg2-6/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html> (i915#5493<https://gitlab.freedesktop.org/drm/intel/issues/5493>) -> CRASH<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-dg2-6/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html> (i915#7331<https://gitlab.freedesktop.org/drm/intel/issues/7331>)
  *   igt@sysfs_timeslice_duration@timeout@vecs0:

     *   shard-mtlp: ABORT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13635/shard-mtlp-7/igt@sysfs_timeslice_duration@timeout@vecs0.html> (i915#8521<https://gitlab.freedesktop.org/drm/intel/issues/8521> / i915#8865<https://gitlab.freedesktop.org/drm/intel/issues/8865>) -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_123637v4/shard-mtlp-4/igt@sysfs_timeslice_duration@timeout@vecs0.html> (i915#6950<https://gitlab.freedesktop.org/drm/intel/issues/6950>)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

  *   Linux: CI_DRM_13635 -> Patchwork_123637v4

CI-20190529: 20190529
CI_DRM_13635: c6b7f865a77a75af03c3b68baa4cf7eb66c1c6d5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7488: 099e058c5dfb7a49942edf03cae88a52a77077a3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_123637v4: c6b7f865a77a75af03c3b68baa4cf7eb66c1c6d5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
Hogander, Jouni Sept. 18, 2023, 5:50 a.m. UTC | #4
On Wed, 2023-09-13 at 18:01 +0300, Imre Deak wrote:
> On Wed, Sep 13, 2023 at 03:02:58PM +0300, Jani Nikula wrote:
> > On Wed, 13 Sep 2023, Jouni Högander <jouni.hogander@intel.com>
> > wrote:
> > > It's not necessary to carry separate suspended status information
> > > in
> > > intel_runtime_pm struct as this information is already in
> > > underlying device
> > > structure. Remove it and use pm_runtime_suspended() to obtain
> > > suspended
> > > status information when needed.
> > 
> > I started wondering if this is racy, and my conclusion is that it's
> > "less" racy than the original. rpm->suspended gets toggled in the
> > middle
> > of the suspend/resume sequences. So it could be halfway. Dunno if
> > anything *after* those toggles depends on the state having been
> > changed
> > already; didn't find any. Maybe Imre has a better idea.
> > 
> > Also, pm_runtime_suspended() seems more reliable when
> > suspend/resume
> > fails.
> 
> The flag was added in the initial runtime PM enabling patch to detect
> MMIO accesses while runtime suspended, looks like
> pm_runtime_suspended()
> would've worked ok already at that point.
> 
> I wondered how the above detection would change in the system suspend
> /
> resume handlers but that looks ok as well with the disable_depth
> check
> in pm_runtime_suspended():
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> 
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > 

Thank you Imre and Jani for checking my patch. This is now merged.

BR,

Jouni Högander
> > 
> > > 
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > 
> > > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_display_power.c | 2 +-
> > >  drivers/gpu/drm/i915/i915_driver.c                 | 3 ---
> > >  drivers/gpu/drm/i915/i915_gpu_error.c              | 2 +-
> > >  drivers/gpu/drm/i915/intel_runtime_pm.c            | 1 -
> > >  drivers/gpu/drm/i915/intel_runtime_pm.h            | 4 ++--
> > >  5 files changed, 4 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
> > > b/drivers/gpu/drm/i915/display/intel_display_power.c
> > > index 68cf5e6b0b46..889bb26009a2 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> > > @@ -216,7 +216,7 @@ bool __intel_display_power_is_enabled(struct
> > > drm_i915_private *dev_priv,
> > >         struct i915_power_well *power_well;
> > >         bool is_enabled;
> > >  
> > > -       if (dev_priv->runtime_pm.suspended)
> > > +       if (pm_runtime_suspended(dev_priv->drm.dev))
> > >                 return false;
> > >  
> > >         is_enabled = true;
> > > diff --git a/drivers/gpu/drm/i915/i915_driver.c
> > > b/drivers/gpu/drm/i915/i915_driver.c
> > > index f8dbee7a5af7..cd98ee740976 100644
> > > --- a/drivers/gpu/drm/i915/i915_driver.c
> > > +++ b/drivers/gpu/drm/i915/i915_driver.c
> > > @@ -1569,8 +1569,6 @@ static int intel_runtime_suspend(struct
> > > device *kdev)
> > >         if (root_pdev)
> > >                 pci_d3cold_disable(root_pdev);
> > >  
> > > -       rpm->suspended = true;
> > > -
> > >         /*
> > >          * FIXME: We really should find a document that
> > > references the arguments
> > >          * used below!
> > > @@ -1621,7 +1619,6 @@ static int intel_runtime_resume(struct
> > > device *kdev)
> > >         disable_rpm_wakeref_asserts(rpm);
> > >  
> > >         intel_opregion_notify_adapter(dev_priv, PCI_D0);
> > > -       rpm->suspended = false;
> > >  
> > >         root_pdev = pcie_find_root_port(pdev);
> > >         if (root_pdev)
> > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c
> > > b/drivers/gpu/drm/i915/i915_gpu_error.c
> > > index 4008bb09fdb5..a60bab177c55 100644
> > > --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> > > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> > > @@ -1972,7 +1972,7 @@ static void capture_gen(struct
> > > i915_gpu_coredump *error)
> > >         struct drm_i915_private *i915 = error->i915;
> > >  
> > >         error->wakelock = atomic_read(&i915-
> > > >runtime_pm.wakeref_count);
> > > -       error->suspended = i915->runtime_pm.suspended;
> > > +       error->suspended = pm_runtime_suspended(i915->drm.dev);
> > >  
> > >         error->iommu = i915_vtd_active(i915);
> > >         error->reset_count = i915_reset_count(&i915->gpu_error);
> > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > index 6d8e5e5c0cba..8743153fad87 100644
> > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > > @@ -652,7 +652,6 @@ void intel_runtime_pm_init_early(struct
> > > intel_runtime_pm *rpm)
> > >  
> > >         rpm->kdev = kdev;
> > >         rpm->available = HAS_RUNTIME_PM(i915);
> > > -       rpm->suspended = false;
> > >         atomic_set(&rpm->wakeref_count, 0);
> > >  
> > >         init_intel_runtime_pm_wakeref(rpm);
> > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h
> > > b/drivers/gpu/drm/i915/intel_runtime_pm.h
> > > index 764b183ae452..f79cda7a2503 100644
> > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.h
> > > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
> > > @@ -6,6 +6,7 @@
> > >  #ifndef __INTEL_RUNTIME_PM_H__
> > >  #define __INTEL_RUNTIME_PM_H__
> > >  
> > > +#include <linux/pm_runtime.h>
> > >  #include <linux/types.h>
> > >  
> > >  #include "intel_wakeref.h"
> > > @@ -43,7 +44,6 @@ struct intel_runtime_pm {
> > >         atomic_t wakeref_count;
> > >         struct device *kdev; /* points to i915->drm.dev */
> > >         bool available;
> > > -       bool suspended;
> > >         bool irqs_enabled;
> > >         bool no_wakeref_tracking;
> > >  
> > > @@ -110,7 +110,7 @@ intel_rpm_wakelock_count(int wakeref_count)
> > >  static inline void
> > >  assert_rpm_device_not_suspended(struct intel_runtime_pm *rpm)
> > >  {
> > > -       WARN_ONCE(rpm->suspended,
> > > +       WARN_ONCE(pm_runtime_suspended(rpm->kdev),
> > >                   "Device suspended during HW access\n");
> > >  }
> > 
> > -- 
> > Jani Nikula, Intel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 68cf5e6b0b46..889bb26009a2 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -216,7 +216,7 @@  bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
 	struct i915_power_well *power_well;
 	bool is_enabled;
 
-	if (dev_priv->runtime_pm.suspended)
+	if (pm_runtime_suspended(dev_priv->drm.dev))
 		return false;
 
 	is_enabled = true;
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index f8dbee7a5af7..cd98ee740976 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -1569,8 +1569,6 @@  static int intel_runtime_suspend(struct device *kdev)
 	if (root_pdev)
 		pci_d3cold_disable(root_pdev);
 
-	rpm->suspended = true;
-
 	/*
 	 * FIXME: We really should find a document that references the arguments
 	 * used below!
@@ -1621,7 +1619,6 @@  static int intel_runtime_resume(struct device *kdev)
 	disable_rpm_wakeref_asserts(rpm);
 
 	intel_opregion_notify_adapter(dev_priv, PCI_D0);
-	rpm->suspended = false;
 
 	root_pdev = pcie_find_root_port(pdev);
 	if (root_pdev)
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 4008bb09fdb5..a60bab177c55 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1972,7 +1972,7 @@  static void capture_gen(struct i915_gpu_coredump *error)
 	struct drm_i915_private *i915 = error->i915;
 
 	error->wakelock = atomic_read(&i915->runtime_pm.wakeref_count);
-	error->suspended = i915->runtime_pm.suspended;
+	error->suspended = pm_runtime_suspended(i915->drm.dev);
 
 	error->iommu = i915_vtd_active(i915);
 	error->reset_count = i915_reset_count(&i915->gpu_error);
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 6d8e5e5c0cba..8743153fad87 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -652,7 +652,6 @@  void intel_runtime_pm_init_early(struct intel_runtime_pm *rpm)
 
 	rpm->kdev = kdev;
 	rpm->available = HAS_RUNTIME_PM(i915);
-	rpm->suspended = false;
 	atomic_set(&rpm->wakeref_count, 0);
 
 	init_intel_runtime_pm_wakeref(rpm);
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h b/drivers/gpu/drm/i915/intel_runtime_pm.h
index 764b183ae452..f79cda7a2503 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.h
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
@@ -6,6 +6,7 @@ 
 #ifndef __INTEL_RUNTIME_PM_H__
 #define __INTEL_RUNTIME_PM_H__
 
+#include <linux/pm_runtime.h>
 #include <linux/types.h>
 
 #include "intel_wakeref.h"
@@ -43,7 +44,6 @@  struct intel_runtime_pm {
 	atomic_t wakeref_count;
 	struct device *kdev; /* points to i915->drm.dev */
 	bool available;
-	bool suspended;
 	bool irqs_enabled;
 	bool no_wakeref_tracking;
 
@@ -110,7 +110,7 @@  intel_rpm_wakelock_count(int wakeref_count)
 static inline void
 assert_rpm_device_not_suspended(struct intel_runtime_pm *rpm)
 {
-	WARN_ONCE(rpm->suspended,
+	WARN_ONCE(pm_runtime_suspended(rpm->kdev),
 		  "Device suspended during HW access\n");
 }