diff mbox series

[01/21] parallels: fix formatting in bdrv_parallels initialization

Message ID 20230915184130.403366-2-den@openvz.org (mailing list archive)
State New, archived
Headers show
Series implement discard operation for Parallels images | expand

Commit Message

Denis V. Lunev Sept. 15, 2023, 6:41 p.m. UTC 
Old code is ugly and contains tabulations. There are no functional
changes in this patch.

Signed-off-by: Denis V. Lunev <den@openvz.org>
---
 block/parallels.c | 36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

Comments

Alexander Ivanov Sept. 18, 2023, 7:41 a.m. UTC | #1 
On 9/15/23 20:41, Denis V. Lunev wrote:
> Old code is ugly and contains tabulations. There are no functional
> changes in this patch.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>   block/parallels.c | 36 +++++++++++++++++++-----------------
>   1 file changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 48c32d6821..2ebd8e1301 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -1249,23 +1249,25 @@ static void parallels_close(BlockDriverState *bs)
>   }
>   
>   static BlockDriver bdrv_parallels = {
> -    .format_name	= "parallels",
> -    .instance_size	= sizeof(BDRVParallelsState),
> -    .bdrv_probe		= parallels_probe,
> -    .bdrv_open		= parallels_open,
> -    .bdrv_close		= parallels_close,
> -    .bdrv_child_perm          = bdrv_default_perms,
> -    .bdrv_co_block_status     = parallels_co_block_status,
> -    .bdrv_has_zero_init       = bdrv_has_zero_init_1,
> -    .bdrv_co_flush_to_os      = parallels_co_flush_to_os,
> -    .bdrv_co_readv  = parallels_co_readv,
> -    .bdrv_co_writev = parallels_co_writev,
> -    .is_format      = true,
> -    .supports_backing = true,
> -    .bdrv_co_create      = parallels_co_create,
> -    .bdrv_co_create_opts = parallels_co_create_opts,
> -    .bdrv_co_check  = parallels_co_check,
> -    .create_opts    = &parallels_create_opts,
> +    .format_name                = "parallels",
> +    .instance_size              = sizeof(BDRVParallelsState),
> +    .create_opts                = &parallels_create_opts,
> +    .is_format                  = true,
> +    .supports_backing           = true,
> +
> +    .bdrv_has_zero_init         = bdrv_has_zero_init_1,
> +
> +    .bdrv_probe                 = parallels_probe,
> +    .bdrv_open                  = parallels_open,
> +    .bdrv_close                 = parallels_close,
> +    .bdrv_child_perm            = bdrv_default_perms,
> +    .bdrv_co_block_status       = parallels_co_block_status,
> +    .bdrv_co_flush_to_os        = parallels_co_flush_to_os,
> +    .bdrv_co_readv              = parallels_co_readv,
> +    .bdrv_co_writev             = parallels_co_writev,
> +    .bdrv_co_create             = parallels_co_create,
> +    .bdrv_co_create_opts        = parallels_co_create_opts,
> +    .bdrv_co_check              = parallels_co_check,
>   };
>   
>   static void bdrv_parallels_init(void)
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Alexander Ivanov Sept. 18, 2023, 7:42 a.m. UTC | #2 
On 9/15/23 20:41, Denis V. Lunev wrote:
> Old code is ugly and contains tabulations. There are no functional
> changes in this patch.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
>   block/parallels.c | 36 +++++++++++++++++++-----------------
>   1 file changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 48c32d6821..2ebd8e1301 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -1249,23 +1249,25 @@ static void parallels_close(BlockDriverState *bs)
>   }
>   
>   static BlockDriver bdrv_parallels = {
> -    .format_name	= "parallels",
> -    .instance_size	= sizeof(BDRVParallelsState),
> -    .bdrv_probe		= parallels_probe,
> -    .bdrv_open		= parallels_open,
> -    .bdrv_close		= parallels_close,
> -    .bdrv_child_perm          = bdrv_default_perms,
> -    .bdrv_co_block_status     = parallels_co_block_status,
> -    .bdrv_has_zero_init       = bdrv_has_zero_init_1,
> -    .bdrv_co_flush_to_os      = parallels_co_flush_to_os,
> -    .bdrv_co_readv  = parallels_co_readv,
> -    .bdrv_co_writev = parallels_co_writev,
> -    .is_format      = true,
> -    .supports_backing = true,
> -    .bdrv_co_create      = parallels_co_create,
> -    .bdrv_co_create_opts = parallels_co_create_opts,
> -    .bdrv_co_check  = parallels_co_check,
> -    .create_opts    = &parallels_create_opts,
> +    .format_name                = "parallels",
> +    .instance_size              = sizeof(BDRVParallelsState),
> +    .create_opts                = &parallels_create_opts,
> +    .is_format                  = true,
> +    .supports_backing           = true,
> +
> +    .bdrv_has_zero_init         = bdrv_has_zero_init_1,
> +
> +    .bdrv_probe                 = parallels_probe,
> +    .bdrv_open                  = parallels_open,
> +    .bdrv_close                 = parallels_close,
> +    .bdrv_child_perm            = bdrv_default_perms,
> +    .bdrv_co_block_status       = parallels_co_block_status,
> +    .bdrv_co_flush_to_os        = parallels_co_flush_to_os,
> +    .bdrv_co_readv              = parallels_co_readv,
> +    .bdrv_co_writev             = parallels_co_writev,
> +    .bdrv_co_create             = parallels_co_create,
> +    .bdrv_co_create_opts        = parallels_co_create_opts,
> +    .bdrv_co_check              = parallels_co_check,
>   };
>   
>   static void bdrv_parallels_init(void)
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
diff mbox series

Patch

diff --git a/block/parallels.c b/block/parallels.c
index 48c32d6821..2ebd8e1301 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1249,23 +1249,25 @@  static void parallels_close(BlockDriverState *bs)
 }
 
 static BlockDriver bdrv_parallels = {
-    .format_name	= "parallels",
-    .instance_size	= sizeof(BDRVParallelsState),
-    .bdrv_probe		= parallels_probe,
-    .bdrv_open		= parallels_open,
-    .bdrv_close		= parallels_close,
-    .bdrv_child_perm          = bdrv_default_perms,
-    .bdrv_co_block_status     = parallels_co_block_status,
-    .bdrv_has_zero_init       = bdrv_has_zero_init_1,
-    .bdrv_co_flush_to_os      = parallels_co_flush_to_os,
-    .bdrv_co_readv  = parallels_co_readv,
-    .bdrv_co_writev = parallels_co_writev,
-    .is_format      = true,
-    .supports_backing = true,
-    .bdrv_co_create      = parallels_co_create,
-    .bdrv_co_create_opts = parallels_co_create_opts,
-    .bdrv_co_check  = parallels_co_check,
-    .create_opts    = &parallels_create_opts,
+    .format_name                = "parallels",
+    .instance_size              = sizeof(BDRVParallelsState),
+    .create_opts                = &parallels_create_opts,
+    .is_format                  = true,
+    .supports_backing           = true,
+
+    .bdrv_has_zero_init         = bdrv_has_zero_init_1,
+
+    .bdrv_probe                 = parallels_probe,
+    .bdrv_open                  = parallels_open,
+    .bdrv_close                 = parallels_close,
+    .bdrv_child_perm            = bdrv_default_perms,
+    .bdrv_co_block_status       = parallels_co_block_status,
+    .bdrv_co_flush_to_os        = parallels_co_flush_to_os,
+    .bdrv_co_readv              = parallels_co_readv,
+    .bdrv_co_writev             = parallels_co_writev,
+    .bdrv_co_create             = parallels_co_create,
+    .bdrv_co_create_opts        = parallels_co_create_opts,
+    .bdrv_co_check              = parallels_co_check,
 };
 
 static void bdrv_parallels_init(void)