| Message ID | ebde071cc3cc9c35b00366c41912ee2f25e5282d.1695032291.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c80471ba74b7f332ac19b985ccb76d852d507acf |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add WED support for MT7988 chipset | expand |
On Mon, Sep 18, 2023 at 12:29:11PM +0200, Lorenzo Bianconi wrote: > Fix MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH and > MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH definitions for MT7986 (MT7986 is > the only SoC to use them). Afaik this applies also to MT7981 which is very similar to MT7986. > > Fixes: de84a090d99a ("net: ethernet: mtk_eth_wed: add wed support for mt7986 chipset") > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > drivers/net/ethernet/mediatek/mtk_wed_regs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_wed_regs.h b/drivers/net/ethernet/mediatek/mtk_wed_regs.h > index 47ea69feb3b2..f87ab9b8a590 100644 > --- a/drivers/net/ethernet/mediatek/mtk_wed_regs.h > +++ b/drivers/net/ethernet/mediatek/mtk_wed_regs.h > @@ -64,8 +64,8 @@ struct mtk_wdma_desc { > #define MTK_WED_EXT_INT_STATUS_TKID_TITO_INVALID BIT(4) > #define MTK_WED_EXT_INT_STATUS_TX_FBUF_LO_TH BIT(8) > #define MTK_WED_EXT_INT_STATUS_TX_FBUF_HI_TH BIT(9) > -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(12) > -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(13) > +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(10) /* wed v2 */ > +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(11) /* wed v2 */ > #define MTK_WED_EXT_INT_STATUS_RX_DRV_R_RESP_ERR BIT(16) > #define MTK_WED_EXT_INT_STATUS_RX_DRV_W_RESP_ERR BIT(17) > #define MTK_WED_EXT_INT_STATUS_RX_DRV_COHERENT BIT(18) > -- > 2.41.0 > >
> On Mon, Sep 18, 2023 at 12:29:11PM +0200, Lorenzo Bianconi wrote: > > Fix MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH and > > MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH definitions for MT7986 (MT7986 is > > the only SoC to use them). > > Afaik this applies also to MT7981 which is very similar to MT7986. ack, fine. Can you please test it out when you have some free cycles? I do not have a MT7981 device for testing. Regards, Lorenzo > > > > > Fixes: de84a090d99a ("net: ethernet: mtk_eth_wed: add wed support for mt7986 chipset") > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > > --- > > drivers/net/ethernet/mediatek/mtk_wed_regs.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/mediatek/mtk_wed_regs.h b/drivers/net/ethernet/mediatek/mtk_wed_regs.h > > index 47ea69feb3b2..f87ab9b8a590 100644 > > --- a/drivers/net/ethernet/mediatek/mtk_wed_regs.h > > +++ b/drivers/net/ethernet/mediatek/mtk_wed_regs.h > > @@ -64,8 +64,8 @@ struct mtk_wdma_desc { > > #define MTK_WED_EXT_INT_STATUS_TKID_TITO_INVALID BIT(4) > > #define MTK_WED_EXT_INT_STATUS_TX_FBUF_LO_TH BIT(8) > > #define MTK_WED_EXT_INT_STATUS_TX_FBUF_HI_TH BIT(9) > > -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(12) > > -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(13) > > +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(10) /* wed v2 */ > > +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(11) /* wed v2 */ > > #define MTK_WED_EXT_INT_STATUS_RX_DRV_R_RESP_ERR BIT(16) > > #define MTK_WED_EXT_INT_STATUS_RX_DRV_W_RESP_ERR BIT(17) > > #define MTK_WED_EXT_INT_STATUS_RX_DRV_COHERENT BIT(18) > > -- > > 2.41.0 > > > >
On Mon, 2023-09-18 at 12:35 +0100, Daniel Golle wrote: > On Mon, Sep 18, 2023 at 12:29:11PM +0200, Lorenzo Bianconi wrote: > > Fix MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH and > > MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH definitions for MT7986 (MT7986 is > > the only SoC to use them). > > Afaik this applies also to MT7981 which is very similar to MT7986. FTR, I read the above as this series is going to additionally support/work fine with MT7981; no modification asked here, fine to be merged. Please scream loudly soon otherwise ;) Thanks, Paolo
diff --git a/drivers/net/ethernet/mediatek/mtk_wed_regs.h b/drivers/net/ethernet/mediatek/mtk_wed_regs.h index 47ea69feb3b2..f87ab9b8a590 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed_regs.h +++ b/drivers/net/ethernet/mediatek/mtk_wed_regs.h @@ -64,8 +64,8 @@ struct mtk_wdma_desc { #define MTK_WED_EXT_INT_STATUS_TKID_TITO_INVALID BIT(4) #define MTK_WED_EXT_INT_STATUS_TX_FBUF_LO_TH BIT(8) #define MTK_WED_EXT_INT_STATUS_TX_FBUF_HI_TH BIT(9) -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(12) -#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(13) +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH BIT(10) /* wed v2 */ +#define MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH BIT(11) /* wed v2 */ #define MTK_WED_EXT_INT_STATUS_RX_DRV_R_RESP_ERR BIT(16) #define MTK_WED_EXT_INT_STATUS_RX_DRV_W_RESP_ERR BIT(17) #define MTK_WED_EXT_INT_STATUS_RX_DRV_COHERENT BIT(18)
Fix MTK_WED_EXT_INT_STATUS_RX_FBUF_LO_TH and MTK_WED_EXT_INT_STATUS_RX_FBUF_HI_TH definitions for MT7986 (MT7986 is the only SoC to use them). Fixes: de84a090d99a ("net: ethernet: mtk_eth_wed: add wed support for mt7986 chipset") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/ethernet/mediatek/mtk_wed_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)