mbox series

[0/7] platform/surface: Convert to platform remove callback returning void

Message ID 20230917203805.1149595-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series platform/surface: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König Sept. 17, 2023, 8:37 p.m. UTC
Hello,

this series converts all platform drivers below drivers/platform/surface
to use .remove_new. The motivation is to get rid of an integer return
code that is (mostly) ignored by the platform driver core. 

See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal.

Best regards
Uwe

Uwe Kleine-König (7):
  platform/surface: surface3-wmi: Convert to platform remove callback
    returning void
  platform/surface: acpi-notify: Convert to platform remove callback
    returning void
  platform/surface: aggregator-cdev: Convert to platform remove callback
    returning void
  platform/surface: aggregator-registry: Convert to platform remove
    callback returning void
  platform/surface: dtx: Convert to platform remove callback returning
    void
  platform/surface: gpe: Convert to platform remove callback returning
    void
  platform/surface: hotplug: Convert to platform remove callback
    returning void

 drivers/platform/surface/surface3-wmi.c                | 5 ++---
 drivers/platform/surface/surface_acpi_notify.c         | 6 ++----
 drivers/platform/surface/surface_aggregator_cdev.c     | 5 ++---
 drivers/platform/surface/surface_aggregator_registry.c | 5 ++---
 drivers/platform/surface/surface_dtx.c                 | 5 ++---
 drivers/platform/surface/surface_gpe.c                 | 6 ++----
 drivers/platform/surface/surface_hotplug.c             | 6 ++----
 7 files changed, 14 insertions(+), 24 deletions(-)


base-commit: dfa449a58323de195773cf928d99db4130702bf7

Comments

Hans de Goede Sept. 18, 2023, 1:47 p.m. UTC | #1
Hi,

On 9/17/23 22:37, Uwe Kleine-König wrote:
> Hello,
> 
> this series converts all platform drivers below drivers/platform/surface
> to use .remove_new. The motivation is to get rid of an integer return
> code that is (mostly) ignored by the platform driver core. 
> 
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
> 
> Best regards
> Uwe

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> Uwe Kleine-König (7):
>   platform/surface: surface3-wmi: Convert to platform remove callback
>     returning void
>   platform/surface: acpi-notify: Convert to platform remove callback
>     returning void
>   platform/surface: aggregator-cdev: Convert to platform remove callback
>     returning void
>   platform/surface: aggregator-registry: Convert to platform remove
>     callback returning void
>   platform/surface: dtx: Convert to platform remove callback returning
>     void
>   platform/surface: gpe: Convert to platform remove callback returning
>     void
>   platform/surface: hotplug: Convert to platform remove callback
>     returning void
> 
>  drivers/platform/surface/surface3-wmi.c                | 5 ++---
>  drivers/platform/surface/surface_acpi_notify.c         | 6 ++----
>  drivers/platform/surface/surface_aggregator_cdev.c     | 5 ++---
>  drivers/platform/surface/surface_aggregator_registry.c | 5 ++---
>  drivers/platform/surface/surface_dtx.c                 | 5 ++---
>  drivers/platform/surface/surface_gpe.c                 | 6 ++----
>  drivers/platform/surface/surface_hotplug.c             | 6 ++----
>  7 files changed, 14 insertions(+), 24 deletions(-)
> 
> 
> base-commit: dfa449a58323de195773cf928d99db4130702bf7
Maximilian Luz Sept. 18, 2023, 2:01 p.m. UTC | #2
Am 17/09/2023 um 22:37 schrieb Uwe Kleine-König:
> Hello,
> 
> this series converts all platform drivers below drivers/platform/surface
> to use .remove_new. The motivation is to get rid of an integer return
> code that is (mostly) ignored by the platform driver core.
> 
> See commit 5c5a7680e67b ("platform: Provide a remove callback that
> returns no value") for an extended explanation and the eventual goal.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (7):
>    platform/surface: surface3-wmi: Convert to platform remove callback
>      returning void
>    platform/surface: acpi-notify: Convert to platform remove callback
>      returning void
>    platform/surface: aggregator-cdev: Convert to platform remove callback
>      returning void
>    platform/surface: aggregator-registry: Convert to platform remove
>      callback returning void
>    platform/surface: dtx: Convert to platform remove callback returning
>      void
>    platform/surface: gpe: Convert to platform remove callback returning
>      void
>    platform/surface: hotplug: Convert to platform remove callback
>      returning void
> 
>   drivers/platform/surface/surface3-wmi.c                | 5 ++---
>   drivers/platform/surface/surface_acpi_notify.c         | 6 ++----
>   drivers/platform/surface/surface_aggregator_cdev.c     | 5 ++---
>   drivers/platform/surface/surface_aggregator_registry.c | 5 ++---
>   drivers/platform/surface/surface_dtx.c                 | 5 ++---
>   drivers/platform/surface/surface_gpe.c                 | 6 ++----
>   drivers/platform/surface/surface_hotplug.c             | 6 ++----
>   7 files changed, 14 insertions(+), 24 deletions(-)
> 
> 
> base-commit: dfa449a58323de195773cf928d99db4130702bf7

If it's not too late:

Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

Thanks,
Max